fix(login): avoid broken default workspace redirect for time tracking

Author: Rocket-Quack

time_tracking/test_utils.py

@@ -0,0 +1,55 @@
+from unittest.mock import patch
+
+import frappe
+from frappe.tests.utils import FrappeTestCase
+
+from time_tracking.utils import DEFAULT_WORKSPACE_ROUTE, ensure_default_workspace
+
+
+class TestLoginWorkspaceRedirect(FrappeTestCase):
+	def tearDown(self):
+		if hasattr(frappe.local.flags, "home_page"):
+			del frappe.local.flags.home_page
+		super().tearDown()
+
+	def test_sets_home_page_for_users_without_explicit_workspace(self):
+		with (
+			patch.object(frappe.session, "user", "test@example.com"),
+			patch.object(
+				frappe.db,
+				"get_value",
+				side_effect=["System User", None],
+			),
+			patch.object(frappe.db, "exists", return_value=True),
+		):
+			ensure_default_workspace()
+
+		self.assertEqual(frappe.local.flags.home_page, DEFAULT_WORKSPACE_ROUTE)
+
+	def test_sets_home_page_for_existing_time_tracking_default_workspace(self):
+		with (
+			patch.object(frappe.session, "user", "test@example.com"),
+			patch.object(
+				frappe.db,
+				"get_value",
+				side_effect=["System User", "Time Tracking"],
+			),
+			patch.object(frappe.db, "exists", return_value=True),
+		):
+			ensure_default_workspace()
+
+		self.assertEqual(frappe.local.flags.home_page, DEFAULT_WORKSPACE_ROUTE)
+
+	def test_keeps_other_explicit_default_workspace(self):
+		with (
+			patch.object(frappe.session, "user", "test@example.com"),
+			patch.object(
+				frappe.db,
+				"get_value",
+				side_effect=["System User", "Accounts"],
+			),
+			patch.object(frappe.db, "exists", return_value=True),
+		):
+			ensure_default_workspace()
+
+		self.assertFalse(hasattr(frappe.local.flags, "home_page"))

time_tracking/utils.py

@@ -1,6 +1,7 @@
 import frappe
 
 DEFAULT_WORKSPACE = "Time Tracking"
+DEFAULT_WORKSPACE_ROUTE = "/desk/time-tracking"
 
 
 def ensure_default_workspace(login_manager=None):
@@ -12,10 +13,12 @@ def ensure_default_workspace(login_manager=None):
 	if user_type != "System User":
 		return
 
-	if frappe.db.get_value("User", user, "default_workspace"):
+	if not frappe.db.exists("Workspace", DEFAULT_WORKSPACE):
 		return
 
-	if not frappe.db.exists("Workspace", DEFAULT_WORKSPACE):
+	default_workspace = frappe.db.get_value("User", user, "default_workspace")
+	if default_workspace and default_workspace != DEFAULT_WORKSPACE:
 		return
 
-	frappe.db.set_value("User", user, "default_workspace", DEFAULT_WORKSPACE)
+	# Work around Frappe's login redirect using `workspace.lower()` instead of a slug.
+	frappe.local.flags.home_page = DEFAULT_WORKSPACE_ROUTE