Skip to content

fix: resolve login crash, infinite renders, and logout scroll bugs#1319

Merged
Spiral-Memory merged 1 commit into
RocketChat:developfrom
Aryan-Verma-999:fix/auth-render-loops
Jun 6, 2026
Merged

fix: resolve login crash, infinite renders, and logout scroll bugs#1319
Spiral-Memory merged 1 commit into
RocketChat:developfrom
Aryan-Verma-999:fix/auth-render-loops

Conversation

@Aryan-Verma-999
Copy link
Copy Markdown
Contributor

@Aryan-Verma-999 Aryan-Verma-999 commented Jun 3, 2026

Fix: Resolve Login Crash, Infinite Renders, and Logout Scroll Bugs

Acceptance Criteria fulfillment

  • Fix DataCloneError and modal unresponsiveness when clicking the "show password" icon.
  • Fix the bug where successful login does not render the chat window.
  • Eliminate the infinite re-render loop that bombarded the /api/v1/login endpoint with requests (429 Too Many Requests).
  • Verify changes work gracefully in both development and build environments.

Video/Screenshots

2026-06-03.19-49-15.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1319 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory Spiral-Memory merged commit f3b2a0f into RocketChat:develop Jun 6, 2026
4 checks passed
github-actions Bot added a commit that referenced this pull request Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants