fix: resolve private channel error-room-not-found race condition#1323
Open
Aryan-Verma-999 wants to merge 1 commit into
Open
fix: resolve private channel error-room-not-found race condition#1323Aryan-Verma-999 wants to merge 1 commit into
Aryan-Verma-999 wants to merge 1 commit into
Conversation
Collaborator
|
Please resolve conflicts @Aryan-Verma-999 |
…fore fetching messages
Aryan-Verma-999
force-pushed
the
fix/private-channel-race-condition
branch
from
46b24d8 to
1828502
Compare
Contributor
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: resolve private channel error-room-not-found race condition
Acceptance Criteria fulfillment
Root Cause
When a user authenticated, two effects fired simultaneously:
isChannelPrivate defaulted to false, making it impossible to distinguish "not loaded yet" from "confirmed public".
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1323 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.