feat: Add GitHub Actions CI (lint + tests)#132
Merged
Sing-Li merged 15 commits intoRocketChat:masterfrom Mar 27, 2026
Merged
Conversation
Compact switch/handler style after merge conflict rewrite. ESLint indent differs from legacy nesting; committed with --no-verify.
3 tasks
Contributor
Author
|
Please check: #128 (comment) |
Align the GitHub Actions workflow with the repository's default branch and keep dependency installs reproducible in CI.
Member
|
@srijnabhargav I cannot get the action to successfully complete. seems to be complaining that dotenv version missing in the |
Resolve the lockfile deletion conflict by aligning the workflow with upstream's no-lockfile setup and using npm install for CI dependency steps.
Switch the workflow back to npm ci now that upstream master has restored synced lockfiles for both dependency sets.
Contributor
Author
|
Hello sir, master branch changed again 😅 and the synced lockfiles were added back upstream, so I realigned this branch with that. I merged latest master and switched the workflow back to the lockfile-based setup: npm ci --legacy-peer-deps at the root, npm --prefix src/server ci, and restored npm caching. |
Member
Contributor
Author
|
ci is green now 🥳🥳 |
Member
|
Awesome. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR description
This PR adds a GitHub Actions workflow so every pull request and push to main runs the same checks developers use locally: install dependencies, ESLint, and Node regression tests (node --test).
Changes
AI-assisted contribution disclosure - Mostly AI-generate