fix: propagate npm install errors in rc-apps create#192
Open
jituchoudhary367 wants to merge 1 commit intoRocketChat:masterfrom
Open
fix: propagate npm install errors in rc-apps create#192jituchoudhary367 wants to merge 1 commit intoRocketChat:masterfrom
jituchoudhary367 wants to merge 1 commit intoRocketChat:masterfrom
Conversation
When npm install fails during app scaffolding, the previous reject() call passed no argument, making the rejection reason undefined and the CLI output completely useless. - Pass stderr (or exec error message) to reject() with a clear message - Wrap writeFiles() in try/catch in create.ts so failures surface correctly - Fix copy-paste validation message: 'color' -> 'category' in submit.ts
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When npm install fails during app scaffolding, the previous reject() call passed no argument, making the rejection reason undefined and the CLI output completely useless.