fix: file key normalization

Author: d-gubert

src/compiler/AppsEngineValidator.ts

@@ -114,6 +114,7 @@ export class AppsEngineValidator {
         filename: string,
         compilationResult: ICompilerResult,
     ): any {
+        filename = filename.replace(/\\/g, "/");
         const exports = {};
         const context = vm.createContext({
             require: (filepath: string) => {

src/compiler/TscBasedCompiler.ts

@@ -39,8 +39,10 @@ export class TscBasedCompiler {
     }: IAppSource): Promise<ICompilerResult> {
         const startTime = Date.now();
 
+        const posixClassFile = appInfo.classFile.replace(/\\/g, "/");
+
         // Entry‐file must exist
-        if (!appInfo.classFile || !sourceFiles[appInfo.classFile]) {
+        if (!posixClassFile || !sourceFiles[posixClassFile]) {
             throw new Error(
                 `Invalid App package. Could not find the classFile (${appInfo.classFile}).`,
             );
@@ -228,21 +230,21 @@ export class TscBasedCompiler {
         await collect(path.join(this.sourcePath, BUILD_DIR));
 
         // Point at the main JS file
-        const mainJs = appInfo.classFile.replace(/\.ts$/, ".js");
+        const mainJs = posixClassFile.replace(/\.ts$/, ".js");
         result.mainFile = result.files[mainJs];
 
         // Extract implemented interfaces from the TS AST
         const srcNode = TS.createSourceFile(
-            appInfo.classFile,
-            sourceFiles[appInfo.classFile].content,
+            posixClassFile,
+            sourceFiles[posixClassFile].content,
             TS.ScriptTarget.Latest,
             true,
         );
         result.implemented = this.extractInterfaces(srcNode);
 
         // Run inheritance checks
         this.appValidator.checkInheritance(
-            appInfo.classFile.replace(/\.ts$/, ""),
+            posixClassFile.replace(/\.ts$/, ""),
             result,
         );
 

src/compiler/TypescriptCompiler.ts

@@ -2,7 +2,6 @@ import { EventEmitter } from "events";
 import fs from "fs";
 import path from "path";
 
-import type { IAppInfo } from "@rocket.chat/apps-engine/definition/metadata";
 import type {
     CompilerOptions,
     EmitOutput,
@@ -59,10 +58,24 @@ export class TypescriptCompiler {
         appInfo,
         sourceFiles: files,
     }: IAppSource): ICompilerResult {
+        // Normalize all file keys, file names, and classFile to POSIX separators
+        // once up front so getScriptFileNames(), getScriptVersion(), getScriptSnapshot(),
+        // and all subsequent lookups into result.files operate on consistent keys.
+        const posixClassFile = appInfo.classFile.replace(/\\/g, "/");
+        const normalizedFiles: IMapCompilerFile = {};
+        for (const [key, file] of Object.entries(files)) {
+            const posixKey = key.replace(/\\/g, "/");
+            normalizedFiles[posixKey] = {
+                ...file,
+                name: file.name.replace(/\\/g, "/"),
+            };
+        }
+        files = normalizedFiles;
+
         if (
-            !appInfo.classFile ||
-            !files[appInfo.classFile] ||
-            !this.isValidFile(files[appInfo.classFile])
+            !posixClassFile ||
+            !files[posixClassFile] ||
+            !this.isValidFile(files[posixClassFile])
         ) {
             throw new Error(
                 `Invalid App package. Could not find the classFile (${appInfo.classFile}) file.`,
@@ -219,7 +232,7 @@ export class TypescriptCompiler {
 
         result.implemented = this.getImplementedInterfaces(
             languageService,
-            appInfo,
+            posixClassFile,
         );
 
         Object.defineProperty(result, "diagnostics", {
@@ -242,11 +255,10 @@ export class TypescriptCompiler {
             file.compiled = output.outputFiles[0].text;
         });
 
-        result.mainFile =
-            result.files[appInfo.classFile.replace(/\.ts$/, ".js")];
+        result.mainFile = result.files[posixClassFile.replace(/\.ts$/, ".js")];
 
         this.appValidator.checkInheritance(
-            appInfo.classFile.replace(/\.ts$/, ""),
+            posixClassFile.replace(/\.ts$/, ""),
             result,
         );
 
@@ -344,13 +356,11 @@ export class TypescriptCompiler {
 
     private getImplementedInterfaces(
         languageService: LanguageService,
-        appInfo: IAppInfo,
+        classFile: string,
     ): ICompilerResult["implemented"] {
         const result: ICompilerResult["implemented"] = [];
 
-        const src = languageService
-            .getProgram()
-            .getSourceFile(appInfo.classFile);
+        const src = languageService.getProgram().getSourceFile(classFile);
 
         this.ts.forEachChild(src, (n) => {
             if (!this.ts.isClassDeclaration(n)) {
@@ -406,10 +416,6 @@ export class TypescriptCompiler {
             return false;
         }
 
-        return (
-            file.name.trim() !== "" &&
-            path.posix.normalize(file.name) &&
-            file.content.trim() !== ""
-        );
+        return file.name.trim() !== "" && file.content.trim() !== "";
     }
 }