-
Notifications
You must be signed in to change notification settings - Fork 822
Fix/injected ts setinterval polling #3254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
613b65c
a89280f
75276d1
1f7da37
17837bf
92ce268
86b60cf
5385a01
a944394
6c93147
af11ebe
6963504
05a056b
3ee5083
1c567bc
084db04
9b94f75
641e69b
fedb593
fad023a
2949e54
bd3c373
b0e0f6f
f0dbdc7
df65589
8765bef
d1bd90c
acaf577
25542d5
6616033
7723c4a
157a64f
4d4c984
68bab71
7fcaaf6
fef5f6c
8062690
a089f88
86a6eb9
d051807
39884a7
6d9b521
f92960f
8b4208e
4426825
8a909cb
d2e27ee
a84f8ad
eecd1e5
c770a8e
a948e21
cedf309
a89bf17
ed43433
00588fa
135ff37
a14fa58
9a7fb81
7695c80
69efb9e
c8857a6
73c2f8e
d840c77
5fff3a6
a5e0bc1
f8ee2c3
5df82c6
6e4e6c3
5b77f31
a167ecf
e0ab7d4
3cdfb16
c3cb24e
39ef03e
f566baa
48d9c1a
abe5390
d614c2c
a78e4b7
051c147
d75e8ed
0e7d83e
98551b7
b0e794e
76c6997
e457303
643a04a
06c7765
220992c
4663dcc
b64105e
84de523
a70dfc6
8ba4976
3b1c7c3
6298e8c
376260f
5f96eb0
22c1646
4171c82
3dadff9
5f76d14
f4fa783
ddb3abc
8e2b092
37379ce
0af914a
0299c92
032fdda
a47fd4f
6c95653
ad2cbf3
49261f5
672f676
85ee1ac
655fd55
6c7e68b
d586834
8476653
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "setup-worktree": [ | ||
| "yarn install" | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| /node_modules | ||
| /app | ||
| /workspaces/* | ||
| # Standalone tooling scripts (not part of main app, run with ts-node) | ||
| /scripts | ||
| # Patch source files (copied to node_modules, not compiled directly) | ||
| /patches-src |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,16 @@ | ||
| permissions: | ||
| contents: read | ||
| name: Build release | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| - develop | ||
| - dev | ||
| tags: | ||
| - '*' | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.head_ref }} | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
|
|
@@ -31,10 +32,10 @@ jobs: | |
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Setup Node 22.13.1 | ||
| - name: Setup Node 22.17.1 | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '22.13.1' | ||
| node-version: '22.17.1' | ||
|
|
||
| - name: Setup node_modules cache | ||
| uses: actions/cache@v4 | ||
|
|
@@ -63,15 +64,31 @@ jobs: | |
| NODE_ENV: production | ||
| BUGSNAG_API_KEY: ${{ secrets.BUGSNAG_API_KEY }} | ||
| SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAPCRAFT_STORE_CREDENTIALS }} | ||
|
|
||
| - name: Setup gcloud (Windows) | ||
| if: ${{ matrix.os == 'windows-latest' }} | ||
| uses: google-github-actions/setup-gcloud@v2 | ||
| with: | ||
| version: '>=536.0.0' | ||
|
|
||
| - name: Authenticate to Google Cloud (Windows) | ||
| if: ${{ matrix.os == 'windows-latest' }} | ||
| uses: google-github-actions/auth@v2 | ||
| with: | ||
| credentials_json: ${{ secrets.GCP_SA_JSON }} | ||
|
|
||
| - uses: ./workspaces/desktop-release-action | ||
| with: | ||
| mac_csc_link: ${{ secrets.MAC_CSC_LINK }} | ||
| mac_csc_key_password: ${{ secrets.MAC_CSC_KEY_PASSWORD }} | ||
| mac_apple_id: ${{ secrets.APPLEID }} | ||
| mac_apple_id_password: ${{ secrets.APPLEIDPASS }} | ||
| mac_asc_provider: 'S6UPZG7ZR3' | ||
| win_csc_link: ${{ secrets.WIN_CSC_LINK }} | ||
| win_csc_key_password: ${{ secrets.WIN_CSC_KEY_PASSWORD }} | ||
| gcp_sa_json: ${{ secrets.GCP_SA_JSON }} | ||
| win_kms_key_resource: ${{ secrets.WIN_KMS_KEY_RESOURCE }} | ||
| win_user_crt: ${{ secrets.WIN_USER_CRT }} | ||
| win_intermediate_crt: ${{ secrets.WIN_INTERMEDIATE_CRT }} | ||
| win_root_crt: ${{ secrets.WIN_ROOT_CRT }} | ||
| github_token: ${{ secrets.GH_TOKEN }} | ||
| env: | ||
| SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAPCRAFT_STORE_CREDENTIALS }} | ||
|
Comment on lines
80
to
94
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
action_file="$(fd '^action\.ya?ml$' workspaces/desktop-release-action | head -n1)"
echo "Action metadata: ${action_file}"
echo
echo "== Action runtime / required inputs =="
rg -n -C2 'runs:|using:\s*node|snapcraft_token|required:\s*true' "$action_file"
echo
echo "== Workflow caller =="
rg -n -C2 'desktop-release-action|snapcraft_token|SNAPCRAFT_STORE_CREDENTIALS' .github/workflows/build-release.ymlRepository: RocketChat/Rocket.Chat.Electron Length of output: 2101 Update The action still declares 🧰 Tools🪛 actionlint (1.7.11)[error] 80-80: invalid runner name "node12" at runs.using in "Rocket.Chat Desktop App Release Action" action defined at "/home/jailuser/git/workspaces/desktop-release-action". valid runners are "composite", "docker", "node20", and "node24". see https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs (action) [error] 80-80: missing input "snapcraft_token" which is required by action "Rocket.Chat Desktop App Release Action" defined at "./workspaces/desktop-release-action". all required inputs are "gcp_sa_json", "github_token", "mac_apple_id", "mac_apple_id_password", "mac_asc_provider", "mac_csc_key_password", "mac_csc_link", "snapcraft_token", "win_kms_key_resource" (action) 🤖 Prompt for AI Agents
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The flagged issues in i18n files, build-release.yml, and electron-builder.json are pre-existing in the develop branch and were pulled in during merge conflict resolution. This PR only modifies src/injected.ts and src/ui/main/rootWindow.ts.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
If you'd like, I can open a separate follow-up issue to track the (¬、¬)~♪ ✏️ Learnings added
🧠 Learnings used |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| name: PowerShell Lint | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - '**.ps1' | ||
| - '**.psm1' | ||
| - '**.psd1' | ||
| - '.github/workflows/powershell-lint.yml' | ||
| push: | ||
| branches: | ||
| - master | ||
| - dev | ||
| paths: | ||
| - '**.ps1' | ||
| - '**.psm1' | ||
| - '**.psd1' | ||
| - '.github/workflows/powershell-lint.yml' | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: windows-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install PSScriptAnalyzer | ||
| shell: pwsh | ||
| run: | | ||
| Set-PSRepository PSGallery -InstallationPolicy Trusted | ||
| Install-Module -Name PSScriptAnalyzer -Force -Scope CurrentUser | ||
|
|
||
| - name: Run PSScriptAnalyzer | ||
| shell: pwsh | ||
| run: | | ||
| # Exclude Write-Host warnings as they're useful for CI output | ||
| $results = Invoke-ScriptAnalyzer -Path . -Recurse -ReportSummary -ExcludeRule PSAvoidUsingWriteHost | ||
| if ($results) { | ||
| $results | Format-Table -AutoSize | ||
| Write-Error "PSScriptAnalyzer found issues" | ||
| exit 1 | ||
| } else { | ||
| Write-Host "✅ No PowerShell issues found" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: RocketChat/Rocket.Chat.Electron
Length of output: 204
Align release CI with the repo's declared Node floor.
package.jsondeclares Node24.11.1inengines,devEngines, andvolta, but this job still installs22.17.1. The release workflow must use a supported Node version.Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents