feat(menu): register CmdOrCtrl+, accelerator for Settings on all platforms

.gitignore

@@ -48,3 +48,4 @@ scripts/msi-test/.known_hosts
 # legacy agent docs (consolidated into CLAUDE.md)
 AGENTS.md
 src/outlookCalendar/AGENTS.md
+.gitnexus

CLAUDE.md

@@ -50,6 +50,7 @@ This prevents MSI build failures from KMS CNG provider conflicts.
 
 - `*.spec.ts` — Renderer process tests
 - `*.main.spec.ts` — Main process tests
+- Renderer specs must live in a Jest-matched nested path, e.g. `src/<module>/<subdir>/*.spec.ts(x)` or `src/<module>/renderer.spec.ts(x)`. Flat `src/<module>/*.spec.ts` files are not discovered by current `testMatch`; verify new specs with `yarn test --listTests --runTestsByPath <file>`.
 - Uses `@kayahr/jest-electron-runner` for Electron environment simulation
 - Tests run on Windows, macOS, AND Linux CI — always verify cross-platform
 
@@ -103,3 +104,47 @@ git worktree add ../Rocket.Chat.Electron-worktrees/feature-name -b new-branch ma
 - Use measurable descriptions: "reduced memory usage", "improved by X%"
 - **Never invent metrics** — no estimated time spent, no speculated user counts. Only include numbers from actual logs, error messages, or documented sources.
 - PR descriptions: straightforward language, focus on what changed and why
+
+<!-- gitnexus:start -->
+# GitNexus — Code Intelligence
+
+This project is indexed by GitNexus as **Rocket.Chat.Electron** (4593 symbols, 7029 relationships, 103 execution flows). Use the GitNexus MCP tools to understand code, assess impact, and navigate safely.
+
+> If any GitNexus tool warns the index is stale, run `npx gitnexus analyze` in terminal first.
+
+## Always Do
+
+- **MUST run impact analysis before editing any symbol.** Before modifying a function, class, or method, run `gitnexus_impact({target: "symbolName", direction: "upstream"})` and report the blast radius (direct callers, affected processes, risk level) to the user.
+- **MUST run `gitnexus_detect_changes()` before committing** to verify your changes only affect expected symbols and execution flows.
+- **MUST warn the user** if impact analysis returns HIGH or CRITICAL risk before proceeding with edits.
+- When exploring unfamiliar code, use `gitnexus_query({query: "concept"})` to find execution flows instead of grepping. It returns process-grouped results ranked by relevance.
+- When you need full context on a specific symbol — callers, callees, which execution flows it participates in — use `gitnexus_context({name: "symbolName"})`.
+
+## Never Do
+
+- NEVER edit a function, class, or method without first running `gitnexus_impact` on it.
+- NEVER ignore HIGH or CRITICAL risk warnings from impact analysis.
+- NEVER rename symbols with find-and-replace — use `gitnexus_rename` which understands the call graph.
+- NEVER commit changes without running `gitnexus_detect_changes()` to check affected scope.
+
+## Resources
+
+| Resource | Use for |
+|----------|---------|
+| `gitnexus://repo/Rocket.Chat.Electron/context` | Codebase overview, check index freshness |
+| `gitnexus://repo/Rocket.Chat.Electron/clusters` | All functional areas |
+| `gitnexus://repo/Rocket.Chat.Electron/processes` | All execution flows |
+| `gitnexus://repo/Rocket.Chat.Electron/process/{name}` | Step-by-step execution trace |
+
+## CLI
+
+| Task | Read this skill file |
+|------|---------------------|
+| Understand architecture / "How does X work?" | `.claude/skills/gitnexus/gitnexus-exploring/SKILL.md` |
+| Blast radius / "What breaks if I change X?" | `.claude/skills/gitnexus/gitnexus-impact-analysis/SKILL.md` |
+| Trace bugs / "Why is X failing?" | `.claude/skills/gitnexus/gitnexus-debugging/SKILL.md` |
+| Rename / extract / split / refactor | `.claude/skills/gitnexus/gitnexus-refactoring/SKILL.md` |
+| Tools, resources, schema reference | `.claude/skills/gitnexus/gitnexus-guide/SKILL.md` |
+| Index, status, clean, wiki CLI commands | `.claude/skills/gitnexus/gitnexus-cli/SKILL.md` |
+
+<!-- gitnexus:end -->

electron-builder.json

@@ -2,10 +2,10 @@
   "files": ["app/**/*", "package.json"],
   "extraResources": ["build/icon.ico", "servers.json"],
   "appId": "chat.rocket",
-  "protocols": {
-    "name": "Rocket.Chat",
-    "schemes": ["rocketchat"]
-  },
+  "protocols": [
+    { "name": "Rocket.Chat", "schemes": ["rocketchat"] },
+    { "name": "Rocket.Chat Telephony", "schemes": ["callto", "tel"] }
+  ],
   "afterPack": "./build/afterPack.js",
   "mac": {
     "category": "public.app-category.productivity",
@@ -127,7 +127,8 @@
         "Name": "Rocket.Chat",
         "Comment": "Official Rocket.Chat Desktop Client",
         "GenericName": "Rocket.Chat",
-        "Categories": "GNOME;GTK;Network;InstantMessaging"
+        "Categories": "GNOME;GTK;Network;InstantMessaging",
+        "MimeType": "x-scheme-handler/rocketchat;x-scheme-handler/callto;x-scheme-handler/tel;"
       }
     },
     "artifactName": "rocketchat-${version}-${os}-${arch}.${ext}"

package.json

@@ -110,6 +110,9 @@
     "@rollup/plugin-json": "~6.1.0",
     "@rollup/plugin-node-resolve": "~15.2.3",
     "@rollup/plugin-replace": "~5.0.5",
+    "@testing-library/dom": "~10.4.1",
+    "@testing-library/jest-dom": "~6.9.1",
+    "@testing-library/react": "~16.3.2",
     "@types/archiver": "~7.0.0",
     "@types/dompurify": "~3.2.0",
     "@types/electron-devtools-installer": "~2.2.5",

src/app/PersistableValues.ts

@@ -2,6 +2,7 @@ import type { Certificate } from 'electron';
 
 import type { Download } from '../downloads/common';
 import type { Server } from '../servers/common';
+import type { TelephonyGlobalShortcutConfig } from '../telephony/actions';
 import type { WindowState } from '../ui/common';
 
 type PersistableValues_0_0_0 = {
@@ -106,9 +107,15 @@ type PersistableValues_4_13_0 = PersistableValues_4_11_0 & {
   isDebugLoggingEnabled: boolean;
 };
 
+type PersistableValues_4_14_0 = PersistableValues_4_13_0 & {
+  isTelephonyEnabled: boolean;
+  telephonyPreferredServer: string | null;
+  telephonyGlobalShortcutConfig: TelephonyGlobalShortcutConfig;
+};
+
 export type PersistableValues = Pick<
-  PersistableValues_4_13_0,
-  keyof PersistableValues_4_13_0
+  PersistableValues_4_14_0,
+  keyof PersistableValues_4_14_0
 >;
 
 export const migrations = {
@@ -201,4 +208,16 @@ export const migrations = {
     ...before,
     isDebugLoggingEnabled: false,
   }),
+  '>=4.14.0': (before: PersistableValues_4_13_0): PersistableValues_4_14_0 => ({
+    ...before,
+    isTelephonyEnabled:
+      (before as Partial<PersistableValues_4_14_0>).isTelephonyEnabled ?? false,
+    telephonyPreferredServer:
+      (before as Partial<PersistableValues_4_14_0>).telephonyPreferredServer ??
+      null,
+    telephonyGlobalShortcutConfig: {
+      enabled: false,
+      accelerator: null,
+    },
+  }),
 };

src/app/__tests__/PersistableValues.spec.ts

@@ -0,0 +1,18 @@
+import { migrations } from '../PersistableValues';
+
+describe('PersistableValues migrations', () => {
+  it('adds telephony shortcut config without losing a persisted telephony server', () => {
+    const before = {
+      telephonyPreferredServer: 'https://chat.example.com',
+    } as unknown as Parameters<(typeof migrations)['>=4.14.0']>[0];
+
+    expect(migrations['>=4.14.0'](before)).toEqual({
+      isTelephonyEnabled: false,
+      telephonyPreferredServer: 'https://chat.example.com',
+      telephonyGlobalShortcutConfig: {
+        enabled: false,
+        accelerator: null,
+      },
+    });
+  });
+});

src/app/main/app.main.spec.ts

@@ -470,6 +470,26 @@ describe('performElectronStartup - Platform Detection', () => {
     });
   });
 
+  describe('Telephony scheme gating', () => {
+    it('registers rocketchat at startup', () => {
+      performElectronStartup();
+
+      expect(app.setAsDefaultProtocolClient).toHaveBeenCalledWith('rocketchat');
+    });
+
+    it('does NOT register tel at startup', () => {
+      performElectronStartup();
+
+      expect(app.setAsDefaultProtocolClient).not.toHaveBeenCalledWith('tel');
+    });
+
+    it('does NOT register callto at startup', () => {
+      performElectronStartup();
+
+      expect(app.setAsDefaultProtocolClient).not.toHaveBeenCalledWith('callto');
+    });
+  });
+
   describe('Integration', () => {
     it('should work correctly with PipeWire feature enabled', () => {
       process.env.XDG_SESSION_TYPE = 'x11';

src/app/main/app.ts

@@ -40,9 +40,15 @@ export const packageJsonInformation = {
 
 export const electronBuilderJsonInformation = {
   appId: electronBuilderJson.appId,
-  protocol: electronBuilderJson.protocols.schemes[0],
+  protocol: (electronBuilderJson.protocols as Array<{ schemes: string[] }>)[0]
+    .schemes[0],
+  protocols: (
+    electronBuilderJson.protocols as Array<{ schemes: string[] }>
+  ).flatMap((p) => p.schemes),
 };
 
+export const TELEPHONY_SCHEMES = ['tel', 'callto'] as const;
+
 let isScreenCaptureFallbackForced = false;
 
 export const getPlatformName = (): string => {
@@ -83,7 +89,12 @@ export const relaunchApp = (...args: string[]): void => {
 };
 
 export const performElectronStartup = (): void => {
-  app.setAsDefaultProtocolClient(electronBuilderJsonInformation.protocol);
+  for (const scheme of electronBuilderJsonInformation.protocols) {
+    if ((TELEPHONY_SCHEMES as readonly string[]).includes(scheme)) {
+      continue;
+    }
+    app.setAsDefaultProtocolClient(scheme);
+  }
   app.setAppUserModelId(electronBuilderJsonInformation.appId);
 
   app.commandLine.appendSwitch('autoplay-policy', 'no-user-gesture-required');

src/app/selectors.ts

@@ -83,4 +83,10 @@ export const selectPersistableValues = createStructuredSelector({
   }: RootState) => isDetailedEventsLoggingEnabled,
   isDebugLoggingEnabled: ({ isDebugLoggingEnabled }: RootState) =>
     isDebugLoggingEnabled,
+  telephonyPreferredServer: ({ telephonyPreferredServer }: RootState) =>
+    telephonyPreferredServer,
+  telephonyGlobalShortcutConfig: ({
+    telephonyGlobalShortcutConfig,
+  }: RootState) => telephonyGlobalShortcutConfig,
+  isTelephonyEnabled: ({ isTelephonyEnabled }: RootState) => isTelephonyEnabled,
 });