fix: create fork in login

Author: divyanshu-patil

app/lib/methods/getAppTranslations.ts

@@ -6,49 +6,35 @@ import log from './helpers/log';
 import protectedFunction from './helpers/protectedFunction';
 import sdk from '../services/sdk';
 
-async function fetchAndSaveTranslations(language: string, db: any): Promise<void> {
-	const result = await sdk.get('apps.translations', { language });
-
-	if (!result?.success || !result.translations) {
-		return;
-	}
-
-	await db.write(async () => {
-		const collection = db.get('app_translations');
-
-		const existing = await collection.query(Q.where('language', result.language)).fetch();
-		const toDelete = existing.map((r: any) => r.prepareDestroyPermanently());
-
-		const toCreate = Object.entries(result.translations).map(([key, value]) =>
-			collection.prepareCreate(
-				protectedFunction((r: any) => {
-					r._raw = sanitizedRaw({ id: `${result.language}_${key}` }, collection.schema);
-					r.key = key;
-					r.value = value as string;
-					r.language = result.language;
-				})
-			)
-		);
-
-		await db.batch(...toDelete, ...toCreate);
-	});
-}
-
 export async function getAppTranslations(language = 'en'): Promise<void> {
 	try {
 		const db = database.active;
-		const collection = db.get('app_translations');
 
-		// check if translations already exist in DB for this language
-		const existing = await collection.query(Q.where('language', language)).fetchCount();
+		const result = await sdk.get('apps.translations', { language });
 
-		if (existing > 0) {
-			// already have translations — skip fetch
+		if (!result?.success || !result.translations) {
 			return;
 		}
 
-		// nothing in DB — fetch from server and save
-		await fetchAndSaveTranslations(language, db);
+		await db.write(async () => {
+			const collection = db.get('app_translations');
+
+			const existing = await collection.query(Q.where('language', result.language)).fetch();
+			const toDelete = existing.map((r: any) => r.prepareDestroyPermanently());
+
+			const toCreate = Object.entries(result.translations).map(([key, value]) =>
+				collection.prepareCreate(
+					protectedFunction((r: any) => {
+						r._raw = sanitizedRaw({ id: `${result.language}_${key}` }, collection.schema);
+						r.key = key;
+						r.value = value as string;
+						r.language = result.language;
+					})
+				)
+			);
+
+			await db.batch(...toDelete, ...toCreate);
+		});
 	} catch (e) {
 		log(e);
 	}

app/lib/methods/getSlashCommands.ts

@@ -5,8 +5,6 @@ import log from './helpers/log';
 import protectedFunction from './helpers/protectedFunction';
 import { type ISlashCommandResult, type TSlashCommandModel } from '../../definitions';
 import sdk from '../services/sdk';
-import { getAppTranslations } from './getAppTranslations';
-import I18n from '../../i18n';
 
 export function getSlashCommands() {
 	const db = database.active;
@@ -20,10 +18,6 @@ export function getSlashCommands() {
 				return resolve();
 			}
 
-			// fetch and save app translations if not already in DB
-			const appLang = I18n.currentLocale();
-			await getAppTranslations(appLang);
-
 			// @ts-ignore
 			const { commands } = result;
 			if (commands && commands.length) {

app/sagas/login.js

@@ -39,6 +39,7 @@ import appNavigation from '../lib/navigation/appNavigation';
 import { showActionSheetRef } from '../containers/ActionSheet';
 import { SupportedVersionsWarning } from '../containers/SupportedVersions';
 import { isIOS } from '../lib/methods/helpers';
+import { getAppTranslations } from '../lib/methods/getAppTranslations';
 
 const getServer = state => state.server.server;
 const loginWithPasswordCall = args => loginWithPassword(args);
@@ -184,6 +185,15 @@ const fetchSlashCommandsFork = function* fetchSlashCommandsFork() {
 	}
 };
 
+const fetchAppTranslationsFork = function* fetchAppTranslationsFork() {
+	try {
+		const appLang = I18n.currentLocale().split('-')[0];
+		yield getAppTranslations(appLang);
+	} catch (e) {
+		log(e);
+	}
+};
+
 const registerPushTokenFork = function* registerPushTokenFork() {
 	try {
 		yield registerPushToken();
@@ -251,6 +261,7 @@ const handleLoginSuccess = function* handleLoginSuccess({ user }) {
 		yield fork(fetchCustomEmojisFork);
 		yield fork(fetchRolesFork);
 		yield fork(fetchSlashCommandsFork);
+		yield fork(fetchAppTranslationsFork);
 		yield fork(registerPushTokenFork);
 		yield fork(fetchUsersPresenceFork);
 		yield fork(fetchEnterpriseModulesFork, { user });