coderabbit suggestions

Author: Rohit3523

app/containers/MessageComposer/MessageComposer.test.tsx

@@ -3,6 +3,7 @@ import { render, screen, fireEvent, waitFor, userEvent } from '@testing-library/
 import { Provider } from 'react-redux';
 
 import { MessageComposerContainer } from './MessageComposerContainer';
+import { calculateLength, getSeparator } from './components/ComposerInput';
 import { setPermissions } from '../../actions/permissions';
 import { addSettings } from '../../actions/settings';
 import { selectServerRequest } from '../../actions/server';
@@ -860,3 +861,100 @@ describe('MessageComposer', () => {
 		});
 	});
 });
+
+describe('calculateLength', () => {
+    describe('non-code-block (inline markdown)', () => {
+        test('empty text - no separator needed', () => {
+            const result = calculateLength('', '*', false, '');
+            expect(result).toBe(1);
+        });
+
+        test('text without trailing space, no selection - separator is empty, cursor between delimiters', () => {
+            const separator = getSeparator('hello', false, false);
+            expect(separator).toBe('');
+            const result = calculateLength('hello', '*', false, separator);
+            expect(result).toBe(1);
+        });
+
+        test('text with trailing space, no selection - separator is empty', () => {
+            const separator = getSeparator('hello ', false, false);
+            expect(separator).toBe('');
+            const result = calculateLength('hello ', '*', false, separator);
+            expect(result).toBe(1);
+        });
+
+        test('text without trailing space, with selection - separator is space', () => {
+            const separator = getSeparator('hello', false, true);
+            expect(separator).toBe(' ');
+            const result = calculateLength('hello', '*', false, separator);
+            expect(result).toBe(2);
+        });
+
+        test('text with trailing space, with selection - separator is empty', () => {
+            const separator = getSeparator('hello ', false, true);
+            expect(separator).toBe('');
+            const result = calculateLength('hello ', '*', false, separator);
+            expect(result).toBe(1);
+        });
+    });
+
+    describe('code-block', () => {
+        test('empty text - no separator needed', () => {
+            const result = calculateLength('', '```', true, '');
+            expect(result).toBe(4);
+        });
+
+        test('text without trailing backticks - separator is newline', () => {
+            const separator = getSeparator('some code', true, false);
+            expect(separator).toBe('\n');
+            const result = calculateLength('some code', '```', true, separator);
+            expect(result).toBe(5);
+        });
+
+        test('text ending with backticks - separator is empty', () => {
+            const separator = getSeparator('code ```', true, false);
+            expect(separator).toBe('');
+            const result = calculateLength('code ```', '```', true, separator);
+            expect(result).toBe(4);
+        });
+    });
+});
+
+describe('getSeparator', () => {
+    describe('non-code-block', () => {
+        test('empty text returns empty string', () => {
+            expect(getSeparator('', false, false)).toBe('');
+            expect(getSeparator('', false, true)).toBe('');
+        });
+
+        test('no selection returns empty string', () => {
+            expect(getSeparator('hello', false, false)).toBe('');
+        });
+
+        test('with selection, no trailing space returns space', () => {
+            expect(getSeparator('hello', false, true)).toBe(' ');
+        });
+
+        test('with selection, trailing space returns empty string', () => {
+            expect(getSeparator('hello ', false, true)).toBe('');
+        });
+    });
+
+    describe('code-block', () => {
+        test('empty text returns empty string', () => {
+            expect(getSeparator('', true, false)).toBe('');
+        });
+
+        test('text not ending with backticks returns newline', () => {
+            expect(getSeparator('some code', true, false)).toBe('\n');
+        });
+
+        test('text ending with ``` returns empty string', () => {
+            expect(getSeparator('code ```', true, false)).toBe('');
+        });
+
+        test('text ending with ``` and spaces returns empty string', () => {
+            expect(getSeparator('code ```   ', true, false)).toBe('');
+        });
+    });
+});

app/containers/MessageComposer/components/ComposerInput.tsx

@@ -45,7 +45,7 @@ import useIOSBackSwipeHandler from '../hooks/useIOSBackSwipeHandler';
 
 const defaultSelection: IInputSelection = { start: 0, end: 0 };
 
-function calculateLength(startingText: string, markdown: string, isCodeBlock: boolean, separator: string) {
+export function calculateLength(startingText: string, markdown: string, isCodeBlock: boolean, separator: string) {
 	if (isCodeBlock) {
 		if (startingText.length > 0) {
 			return markdown.length + separator.length + 1;
@@ -54,12 +54,10 @@ function calculateLength(startingText: string, markdown: string, isCodeBlock: bo
 		return markdown.length + 1;
 	}
 
-	const endWithSpace = startingText.endsWith(' ');
-
-	return markdown.length + (startingText.length > 0 ? 1 : 0) + (endWithSpace ? -1 : 0);
+	return separator.length + markdown.length;
 }
 
-function getSeparator(startingText: string, isCodeBlock: boolean, hasSelection: boolean) {
+export function getSeparator(startingText: string, isCodeBlock: boolean, hasSelection: boolean) {
 	if (startingText.length === 0) {
 		return '';
 	}