Skip to content

Commit 9c8a9ee

Browse files
committed
test: drop local plan-ID labels from deep linking saga tests
1 parent 9d04580 commit 9c8a9ee

1 file changed

Lines changed: 13 additions & 13 deletions

File tree

app/sagas/__tests__/deepLinking.test.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ const makeParams = (overrides: Record<string, any> = {}) => ({
126126
...overrides
127127
});
128128

129-
/** Params for the unknown-server-with-token path (F4 tests). */
129+
/** Params for the unknown-server-with-token path. */
130130
const makeParamsWithToken = (overrides: Record<string, any> = {}) =>
131131
makeParams({ token: TOKEN, path: 'channel/general', ...overrides });
132132

@@ -140,9 +140,9 @@ const makeServerRecord = (overrides: Record<string, any> = {}) => ({
140140
/** Stored user token stub as returned by UserPreferences.getString(TOKEN_KEY-host). */
141141
const makeStoredUser = () => TOKEN;
142142

143-
// ─── Group F4 — Regression race (new server + token + room path) ──────────────
143+
// ─── Regression race (new server + token + room path) ──────────────
144144

145-
describe('deepLinking saga — F4 regression race (new server + token + room path)', () => {
145+
describe('deepLinking saga — Regression race (new server + token + room path)', () => {
146146
beforeEach(() => {
147147
jest.useFakeTimers();
148148

@@ -181,11 +181,11 @@ describe('deepLinking saga — F4 regression race (new server + token + room pat
181181
});
182182

183183
/**
184-
* F4a — Regression positive: full chain, dispatch SERVER.SELECT_SUCCESS,
184+
* Regression positive: full chain, dispatch SERVER.SELECT_SUCCESS,
185185
* LOGIN.SUCCESS, then APP.START(ROOT_INSIDE). Assert goRoom called exactly
186186
* once, sequenced after the APP.START dispatch.
187187
*/
188-
it('F4a: calls goRoom exactly once after APP.START(ROOT_INSIDE) completes the chain', async () => {
188+
it('calls goRoom exactly once after APP.START(ROOT_INSIDE) completes the chain', async () => {
189189
const store = setupStore();
190190
const params = makeParamsWithToken();
191191

@@ -222,11 +222,11 @@ describe('deepLinking saga — F4 regression race (new server + token + room pat
222222
});
223223

224224
/**
225-
* F4b — Regression negative: dispatch SERVER.SELECT_SUCCESS, LOGIN.SUCCESS.
225+
* Regression negative: dispatch SERVER.SELECT_SUCCESS, LOGIN.SUCCESS.
226226
* Flush microtasks. Assert goRoom NOT yet called.
227227
* Then dispatch APP.START(ROOT_INSIDE). Flush. Assert goRoom called once.
228228
*/
229-
it('F4b: goRoom is NOT called between LOGIN.SUCCESS and APP.START(ROOT_INSIDE)', async () => {
229+
it('goRoom is NOT called between LOGIN.SUCCESS and APP.START(ROOT_INSIDE)', async () => {
230230
const store = setupStore();
231231
const params = makeParamsWithToken();
232232

@@ -253,12 +253,12 @@ describe('deepLinking saga — F4 regression race (new server + token + room pat
253253
});
254254

255255
/**
256-
* F4c — Early-exit branch: the saga selects state.app.root after LOGIN.SUCCESS.
256+
* Early-exit branch: the saga selects state.app.root after LOGIN.SUCCESS.
257257
* If root === ROOT_INSIDE at that moment, the take is skipped and goRoom fires
258258
* immediately. We achieve this by dispatching APP.START(ROOT_INSIDE) synchronously
259259
* before flushing, so the reducer updates the root before the saga's select runs.
260260
*/
261-
it('F4c: skips the APP.START take when state.app.root is already ROOT_INSIDE at select time', async () => {
261+
it('skips the APP.START take when state.app.root is already ROOT_INSIDE at select time', async () => {
262262
const store = setupStore();
263263
const params = makeParamsWithToken();
264264

@@ -283,11 +283,11 @@ describe('deepLinking saga — F4 regression race (new server + token + room pat
283283
});
284284

285285
/**
286-
* F4d — Wrong-root rejection: dispatch APP.START(ROOT_OUTSIDE) — wrong root.
286+
* Wrong-root rejection: dispatch APP.START(ROOT_OUTSIDE) — wrong root.
287287
* Assert goRoom NOT called. Then dispatch APP.START(ROOT_INSIDE). Assert goRoom
288288
* called once.
289289
*/
290-
it('F4d: APP.START(ROOT_OUTSIDE) does not satisfy the take; APP.START(ROOT_INSIDE) does', async () => {
290+
it('APP.START(ROOT_OUTSIDE) does not satisfy the take; APP.START(ROOT_INSIDE) does', async () => {
291291
const store = setupStore();
292292
const params = makeParamsWithToken();
293293

@@ -318,11 +318,11 @@ describe('deepLinking saga — F4 regression race (new server + token + room pat
318318
});
319319

320320
/**
321-
* F4e — Multiple APP.START: after the take fires once, dispatch a second
321+
* Multiple APP.START: after the take fires once, dispatch a second
322322
* APP.START(ROOT_INSIDE). Assert goRoom still called only once (saga is past
323323
* the take, takeLatest has not been retriggered).
324324
*/
325-
it('F4e: a second APP.START(ROOT_INSIDE) after navigation does not re-trigger goRoom', async () => {
325+
it('a second APP.START(ROOT_INSIDE) after navigation does not re-trigger goRoom', async () => {
326326
const store = setupStore();
327327
const params = makeParamsWithToken();
328328

0 commit comments

Comments
 (0)