chore(voip): address CodeRabbit ESLint and test feedback

- Replace void operator with promise catch handlers (no-void)
- Use prefer-destructuring for contact.username in MediaSessionInstance
- Fix import order in MediaSessionInstance.test.ts
- Add getDMSubscriptionByUsername falsy-username test with mockClear
- Document getDMSubscriptionByUsername with JSDoc

Made-with: Cursor

Author: diegolmello

app/containers/MediaCallHeader/components/Content.tsx

@@ -28,7 +28,9 @@ export const Content = () => {
 		<Pressable
 			testID='media-call-header-content'
 			disabled={contentDisabled}
-			onPress={() => void navigateToCallRoom()}
+			onPress={() => {
+				navigateToCallRoom().catch(() => undefined);
+			}}
 			style={pressableStyle}>
 			<View style={styles.container}>
 				<Title />

app/lib/database/services/Subscription.test.ts

@@ -41,4 +41,13 @@ describe('getDMSubscriptionByUsername', () => {
 
 		expect(result).toBeNull();
 	});
+
+	it('returns null when username is empty and does not query the database', async () => {
+		mockGet.mockClear();
+
+		const result = await getDMSubscriptionByUsername('');
+
+		expect(result).toBeNull();
+		expect(mockGet).not.toHaveBeenCalled();
+	});
 });

app/lib/database/services/Subscription.ts

@@ -7,6 +7,10 @@ import { SUBSCRIPTIONS_TABLE } from '../model/Subscription';
 
 const getCollection = (db: TAppDatabase) => db.get(SUBSCRIPTIONS_TABLE);
 
+/**
+ * Returns the WatermelonDB direct-message subscription for a username (`name` + type `d`), or null.
+ * Skips the query when `username` is falsy.
+ */
 export const getDMSubscriptionByUsername = async (username: string): Promise<TSubscriptionModel | null> => {
 	if (!username) {
 		return null;

app/lib/services/voip/MediaSessionInstance.ts

@@ -95,7 +95,9 @@ class MediaSessionInstance {
 					useCallStore.getState().setCall(call);
 					Navigation.navigate('CallView');
 					if (useCallStore.getState().roomId == null) {
-						void this.resolveRoomIdFromContact(call.contact);
+						this.resolveRoomIdFromContact(call.contact).catch(error => {
+							console.error('[VoIP] Error resolving room id from contact (newCall):', error);
+						});
 					}
 				}
 
@@ -124,7 +126,9 @@ class MediaSessionInstance {
 			RNCallKeep.setCurrentCallActive(callId);
 			useCallStore.getState().setCall(mainCall);
 			Navigation.navigate('CallView');
-			void this.resolveRoomIdFromContact(mainCall.contact);
+			this.resolveRoomIdFromContact(mainCall.contact).catch(error => {
+				console.error('[VoIP] Error resolving room id from contact (answerCall):', error);
+			});
 		} else {
 			RNCallKeep.endCall(callId);
 			const st = useCallStore.getState();
@@ -170,7 +174,7 @@ class MediaSessionInstance {
 		if (contact.sipExtension) {
 			return;
 		}
-		const username = contact.username;
+		const { username } = contact;
 		if (!username) {
 			return;
 		}

app/views/CallView/components/CallButtons.tsx

@@ -39,7 +39,7 @@ export const CallButtons = () => {
 	const messageDisabled = Boolean(contact.sipExtension) || roomId == null;
 
 	const handleMessage = () => {
-		void navigateToCallRoom();
+		navigateToCallRoom().catch(() => undefined);
 	};
 
 	const handleDialpad = () => {