Skip to content

fix: message fail to deliver in non e2e channel #7067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Rohit3523 wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

fix: message fail to deliver in non e2e channel #7067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/lib/encryption/encryption.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ class Encryption {

const roomE2E = await this.getRoomInstance(rid);
if (!roomE2E || !roomE2E?.hasSessionKey()) {
return;
return message;
Copy link
Copy Markdown
Member

@diegolmello diegolmello Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have tests for this besides e2e ones, but we need to test this very carefully not to introduce regressions.
There's probably a reason that return is empty.

}
return roomE2E.encrypt(message);
} catch {
Expand Down
Loading