Skip to content

feat(voip): navigate to call DM from message button and header #7082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 15 commits into from
Apr 6, 2026
Merged

feat(voip): navigate to call DM from message button and header #7082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
318ba42
feat(voip): add roomId to call store
diegolmello Mar 31, 2026
23464be
feat(database): add getDMSubscriptionByUsername
diegolmello Mar 31, 2026
9f7bf55
feat(voip): populate call store roomId on call start
diegolmello Mar 31, 2026
11e1a01
feat(voip): add navigateToCallRoom helper
diegolmello Mar 31, 2026
7c38958
feat(call): wire Message button to navigateToCallRoom
diegolmello Mar 31, 2026
82102c2
feat(voip): open DM from MediaCallHeader content tap
diegolmello Mar 31, 2026
8ee2bd5
fix(voip): navigate to ChatsStackNavigator when calling from other dr…
diegolmello Mar 31, 2026
b94aa0a
chore(voip): address CodeRabbit ESLint and test feedback
diegolmello Apr 2, 2026
d76fa82
chore: format code and fix lint issues
diegolmello Apr 2, 2026
c949207
chore(test): centralize react-native-incall-manager mock in jest.setup
diegolmello Apr 2, 2026
cdab848
test(voip): fix CallStore mock assertions for ESLint
diegolmello Apr 2, 2026
82d63a3
test(voip): harden navigateToCallRoom tests for guards and call order
diegolmello Apr 2, 2026
2b3b50e
chore: format code and fix lint issues
diegolmello Apr 6, 2026
bb226f5
chore(test): regenerate MediaCallHeader snapshots after rebase
diegolmello Apr 6, 2026
ee17044
fix(test): correct TS errors in useCallStore and MediaSessionInstance…
diegolmello Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/containers/MediaCallHeader/MediaCallHeader.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const setStoreState = (overrides: Partial<ReturnType<typeof useCallStore.getStat
contact: {
displayName: 'Bob Burnquist',
username: 'bob.burnquist',
sipExtension: '2244'
sipExtension: ''
},
setMuted: () => {},
setHeld: () => {},
Expand All @@ -44,8 +44,9 @@ const setStoreState = (overrides: Partial<ReturnType<typeof useCallStore.getStat
id: 'user-1',
displayName: 'Bob Burnquist',
username: 'bob.burnquist',
sipExtension: '2244'
sipExtension: ''
},
roomId: 'story-room-rid',
focused: true,
remoteMute: false,
remoteHeld: false,
Expand Down
49 changes: 43 additions & 6 deletions app/containers/MediaCallHeader/MediaCallHeader.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,17 @@ import { fireEvent, render } from '@testing-library/react-native';
import { Provider } from 'react-redux';

import MediaCallHeader from './MediaCallHeader';
import { navigateToCallRoom } from '../../lib/services/voip/navigateToCallRoom';
import { useCallStore } from '../../lib/services/voip/useCallStore';
import { mockedStore } from '../../reducers/mockedStore';
import * as stories from './MediaCallHeader.stories';
import { generateSnapshots } from '../../../.rnstorybook/generateSnapshots';

// Mock alert
global.alert = jest.fn();
const mockNavigateToCallRoom = jest.mocked(navigateToCallRoom);

jest.mock('../../lib/services/voip/navigateToCallRoom', () => ({
navigateToCallRoom: jest.fn().mockResolvedValue(undefined)
}));

const mockCallStartTime = 1713340800000;

Expand All @@ -21,7 +25,7 @@ const createMockCall = (overrides: Record<string, unknown> = {}) => ({
contact: {
displayName: 'Bob Burnquist',
username: 'bob.burnquist',
sipExtension: '2244'
sipExtension: ''
},
setMuted: jest.fn(),
setHeld: jest.fn(),
Expand All @@ -48,8 +52,9 @@ const setStoreState = (overrides: Partial<ReturnType<typeof useCallStore.getStat
id: 'user-1',
displayName: 'Bob Burnquist',
username: 'bob.burnquist',
sipExtension: '2244'
sipExtension: ''
},
roomId: 'test-room-rid',
focused: true,
remoteMute: false,
remoteHeld: false,
Expand Down Expand Up @@ -209,7 +214,7 @@ describe('MediaCallHeader', () => {
expect(getByTestId('media-call-header')).toHaveProp('pointerEvents', 'auto');
});

it('should show alert when content is pressed', () => {
it('should call navigateToCallRoom when content is pressed and navigation is enabled', () => {
setStoreState();
const { getByTestId } = render(
<Wrapper>
Expand All @@ -218,7 +223,39 @@ describe('MediaCallHeader', () => {
);

fireEvent.press(getByTestId('media-call-header-content'));
expect(global.alert).toHaveBeenCalledWith('nav to call room');
expect(mockNavigateToCallRoom).toHaveBeenCalledTimes(1);
});

it('does not call navigateToCallRoom when content is pressed for SIP calls', () => {
setStoreState({
contact: {
id: 'user-1',
displayName: 'Bob Burnquist',
username: 'bob.burnquist',
sipExtension: '2244'
},
roomId: 'test-room-rid'
});
const { getByTestId } = render(
<Wrapper>
<MediaCallHeader />
</Wrapper>
);

fireEvent.press(getByTestId('media-call-header-content'));
expect(mockNavigateToCallRoom).not.toHaveBeenCalled();
});

it('does not call navigateToCallRoom when roomId is null', () => {
setStoreState({ roomId: null });
const { getByTestId } = render(
<Wrapper>
<MediaCallHeader />
</Wrapper>
);

fireEvent.press(getByTestId('media-call-header-content'));
expect(mockNavigateToCallRoom).not.toHaveBeenCalled();
});
});

Expand Down
103 changes: 20 additions & 83 deletions app/containers/MediaCallHeader/__snapshots__/MediaCallHeader.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ exports[`Story Snapshots: ActiveCall should match snapshot 1`] = `
collapsable={false}
delayLongPress={600}
enabled={true}
handlerTag={19}
handlerTag={23}
handlerType="NativeViewGestureHandler"
hitSlop={
{
Expand Down Expand Up @@ -132,7 +132,7 @@ exports[`Story Snapshots: ActiveCall should match snapshot 1`] = `
{
"busy": undefined,
"checked": undefined,
"disabled": undefined,
"disabled": false,
"expanded": undefined,
"selected": undefined,
}
Expand Down Expand Up @@ -244,27 +244,6 @@ exports[`Story Snapshots: ActiveCall should match snapshot 1`] = `
</Text>
</Text>
</View>
<Text
numberOfLines={1}
style={
[
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontSize": 12,
"fontWeight": "400",
"lineHeight": 16,
"textAlign": "left",
},
{
"color": "#6C727A",
},
]
}
testID="call-view-header-subtitle"
>
2244
</Text>
</View>
</View>
<View
Expand All @@ -288,7 +267,7 @@ exports[`Story Snapshots: ActiveCall should match snapshot 1`] = `
collapsable={false}
delayLongPress={600}
enabled={true}
handlerTag={20}
handlerTag={24}
handlerType="NativeViewGestureHandler"
hitSlop={
{
Expand Down Expand Up @@ -419,7 +398,7 @@ exports[`Story Snapshots: Collapsed should match snapshot 1`] = `
collapsable={false}
delayLongPress={600}
enabled={true}
handlerTag={21}
handlerTag={25}
handlerType="NativeViewGestureHandler"
hitSlop={
{
Expand Down Expand Up @@ -490,7 +469,7 @@ exports[`Story Snapshots: Collapsed should match snapshot 1`] = `
{
"busy": undefined,
"checked": undefined,
"disabled": undefined,
"disabled": false,
"expanded": undefined,
"selected": undefined,
}
Expand Down Expand Up @@ -602,27 +581,6 @@ exports[`Story Snapshots: Collapsed should match snapshot 1`] = `
</Text>
</Text>
</View>
<Text
numberOfLines={1}
style={
[
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontSize": 12,
"fontWeight": "400",
"lineHeight": 16,
"textAlign": "left",
},
{
"color": "#6C727A",
},
]
}
testID="call-view-header-subtitle"
>
2244
</Text>
</View>
</View>
<View
Expand All @@ -646,7 +604,7 @@ exports[`Story Snapshots: Collapsed should match snapshot 1`] = `
collapsable={false}
delayLongPress={600}
enabled={true}
handlerTag={22}
handlerTag={26}
handlerType="NativeViewGestureHandler"
hitSlop={
{
Expand Down Expand Up @@ -777,7 +735,7 @@ exports[`Story Snapshots: ConnectingCall should match snapshot 1`] = `
collapsable={false}
delayLongPress={600}
enabled={true}
handlerTag={23}
handlerTag={27}
handlerType="NativeViewGestureHandler"
hitSlop={
{
Expand Down Expand Up @@ -848,7 +806,7 @@ exports[`Story Snapshots: ConnectingCall should match snapshot 1`] = `
{
"busy": undefined,
"checked": undefined,
"disabled": undefined,
"disabled": false,
"expanded": undefined,
"selected": undefined,
}
Expand Down Expand Up @@ -1000,7 +958,7 @@ exports[`Story Snapshots: ConnectingCall should match snapshot 1`] = `
collapsable={false}
delayLongPress={600}
enabled={true}
handlerTag={24}
handlerTag={28}
handlerType="NativeViewGestureHandler"
hitSlop={
{
Expand Down Expand Up @@ -1131,7 +1089,7 @@ exports[`Story Snapshots: Focused should match snapshot 1`] = `
collapsable={false}
delayLongPress={600}
enabled={true}
handlerTag={25}
handlerTag={29}
handlerType="NativeViewGestureHandler"
hitSlop={
{
Expand Down Expand Up @@ -1202,7 +1160,7 @@ exports[`Story Snapshots: Focused should match snapshot 1`] = `
{
"busy": undefined,
"checked": undefined,
"disabled": undefined,
"disabled": false,
"expanded": undefined,
"selected": undefined,
}
Expand Down Expand Up @@ -1314,27 +1272,6 @@ exports[`Story Snapshots: Focused should match snapshot 1`] = `
</Text>
</Text>
</View>
<Text
numberOfLines={1}
style={
[
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontSize": 12,
"fontWeight": "400",
"lineHeight": 16,
"textAlign": "left",
},
{
"color": "#6C727A",
},
]
}
testID="call-view-header-subtitle"
>
2244
</Text>
</View>
</View>
<View
Expand All @@ -1358,7 +1295,7 @@ exports[`Story Snapshots: Focused should match snapshot 1`] = `
collapsable={false}
delayLongPress={600}
enabled={true}
handlerTag={26}
handlerTag={30}
handlerType="NativeViewGestureHandler"
hitSlop={
{
Expand Down Expand Up @@ -1509,7 +1446,7 @@ exports[`Story Snapshots: WithRemoteHeld should match snapshot 1`] = `
collapsable={false}
delayLongPress={600}
enabled={true}
handlerTag={27}
handlerTag={31}
handlerType="NativeViewGestureHandler"
hitSlop={
{
Expand Down Expand Up @@ -1580,7 +1517,7 @@ exports[`Story Snapshots: WithRemoteHeld should match snapshot 1`] = `
{
"busy": undefined,
"checked": undefined,
"disabled": undefined,
"disabled": false,
"expanded": undefined,
"selected": undefined,
}
Expand Down Expand Up @@ -1711,7 +1648,7 @@ exports[`Story Snapshots: WithRemoteHeld should match snapshot 1`] = `
}
testID="call-view-header-subtitle"
>
2244 - On hold
On hold
</Text>
</View>
</View>
Expand All @@ -1736,7 +1673,7 @@ exports[`Story Snapshots: WithRemoteHeld should match snapshot 1`] = `
collapsable={false}
delayLongPress={600}
enabled={true}
handlerTag={28}
handlerTag={32}
handlerType="NativeViewGestureHandler"
hitSlop={
{
Expand Down Expand Up @@ -1867,7 +1804,7 @@ exports[`Story Snapshots: WithRemoteMuted should match snapshot 1`] = `
collapsable={false}
delayLongPress={600}
enabled={true}
handlerTag={29}
handlerTag={33}
handlerType="NativeViewGestureHandler"
hitSlop={
{
Expand Down Expand Up @@ -1938,7 +1875,7 @@ exports[`Story Snapshots: WithRemoteMuted should match snapshot 1`] = `
{
"busy": undefined,
"checked": undefined,
"disabled": undefined,
"disabled": false,
"expanded": undefined,
"selected": undefined,
}
Expand Down Expand Up @@ -2069,7 +2006,7 @@ exports[`Story Snapshots: WithRemoteMuted should match snapshot 1`] = `
}
testID="call-view-header-subtitle"
>
2244 - Muted
Muted
</Text>
</View>
</View>
Expand All @@ -2094,7 +2031,7 @@ exports[`Story Snapshots: WithRemoteMuted should match snapshot 1`] = `
collapsable={false}
delayLongPress={600}
enabled={true}
handlerTag={30}
handlerTag={34}
handlerType="NativeViewGestureHandler"
hitSlop={
{
Expand Down
Loading
Loading