chore: Add .claude, .worktrees, .omc to .gitignore#7132
chore: Add .claude, .worktrees, .omc to .gitignore#7132diegolmello wants to merge 1 commit intodevelopfrom
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
.gitignore (2)
87-89: Consider making these patterns root-level specific.The patterns
.claude/,.worktrees/, and.omc/currently match directories at any level in the repository tree. Since these appear to be development tool/config directories that typically only exist at the repository root, consider prefixing them with/for precision:-*.p8 -.claude/ -.worktrees/ -.omc/ +*.p8 +/.claude/ +/.worktrees/ +/.omc/This prevents unintended matches in subdirectories and makes the ignore patterns more explicit.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.gitignore around lines 87 - 89, Update the three gitignore patterns to be root-level by prefixing each with a slash so they only match top-level dirs: change `.claude/`, `.worktrees/`, and `.omc/` to `/.claude/`, `/.worktrees/`, and `/.omc/` respectively (keep the trailing slashes).
89-89: Add a trailing newline at end of file.The file should end with a newline character per POSIX text file convention. This prevents git diff warnings and ensures compatibility with text processing tools.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.gitignore at line 89, The .gitignore currently ends with the entry ".omc/" but lacks a trailing newline; update the file by adding a single newline character at the end of file (after the ".omc/" line) so the file ends with a proper POSIX newline to avoid git diff warnings and tooling issues.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.gitignore:
- Around line 87-89: Update the three gitignore patterns to be root-level by
prefixing each with a slash so they only match top-level dirs: change
`.claude/`, `.worktrees/`, and `.omc/` to `/.claude/`, `/.worktrees/`, and
`/.omc/` respectively (keep the trailing slashes).
- Line 89: The .gitignore currently ends with the entry ".omc/" but lacks a
trailing newline; update the file by adding a single newline character at the
end of file (after the ".omc/" line) so the file ends with a proper POSIX
newline to avoid git diff warnings and tooling issues.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6b61f02a-4185-4ad0-ab4c-e8e33eb68c7c
📒 Files selected for processing (1)
.gitignore
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: ESLint and Test / run-eslint-and-test
- GitHub Check: format
🔇 Additional comments (1)
.gitignore (1)
88-88: Clarify or remove the undocumented.worktrees/pattern.The
.worktrees/entry has no corresponding documentation or usage in the repository. While developers can intentionally create a.worktrees/directory as a local convention for organizing git worktrees, this pattern is neither standard nor explained. Either add documentation explaining this team convention or remove the entry if it was added unintentionally.
Proposed changes
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit