Skip to content

chore: Add .claude, .worktrees, .omc to .gitignore#7132

Open
diegolmello wants to merge 1 commit intodevelopfrom
chore.ignore
Open

chore: Add .claude, .worktrees, .omc to .gitignore#7132
diegolmello wants to merge 1 commit intodevelopfrom
chore.ignore

Conversation

@diegolmello
Copy link
Copy Markdown
Member

@diegolmello diegolmello commented Apr 12, 2026

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Chores
    • Updated repository configuration to ignore additional build and development artifacts.

@diegolmello diegolmello requested a deployment to approve_e2e_testing April 12, 2026 18:27 — with GitHub Actions Waiting
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 12, 2026

Walkthrough

The .gitignore file is updated to exclude three additional directories: .claude/, .worktrees/, and .omc/. No other ignore patterns are modified, and the change only appends new lines to the file.

Changes

Cohort / File(s) Summary
Gitignore Configuration
.gitignore
Added ignore patterns for .claude/, .worktrees/, and .omc/ directories. Existing *.p8 pattern retained; trailing newline remains absent.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: adding three directories to .gitignore.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
.gitignore (2)

87-89: Consider making these patterns root-level specific.

The patterns .claude/, .worktrees/, and .omc/ currently match directories at any level in the repository tree. Since these appear to be development tool/config directories that typically only exist at the repository root, consider prefixing them with / for precision:

-*.p8
-.claude/
-.worktrees/
-.omc/
+*.p8
+/.claude/
+/.worktrees/
+/.omc/

This prevents unintended matches in subdirectories and makes the ignore patterns more explicit.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.gitignore around lines 87 - 89, Update the three gitignore patterns to be
root-level by prefixing each with a slash so they only match top-level dirs:
change `.claude/`, `.worktrees/`, and `.omc/` to `/.claude/`, `/.worktrees/`,
and `/.omc/` respectively (keep the trailing slashes).

89-89: Add a trailing newline at end of file.

The file should end with a newline character per POSIX text file convention. This prevents git diff warnings and ensures compatibility with text processing tools.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.gitignore at line 89, The .gitignore currently ends with the entry ".omc/"
but lacks a trailing newline; update the file by adding a single newline
character at the end of file (after the ".omc/" line) so the file ends with a
proper POSIX newline to avoid git diff warnings and tooling issues.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.gitignore:
- Around line 87-89: Update the three gitignore patterns to be root-level by
prefixing each with a slash so they only match top-level dirs: change
`.claude/`, `.worktrees/`, and `.omc/` to `/.claude/`, `/.worktrees/`, and
`/.omc/` respectively (keep the trailing slashes).
- Line 89: The .gitignore currently ends with the entry ".omc/" but lacks a
trailing newline; update the file by adding a single newline character at the
end of file (after the ".omc/" line) so the file ends with a proper POSIX
newline to avoid git diff warnings and tooling issues.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6b61f02a-4185-4ad0-ab4c-e8e33eb68c7c

📥 Commits

Reviewing files that changed from the base of the PR and between 7d163d3 and 01949d3.

📒 Files selected for processing (1)
  • .gitignore
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: ESLint and Test / run-eslint-and-test
  • GitHub Check: format
🔇 Additional comments (1)
.gitignore (1)

88-88: Clarify or remove the undocumented .worktrees/ pattern.

The .worktrees/ entry has no corresponding documentation or usage in the repository. While developers can intentionally create a .worktrees/ directory as a local convention for organizing git worktrees, this pattern is neither standard nor explained. Either add documentation explaining this team convention or remove the entry if it was added unintentionally.

@diegolmello diegolmello requested a deployment to experimental_android_build April 12, 2026 18:30 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to official_android_build April 12, 2026 18:30 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to experimental_ios_build April 12, 2026 18:30 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant