Skip to content

chore: Merge 4.73.1 into master#7370

Merged
diegolmello merged 40 commits into
masterfrom
4.73.1
Jun 9, 2026
Merged

chore: Merge 4.73.1 into master#7370
diegolmello merged 40 commits into
masterfrom
4.73.1

Conversation

@diegolmello

@diegolmello diegolmello commented Jun 1, 2026

Copy link
Copy Markdown
Member

Proposed changes

Merge the 4.73.1 patch release into master. The version was bumped across package.json, android/app/build.gradle, iOS Info.plist (app + share extension), and MARKETING_VERSION in the Xcode project (RocketChatRN + NotificationService), and the release has already shipped to the App Store and Play Store.

As a patch, 4.73.1 does not flow through develop. A companion PR (#7391) merges the same release into single-server.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1215

How to test or reproduce

  • cat package.json | grep version -> 4.73.1
  • grep versionName android/app/build.gradle -> 4.73.1
  • grep CFBundleShortVersionString -A1 ios/RocketChatRN/Info.plist ios/ShareRocketChatRN/Info.plist -> 4.73.1
  • grep MARKETING_VERSION ios/RocketChatRN.xcodeproj/project.pbxproj -> two 4.73.1 entries (RocketChatRN, NotificationService)

Screenshots

N/A

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Chores
    • Updated app and package version to 4.73.1 across Android, iOS, and project metadata.

diegolmello and others added 30 commits May 11, 2026 14:18
* fix: emoji picker scroll does not reach the end

* feat: add test to pick the last emoji in emoji picker

* fix: e2e test

* fix: tests

* tests

* remove unused pod

* rename emoji category

* fix: new test flow

* rollback space
* feat: alt text

* action: organized translations

* fix: move alt text accessibility to button level and fix gallery height

* chore: format code and fix lint issues

* ix: stable gallery keys and forward alt text accessibility to gallery items

* fix: i18n fallbacks, alt text a11y label, stale altText on remove, and 8.4.0 boundary test

* action: organized translations

* fix: i18n

* action: organized translations

* fix: preserve caption on send, correct version gate for share extension, and translated a11y labels in gallery

* fix: alt text label

* feat: queue composer attachments inline

* feat: open attachment alt text in action sheet

* fix: remove image gallery

* action: organized translations

* feat: edit message alt text

* chore: format code and fix lint issues

* feat: backward compatibilities

* fix: edit

* remove image gallery

* fix: conflicts

* code improvements

* fix: composer

* code improvements

* fix: tests

* fix(a11y): improve image attachment accessibility labels and order

* action: organized translations

* fix: unit tests

* fix: focus

* fix: a11y labels

* chore: format code and fix lint issues

* test

* fix: merge conflicts

* feat: improve a11y experience

* fix: unlabelled on android

* fix: action sheet input keyboard

* fix: announce GIFs as interactive in ImageViewer for screen readers

* fix: ignore whitespace-only alt text in message a11y label

* refactor: extract sendAttachments helper from composer and share view

* action: organized translations

* feat: code improvements

* code improvements

* refactor: extract useImageDescriptionLabel hook and inline useAltTextSupported in Image

* fix: i18n

* action: organized translations

* refactor: stabilize FlatList renderers and harden altText checks

* fix(a11y): omit empty segments in message accessibilityLabel

* refactor: extract normalizeAttachment and preserve handler order
  in useChooseMedia

* refactor: extract normalizeAttachment and preserve handler order
  in useChooseMedia

* rollback prettier changes

* feat: attachment action sheet stories and test

* feat: attachment actionsheet stories and tests

* feat: announce images without description to screen readers

* action: organized translations

* fix: render Attachment file name in Thread Message preview when body is empty (#7323)

* fix: preference value changes causing reset to other option (#7313)

* fix: do not encrypt messages when workspace E2E is disabled (#7324)

* fix: snapshot test

* fix: snapshot test

* feat: unify thumbs

* efactor: rename handlePickedAttachments to handleSelectedAttachments

* fix: pass altText and isAnimated to ImageViewer in ShareView Preview

* refactor: make AltTextLabel altText optional with early return

* fix: stop leaking attachment.altText into caption rendering

* fix: if no alt text its rendering an empty absolute view

* test: cover useMessageAccessibilityLabel and keep suffix on
  translated

* refactor: prefer title_link/message_link over index for Reply attachment key

* refactor: unify ShareView Thumbs and ComposerAttachments under
  shared AttachmentThumbs

* feat: unify Thumbs

* remove memo of useImageDescriptionLabel

* fix: test and lint

* fix: test

* fix: i18n missing translation

* fix: fallback accessibility label when alt text is empty

* fix: remove unused code

* rollback prettier changes

* refactor: colocate useImageDescriptionLabel with message hooks

* refactor: simplify message accessibility label composition

* feat: add missing keys

* feat: use thumb as children instead of add it again

* refactor: tighten types and stable keys in message/share views

* fix: useTheme on AltTextInput

* action: organized translations

* chore: code organization

* chore: type improvement

* chore: code organization

* fix: image improvement

* code improvements

* fix: avoid undefined a11y label

* fix: altText trim and improvements

* fix: tests

* fix: use memo composer attachments

* chore: remove editAltText (not available)

* feat: standardize shareView composer

---------

Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Rohit Bansal <40559587+Rohit3523@users.noreply.github.com>
* feat: announcement and focus

* action: organized translations

* fix: lint

* fix: iOS announcement

* fix: focus switch

* fix: unit tests

* fix: unit tests

* chore: migrate last focus to hooks

* fix: en translation

* fix: back focus to message

* code improvements

* fix: message actions announcement

* fix: tests

* fix: touch

* feat: a11y improvements

* action: organized translations

* fix: Touch

* i18n: translations

* useMessageAccessibilityActions and Label as hooks

* action: organized translations

* feat: control back focus on hook

* feat(a11y): message a11y label just on Touchable and add "press to view thread" hint to message accessibility label

* fix: snapshot

* fix: test snapshot

* test: fix iOS Maestro thread test by tapping message content instead of replied-on-thread indicator

* fix: encryption test ios

* code improvements

* code improvements

* fix: snapshot test

* fix: i18n

* action: organized translations

* remove duplicated label

* remove duplicated props

---------

Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
* fix: acrionSheet height considering handle

* feat: e2e tests

* fix: e2e tests
…7336)

* chore:keyboard navigation focus on header instead of composer

* fix: focus change

* chore: code improvements

* fix: room test flow

* fix: test

* fix: e2e tests

* fix: test

* fix: tests

* fix: e2e test

* fix: e2e test

* fix: e2e test

* rollback

* improve autoFocus condition

* rollback unused change

* rollback unused change
…es (#7305)

* fix: fetch enough history when system messages are hidden

* trying to load messages

* load code improvements

* feat: improve test useMessages

* fix: dedupe concurrent room history fetches on cold open

* refactor: simplify loadMessagesForRoom and document history loader terms

* fix: tests
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Version number is decremented from 4.74.0 to 4.73.1 across root package.json, Android Gradle defaultConfig, iOS Xcode MARKETING_VERSION for NotificationService, and CFBundleShortVersionString in both iOS Info.plist files.

Changes

Platform version bump

Layer / File(s) Summary
Root package version
package.json
version updated from 4.74.04.73.1.
Android build version
android/app/build.gradle
versionName in defaultConfig changed from 4.74.04.73.1.
iOS project & Info.plist versions
ios/RocketChatRN.xcodeproj/project.pbxproj, ios/RocketChatRN/Info.plist, ios/ShareRocketChatRN/Info.plist
MARKETING_VERSION for NotificationService (Debug and Release) and CFBundleShortVersionString in both Info.plist files updated from 4.74.04.73.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: Merge 4.73.1 into master' accurately describes the main change—a version bump to 4.73.1 across all project files in preparation for a patch release.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • NATIVE-1210: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

# Conflicts:
#	android/app/build.gradle
#	ios/RocketChatRN.xcodeproj/project.pbxproj
#	ios/RocketChatRN/Info.plist
#	ios/ShareRocketChatRN/Info.plist
#	package.json
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

iOS Build Available

Rocket.Chat 4.73.1.109035

@diegolmello diegolmello deployed to upload_android June 8, 2026 19:35 — with GitHub Actions Active
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Android Build Available

Rocket.Chat 4.73.1.109040

@diegolmello diegolmello changed the base branch from develop to master June 9, 2026 19:03
@diegolmello diegolmello requested a deployment to approve_e2e_testing June 9, 2026 19:28 — with GitHub Actions Waiting
@diegolmello diegolmello merged commit 2e9d8c1 into master Jun 9, 2026
6 of 9 checks passed
@diegolmello diegolmello deleted the 4.73.1 branch June 9, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants