chore: Merge 4.73.1 into master#7370
Conversation
* fix: emoji picker scroll does not reach the end * feat: add test to pick the last emoji in emoji picker * fix: e2e test * fix: tests * tests * remove unused pod * rename emoji category * fix: new test flow * rollback space
* feat: alt text * action: organized translations * fix: move alt text accessibility to button level and fix gallery height * chore: format code and fix lint issues * ix: stable gallery keys and forward alt text accessibility to gallery items * fix: i18n fallbacks, alt text a11y label, stale altText on remove, and 8.4.0 boundary test * action: organized translations * fix: i18n * action: organized translations * fix: preserve caption on send, correct version gate for share extension, and translated a11y labels in gallery * fix: alt text label * feat: queue composer attachments inline * feat: open attachment alt text in action sheet * fix: remove image gallery * action: organized translations * feat: edit message alt text * chore: format code and fix lint issues * feat: backward compatibilities * fix: edit * remove image gallery * fix: conflicts * code improvements * fix: composer * code improvements * fix: tests * fix(a11y): improve image attachment accessibility labels and order * action: organized translations * fix: unit tests * fix: focus * fix: a11y labels * chore: format code and fix lint issues * test * fix: merge conflicts * feat: improve a11y experience * fix: unlabelled on android * fix: action sheet input keyboard * fix: announce GIFs as interactive in ImageViewer for screen readers * fix: ignore whitespace-only alt text in message a11y label * refactor: extract sendAttachments helper from composer and share view * action: organized translations * feat: code improvements * code improvements * refactor: extract useImageDescriptionLabel hook and inline useAltTextSupported in Image * fix: i18n * action: organized translations * refactor: stabilize FlatList renderers and harden altText checks * fix(a11y): omit empty segments in message accessibilityLabel * refactor: extract normalizeAttachment and preserve handler order in useChooseMedia * refactor: extract normalizeAttachment and preserve handler order in useChooseMedia * rollback prettier changes * feat: attachment action sheet stories and test * feat: attachment actionsheet stories and tests * feat: announce images without description to screen readers * action: organized translations * fix: render Attachment file name in Thread Message preview when body is empty (#7323) * fix: preference value changes causing reset to other option (#7313) * fix: do not encrypt messages when workspace E2E is disabled (#7324) * fix: snapshot test * fix: snapshot test * feat: unify thumbs * efactor: rename handlePickedAttachments to handleSelectedAttachments * fix: pass altText and isAnimated to ImageViewer in ShareView Preview * refactor: make AltTextLabel altText optional with early return * fix: stop leaking attachment.altText into caption rendering * fix: if no alt text its rendering an empty absolute view * test: cover useMessageAccessibilityLabel and keep suffix on translated * refactor: prefer title_link/message_link over index for Reply attachment key * refactor: unify ShareView Thumbs and ComposerAttachments under shared AttachmentThumbs * feat: unify Thumbs * remove memo of useImageDescriptionLabel * fix: test and lint * fix: test * fix: i18n missing translation * fix: fallback accessibility label when alt text is empty * fix: remove unused code * rollback prettier changes * refactor: colocate useImageDescriptionLabel with message hooks * refactor: simplify message accessibility label composition * feat: add missing keys * feat: use thumb as children instead of add it again * refactor: tighten types and stable keys in message/share views * fix: useTheme on AltTextInput * action: organized translations * chore: code organization * chore: type improvement * chore: code organization * fix: image improvement * code improvements * fix: avoid undefined a11y label * fix: altText trim and improvements * fix: tests * fix: use memo composer attachments * chore: remove editAltText (not available) * feat: standardize shareView composer --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> Co-authored-by: Diego Mello <diegolmello@gmail.com> Co-authored-by: Rohit Bansal <40559587+Rohit3523@users.noreply.github.com>
* feat: announcement and focus * action: organized translations * fix: lint * fix: iOS announcement * fix: focus switch * fix: unit tests * fix: unit tests * chore: migrate last focus to hooks * fix: en translation * fix: back focus to message * code improvements * fix: message actions announcement * fix: tests * fix: touch * feat: a11y improvements * action: organized translations * fix: Touch * i18n: translations * useMessageAccessibilityActions and Label as hooks * action: organized translations * feat: control back focus on hook * feat(a11y): message a11y label just on Touchable and add "press to view thread" hint to message accessibility label * fix: snapshot * fix: test snapshot * test: fix iOS Maestro thread test by tapping message content instead of replied-on-thread indicator * fix: encryption test ios * code improvements * code improvements * fix: snapshot test * fix: i18n * action: organized translations * remove duplicated label * remove duplicated props --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> Co-authored-by: Diego Mello <diegolmello@gmail.com>
* fix: acrionSheet height considering handle * feat: e2e tests * fix: e2e tests
…7336) * chore:keyboard navigation focus on header instead of composer * fix: focus change * chore: code improvements * fix: room test flow * fix: test * fix: e2e tests * fix: test * fix: tests * fix: e2e test * fix: e2e test * fix: e2e test * rollback * improve autoFocus condition * rollback unused change * rollback unused change
…urvives backgrounding (#7346)
…es (#7305) * fix: fetch enough history when system messages are hidden * trying to load messages * load code improvements * feat: improve test useMessages * fix: dedupe concurrent room history fetches on cold open * refactor: simplify loadMessagesForRoom and document history loader terms * fix: tests
WalkthroughVersion number is decremented from 4.74.0 to 4.73.1 across root ChangesPlatform version bump
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # android/app/build.gradle # ios/RocketChatRN.xcodeproj/project.pbxproj # ios/RocketChatRN/Info.plist # ios/ShareRocketChatRN/Info.plist # package.json
…piler memoization (#7348)
* chore: unify search announcement results for a11y * chore: create useDirectorySearch hook * feat: migrate directoryView to hooks * code improvements * fix: tests
|
iOS Build Available Rocket.Chat 4.73.1.109035 |
|
Android Build Available Rocket.Chat 4.73.1.109040 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNRBbxEQK4Hwi8soUycXUHG1E1NFBLPrZI7xG1qmT1gZ40JFZZaISodDKNJmvrIw30TMUF3mNboRn5Y_o0Y3 |
|
Android Build Available Rocket.Chat 4.73.1.109040 |
Proposed changes
Merge the 4.73.1 patch release into
master. The version was bumped acrosspackage.json,android/app/build.gradle, iOSInfo.plist(app + share extension), andMARKETING_VERSIONin the Xcode project (RocketChatRN + NotificationService), and the release has already shipped to the App Store and Play Store.As a patch, 4.73.1 does not flow through
develop. A companion PR (#7391) merges the same release intosingle-server.Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-1215
How to test or reproduce
cat package.json | grep version->4.73.1grep versionName android/app/build.gradle->4.73.1grep CFBundleShortVersionString -A1 ios/RocketChatRN/Info.plist ios/ShareRocketChatRN/Info.plist->4.73.1grep MARKETING_VERSION ios/RocketChatRN.xcodeproj/project.pbxproj-> two4.73.1entries (RocketChatRN, NotificationService)Screenshots
N/A
Types of changes
Checklist
Further comments
Summary by CodeRabbit