chore: log deprecation for DDP methods replaced or unused

Adds methodDeprecationLogger.method() calls to 148 Meteor methods that
are either orphan (no caller found in the repo) or already have a REST
endpoint replacement. Methods with the call now warn that they will be
removed in 9.0.0, and when applicable point to the replacement endpoint.

Methods still in use without a REST equivalent are intentionally left
untouched until a replacement endpoint exists. Already-deprecated
methods (sendFileMessage, starMessage, insertOrUpdateSound,
uploadCustomSound) are kept as-is.

Generated by scripts/add-ddp-deprecation.mjs from docs/ddp-audit.json.

Author: ggazzo

apps/meteor/app/2fa/server/methods/disable.ts

@@ -2,6 +2,7 @@ import type { ServerMethods } from '@rocket.chat/ddp-client';
 import { Users } from '@rocket.chat/models';
 import { Meteor } from 'meteor/meteor';
 
+import { methodDeprecationLogger } from '../../../lib/server/lib/deprecationWarningLogger';
 import { notifyOnUserChange } from '../../../lib/server/lib/notifyListener';
 import { TOTP } from '../lib/totp';
 
@@ -14,6 +15,7 @@ declare module '@rocket.chat/ddp-client' {
 
 Meteor.methods<ServerMethods>({
 	async '2fa:disable'(code) {
+		methodDeprecationLogger.method('2fa:disable', '9.0.0', '/v1/users.2fa.sendEmailCode');
 		const userId = Meteor.userId();
 		if (!userId) {
 			throw new Meteor.Error('not-authorized');

apps/meteor/app/2fa/server/methods/enable.ts

@@ -2,6 +2,7 @@ import type { ServerMethods } from '@rocket.chat/ddp-client';
 import { Users } from '@rocket.chat/models';
 import { Meteor } from 'meteor/meteor';
 
+import { methodDeprecationLogger } from '../../../lib/server/lib/deprecationWarningLogger';
 import { TOTP } from '../lib/totp';
 
 declare module '@rocket.chat/ddp-client' {
@@ -13,6 +14,7 @@ declare module '@rocket.chat/ddp-client' {
 
 Meteor.methods<ServerMethods>({
 	async '2fa:enable'() {
+		methodDeprecationLogger.method('2fa:enable', '9.0.0', '/v1/users.2fa.enableEmail');
 		const userId = Meteor.userId();
 		if (!userId) {
 			throw new Meteor.Error('not-authorized');

apps/meteor/app/authorization/server/streamer/permissions/index.ts

@@ -5,6 +5,8 @@ import { check, Match } from 'meteor/check';
 import { Meteor } from 'meteor/meteor';
 import type { WithId } from 'mongodb';
 
+import { methodDeprecationLogger } from '../../../../lib/server/lib/deprecationWarningLogger';
+
 declare module '@rocket.chat/ddp-client' {
 	// eslint-disable-next-line @typescript-eslint/naming-convention
 	interface ServerMethods {
@@ -31,6 +33,7 @@ export const permissionsGetMethod = async (
 
 Meteor.methods<ServerMethods>({
 	async 'permissions/get'(updatedAt?: Date) {
+		methodDeprecationLogger.method('permissions/get', '9.0.0', []);
 		check(updatedAt, Match.Maybe(Date));
 		// TODO: should we return this for non logged users?
 		// TODO: we could cache this collection

apps/meteor/app/autotranslate/server/methods/saveSettings.ts

@@ -1,6 +1,7 @@
 import type { ServerMethods } from '@rocket.chat/ddp-client';
 import { Meteor } from 'meteor/meteor';
 
+import { methodDeprecationLogger } from '../../../lib/server/lib/deprecationWarningLogger';
 import { saveAutoTranslateSettings } from '../functions/saveSettings';
 
 declare module '@rocket.chat/ddp-client' {
@@ -12,6 +13,7 @@ declare module '@rocket.chat/ddp-client' {
 
 Meteor.methods<ServerMethods>({
 	async 'autoTranslate.saveSettings'(rid, field, value, options) {
+		methodDeprecationLogger.method('autoTranslate.saveSettings', '9.0.0', []);
 		const userId = Meteor.userId();
 		if (!userId) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {

apps/meteor/app/bot-helpers/server/index.ts

@@ -9,6 +9,7 @@ import { removeUserFromRoomMethod } from '../../../server/methods/removeUserFrom
 import { hasRoleAsync } from '../../authorization/server/functions/hasRole';
 import { addUserToRole } from '../../authorization/server/methods/addUserToRole';
 import { removeUserFromRole } from '../../authorization/server/methods/removeUserFromRole';
+import { methodDeprecationLogger } from '../../lib/server/lib/deprecationWarningLogger';
 import { addUsersToRoomMethod } from '../../lib/server/methods/addUsersToRoom';
 import { settings } from '../../settings/server';
 
@@ -205,6 +206,7 @@ declare module '@rocket.chat/ddp-client' {
 
 Meteor.methods<ServerMethods>({
 	async botRequest(...args) {
+		methodDeprecationLogger.method('botRequest', '9.0.0', []);
 		const userID = Meteor.userId();
 		if (userID && (await hasRoleAsync(userID, 'bot'))) {
 			return botHelpers.request(...args, userID);

apps/meteor/app/channel-settings/server/methods/saveRoomSettings.ts

@@ -11,6 +11,7 @@ import { roomCoordinator } from '../../../../server/lib/rooms/roomCoordinator';
 import { hasPermissionAsync } from '../../../authorization/server/functions/hasPermission';
 import { isABACManagedRoom } from '../../../authorization/server/lib/isABACManagedRoom';
 import { setRoomAvatar } from '../../../lib/server/functions/setRoomAvatar';
+import { methodDeprecationLogger } from '../../../lib/server/lib/deprecationWarningLogger';
 import { notifyOnRoomChangedById } from '../../../lib/server/lib/notifyListener';
 import { settings } from '../../../settings/server';
 import { saveReactWhenReadOnly } from '../functions/saveReactWhenReadOnly';
@@ -547,6 +548,7 @@ export async function saveRoomSettings(
 
 Meteor.methods<ServerMethods>({
 	saveRoomSettings: (...args) => {
+		methodDeprecationLogger.method('saveRoomSettings', '9.0.0', '/v1/rooms.saveRoomSettings');
 		const userId = Meteor.userId();
 		if (!userId) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {

apps/meteor/app/cloud/server/methods.ts

@@ -12,6 +12,7 @@ import { startRegisterWorkspace } from './functions/startRegisterWorkspace';
 import { syncWorkspace } from './functions/syncWorkspace';
 import { userLogout } from './functions/userLogout';
 import { hasPermissionAsync } from '../../authorization/server/functions/hasPermission';
+import { methodDeprecationLogger } from '../../lib/server/lib/deprecationWarningLogger';
 
 declare module '@rocket.chat/ddp-client' {
 	// eslint-disable-next-line @typescript-eslint/naming-convention
@@ -40,6 +41,7 @@ Meteor.methods<ServerMethods>({
 	 * Prefer using cloud.registrationStatus rest api.
 	 */
 	async 'cloud:checkRegisterStatus'() {
+		methodDeprecationLogger.method('cloud:checkRegisterStatus', '9.0.0', []);
 		const uid = Meteor.userId();
 
 		if (!uid) {
@@ -74,6 +76,7 @@ Meteor.methods<ServerMethods>({
 		return Buffer.from(JSON.stringify(await buildWorkspaceRegistrationData(undefined))).toString('base64');
 	},
 	async 'cloud:registerWorkspace'() {
+		methodDeprecationLogger.method('cloud:registerWorkspace', '9.0.0', []);
 		const uid = Meteor.userId();
 
 		if (!uid) {
@@ -91,6 +94,7 @@ Meteor.methods<ServerMethods>({
 		return startRegisterWorkspace();
 	},
 	async 'cloud:syncWorkspace'() {
+		methodDeprecationLogger.method('cloud:syncWorkspace', '9.0.0', '/v1/cloud.syncWorkspace');
 		const uid = Meteor.userId();
 
 		if (!uid) {
@@ -136,6 +140,7 @@ Meteor.methods<ServerMethods>({
 	},
 	// Currently unused but will link local account to Rocket.Chat Cloud account.
 	async 'cloud:getOAuthAuthorizationUrl'() {
+		methodDeprecationLogger.method('cloud:getOAuthAuthorizationUrl', '9.0.0', []);
 		const uid = Meteor.userId();
 		if (!uid) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {
@@ -152,6 +157,7 @@ Meteor.methods<ServerMethods>({
 		return getOAuthAuthorizationUrl();
 	},
 	async 'cloud:finishOAuthAuthorization'(code, state) {
+		methodDeprecationLogger.method('cloud:finishOAuthAuthorization', '9.0.0', []);
 		check(code, String);
 		check(state, String);
 
@@ -172,6 +178,7 @@ Meteor.methods<ServerMethods>({
 		return finishOAuthAuthorization(code, state);
 	},
 	async 'cloud:checkUserLoggedIn'() {
+		methodDeprecationLogger.method('cloud:checkUserLoggedIn', '9.0.0', []);
 		const uid = Meteor.userId();
 		if (!uid) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {
@@ -188,6 +195,7 @@ Meteor.methods<ServerMethods>({
 		return checkUserHasCloudLogin(uid);
 	},
 	async 'cloud:logout'() {
+		methodDeprecationLogger.method('cloud:logout', '9.0.0', []);
 		const uid = Meteor.userId();
 		if (!uid) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {

apps/meteor/app/crowd/server/methods.ts

@@ -5,6 +5,7 @@ import { Meteor } from 'meteor/meteor';
 import { CROWD } from './crowd';
 import { logger } from './logger';
 import { hasPermissionAsync } from '../../authorization/server/functions/hasPermission';
+import { methodDeprecationLogger } from '../../lib/server/lib/deprecationWarningLogger';
 import { settings } from '../../settings/server';
 
 declare module '@rocket.chat/ddp-client' {
@@ -17,6 +18,7 @@ declare module '@rocket.chat/ddp-client' {
 
 Meteor.methods<ServerMethods>({
 	async crowd_test_connection() {
+		methodDeprecationLogger.method('crowd_test_connection', '9.0.0', []);
 		const user = await Meteor.userAsync();
 		if (!user) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {
@@ -51,6 +53,7 @@ Meteor.methods<ServerMethods>({
 		}
 	},
 	async crowd_sync_users() {
+		methodDeprecationLogger.method('crowd_sync_users', '9.0.0', []);
 		const user = await Meteor.userAsync();
 		if (settings.get('CROWD_Enable') !== true) {
 			throw new Meteor.Error('crowd_disabled');

apps/meteor/app/discussion/server/methods/createDiscussion.ts

@@ -15,6 +15,7 @@ import { attachMessage } from '../../../lib/server/functions/attachMessage';
 import { createRoom } from '../../../lib/server/functions/createRoom';
 import { sendMessage } from '../../../lib/server/functions/sendMessage';
 import { afterSaveMessageAsync } from '../../../lib/server/lib/afterSaveMessage';
+import { methodDeprecationLogger } from '../../../lib/server/lib/deprecationWarningLogger';
 import { settings } from '../../../settings/server';
 
 const getParentRoom = async (rid: IRoom['_id']) => {
@@ -85,7 +86,7 @@ const create = async ({
 		}
 		if (prid) {
 			const parentRoom = await getParentRoom(message.rid);
-			if (!parentRoom || prid !== parentRoom._id) {
+			if (prid !== parentRoom?._id) {
 				throw new Meteor.Error('error-invalid-arguments', 'Root message room ID does not match parent room ID ', {
 					method: 'DiscussionCreation',
 				});
@@ -247,6 +248,7 @@ Meteor.methods<ServerMethods>({
 	 * @param {boolean} encrypted - if the discussion's e2e encryption should be enabled.
 	 */
 	async createDiscussion({ prid, pmid, t_name: discussionName, reply, users, encrypted }: CreateDiscussionProperties) {
+		methodDeprecationLogger.method('createDiscussion', '9.0.0', '/v1/rooms.createDiscussion');
 		check(prid, Match.Maybe(String));
 		check(pmid, Match.Maybe(String));
 		check(reply, Match.Maybe(String));

apps/meteor/app/e2e/server/methods/fetchMyKeys.ts

@@ -2,6 +2,8 @@ import type { ServerMethods } from '@rocket.chat/ddp-client';
 import { Users } from '@rocket.chat/models';
 import { Meteor } from 'meteor/meteor';
 
+import { methodDeprecationLogger } from '../../../lib/server/lib/deprecationWarningLogger';
+
 declare module '@rocket.chat/ddp-client' {
 	// eslint-disable-next-line @typescript-eslint/naming-convention
 	interface ServerMethods {
@@ -11,6 +13,7 @@ declare module '@rocket.chat/ddp-client' {
 
 Meteor.methods<ServerMethods>({
 	async 'e2e.fetchMyKeys'() {
+		methodDeprecationLogger.method('e2e.fetchMyKeys', '9.0.0', '/v1/e2e.fetchMyKeys');
 		const userId = Meteor.userId();
 		if (!userId) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', { method: 'e2e.fetchMyKeys' });