Revert "fix: Regular members listed as owners in channel members list" (#38798)

Author: ggazzo

.changeset/roles-display-fix.md

@@ -89,11 +89,11 @@ const RoomMembers = ({
 
 	const useRealName = useSetting('UI_Use_Real_Name', false);
 
-	const { counts, titles, sortedMembers } = useMemo(() => {
-		const owners: RoomMemberUser[] = [];
-		const leaders: RoomMemberUser[] = [];
-		const moderators: RoomMemberUser[] = [];
-		const normalMembers: RoomMemberUser[] = [];
+	const { counts, titles } = useMemo(() => {
+		const owners: RoomMember[] = [];
+		const leaders: RoomMember[] = [];
+		const moderators: RoomMember[] = [];
+		const normalMembers: RoomMember[] = [];
 
 		members.forEach((member) => {
 			if (member.roles?.includes('owner')) {
@@ -130,9 +130,7 @@ const RoomMembers = ({
 			titles.push(<MembersListDivider title='Members' count={normalMembers.length} />);
 		}
 
-		const sortedMembers = [...owners, ...leaders, ...moderators, ...normalMembers];
-
-		return { counts, titles, sortedMembers };
+		return { counts, titles };
 	}, [members]);
 
 	return (
@@ -190,7 +188,7 @@ const RoomMembers = ({
 									// eslint-disable-next-line react/no-multi-comp
 									components={{ Footer: () => <InfiniteListAnchor loadMore={loadMoreMembers} /> }}
 									itemContent={(index): ReactElement => (
-										<RowComponent useRealName={useRealName} data={itemData} user={sortedMembers[index]} index={index} reload={reload} />
+										<RowComponent useRealName={useRealName} data={itemData} user={members[index]} index={index} reload={reload} />
 									)}
 								/>
 							</VirtualizedScrollbars>