feat: migrate sendMessage + getReadReceipts callers from DDP to REST

Two methods that resisted the URL-swap pass in the wider DDP -> REST
migration. This PR contains the deeper refactor each needed.

sendMessage
  Replace sdk.call('sendMessage', message, previewUrls) with
  sdk.rest.post('/v1/chat.sendMessage', { message, previewUrls }).
  In the primary send flow (apps/meteor/client/lib/chats/flows/sendMessage.ts)
  the response's server-rendered { message } is fed back into
  Messages.state via mapMessageFromApi, replacing the optimistic temp
  record in the same tick the REST call resolves. That reproduces the
  Minimongo replication the DDP method triggered — composer quote
  previews unmount, attachment renderers see attachments[] and urls[],
  message _updatedAt advances — all without waiting for the
  room-messages stream event to arrive separately.

  The seven fire-and-forget callsites do not run the optimistic
  reconcile and are straight URL swaps:
    - apps/meteor/client/hooks/notification/useNotification.ts
    - apps/meteor/client/apps/gameCenter/GameCenterInvitePlayersModal.tsx
    - apps/meteor/app/slashcommand-asciiarts/client/{lenny,tableflip,unflip,gimme,shrug}.ts

getReadReceipts
  Replace useMethod('getReadReceipts') with
  useEndpoint('GET', '/v1/chat.getMessageReadReceipts') in
  ReadReceiptsModal. Add rid prop and subscribe to
  notify-room/<rid>/messagesRead; on event, invalidate the
  ['read-receipts', messageId] query so the dialog re-fetches when new
  receipts land. mapReadReceiptFromApi revives the Date fields the
  REST endpoint serializes as strings.

Server-side: ReadReceipt.markMessagesAsRead /
ReadReceipt.markMessageAsReadBySender /
ReadReceipt.storeThreadMessagesReadReceipts no longer fire-and-forget
the storeReadReceipts insertion — they await it. Closes the
read-after-write race the omnichannel-livechat-read-receipts e2e test
exposed: a fast REST GET could observe a partial set of receipts
because the visitor's self-receipt insert was still in flight when the
test opened the Read-Receipts dialog.

Author: ggazzo

apps/meteor/app/slashcommand-asciiarts/client/gimme.ts

@@ -8,7 +8,7 @@ import { slashCommands } from '../../utils/client/slashCommand';
  */
 async function Gimme({ message, params }: SlashCommandCallbackParams<'gimme'>): Promise<void> {
 	const msg = message;
-	await sdk.call('sendMessage', { ...msg, msg: `༼ つ ◕_◕ ༽つ ${params}` });
+	await sdk.rest.post('/v1/chat.sendMessage', { message: { ...msg, msg: `༼ つ ◕_◕ ༽つ ${params}` } });
 }
 
 slashCommands.add({

apps/meteor/app/slashcommand-asciiarts/client/lenny.ts

@@ -9,7 +9,7 @@ import { slashCommands } from '../../utils/client/slashCommand';
 
 async function LennyFace({ message, params }: SlashCommandCallbackParams<'lenny'>): Promise<void> {
 	const msg = message;
-	await sdk.call('sendMessage', { ...msg, msg: `${params} ( ͡° ͜ʖ ͡°)` });
+	await sdk.rest.post('/v1/chat.sendMessage', { message: { ...msg, msg: `${params} ( ͡° ͜ʖ ͡°)` } });
 }
 
 slashCommands.add({

apps/meteor/app/slashcommand-asciiarts/client/shrug.ts

@@ -11,7 +11,7 @@ slashCommands.add({
 	command: 'shrug',
 	callback: async ({ message, params }: SlashCommandCallbackParams<'shrug'>): Promise<void> => {
 		const msg = message;
-		await sdk.call('sendMessage', { ...msg, msg: `${params} ¯\\\\_(ツ)_/¯` });
+		await sdk.rest.post('/v1/chat.sendMessage', { message: { ...msg, msg: `${params} ¯\\\\_(ツ)_/¯` } });
 	},
 	options: {
 		description: 'Slash_Shrug_Description',

apps/meteor/app/slashcommand-asciiarts/client/tableflip.ts

@@ -11,7 +11,7 @@ slashCommands.add({
 	command: 'tableflip',
 	callback: async ({ message, params }: SlashCommandCallbackParams<'tableflip'>): Promise<void> => {
 		const msg = message;
-		await sdk.call('sendMessage', { ...msg, msg: `${params} (╯°□°）╯︵ ┻━┻` });
+		await sdk.rest.post('/v1/chat.sendMessage', { message: { ...msg, msg: `${params} (╯°□°）╯︵ ┻━┻` } });
 	},
 	options: {
 		description: 'Slash_Tableflip_Description',

apps/meteor/app/slashcommand-asciiarts/client/unflip.ts

@@ -11,7 +11,7 @@ slashCommands.add({
 	command: 'unflip',
 	callback: async ({ message, params }: SlashCommandCallbackParams<'unflip'>): Promise<void> => {
 		const msg = message;
-		await sdk.call('sendMessage', { ...msg, msg: `${params} ┬─┬ ノ( ゜-゜ノ)` });
+		await sdk.rest.post('/v1/chat.sendMessage', { message: { ...msg, msg: `${params} ┬─┬ ノ( ゜-゜ノ)` } });
 	},
 	options: {
 		description: 'Slash_TableUnflip_Description',

apps/meteor/client/apps/gameCenter/GameCenterInvitePlayersModal.tsx

@@ -11,7 +11,6 @@ import { sdk } from '../../../app/utils/client/lib/SDKClient';
 import UserAutoCompleteMultiple from '../../components/UserAutoCompleteMultiple';
 import { useOpenedRoom } from '../../lib/RoomManager';
 import { roomCoordinator } from '../../lib/rooms/roomCoordinator';
-import { callWithErrorHandling } from '../../lib/utils/callWithErrorHandling';
 
 type Username = Exclude<IUser['username'], undefined>;
 
@@ -36,10 +35,12 @@ const GameCenterInvitePlayersModal = ({ game, onClose }: IGameCenterInvitePlayer
 			roomCoordinator.openRouteLink(group.t, { rid: group._id, name: group.name });
 
 			if (openedRoom === group._id) {
-				await callWithErrorHandling('sendMessage', {
-					_id: Random.id(),
-					rid: group._id,
-					msg: t('Apps_Game_Center_Play_Game_Together', { name }),
+				void sdk.rest.post('/v1/chat.sendMessage', {
+					message: {
+						_id: Random.id(),
+						rid: group._id,
+						msg: t('Apps_Game_Center_Play_Game_Together', { name }),
+					},
 				});
 			}
 			onClose();

apps/meteor/client/components/message/toolbar/useReadReceiptsDetailsAction.tsx

@@ -24,6 +24,7 @@ export const useReadReceiptsDetailsAction = (message: IMessage): MessageActionCo
 			setModal(
 				<ReadReceiptsModal
 					messageId={message._id}
+					rid={message.rid}
 					onClose={() => {
 						setModal(null);
 					}}

apps/meteor/client/hooks/notification/useNotification.ts

@@ -51,10 +51,12 @@ export const useNotification = () => {
 			n.addEventListener(
 				'reply',
 				({ response }) =>
-					void sdk.call('sendMessage', {
-						_id: Random.id(),
-						rid,
-						msg: response,
+					void sdk.rest.post('/v1/chat.sendMessage', {
+						message: {
+							_id: Random.id(),
+							rid,
+							msg: response,
+						},
 					}),
 			);
 		}

apps/meteor/client/lib/chats/flows/sendMessage.ts

@@ -7,6 +7,7 @@ import { closeUnclosedCodeBlock } from '../../../../lib/utils/closeUnclosedCodeB
 import { Messages } from '../../../stores';
 import { onClientBeforeSendMessage } from '../../onClientBeforeSendMessage';
 import { dispatchToastMessage } from '../../toast';
+import { mapMessageFromApi } from '../../utils/mapMessageFromApi';
 import type { ChatAPI } from '../ChatAPI';
 import { afterSendMessageCallback } from './afterSendMessageCallback';
 import { processMessageEditing } from './processMessageEditing';
@@ -47,12 +48,17 @@ const process = async (chat: ChatAPI, message: IMessage, previewUrls?: string[],
 
 	chat.composer?.clear();
 	await runOptimisticSendMessage(message);
-	await sdk.call('sendMessage', message, previewUrls);
 
-	// after the request is complete we can go ahead and mark as sent
+	const { message: saved } = await sdk.rest.post('/v1/chat.sendMessage', { message, previewUrls });
+
+	// Replace the optimistic temp record with the server-rendered message so
+	// downstream consumers (composer quote preview, message list, threads)
+	// see the final shape — `attachments[]`, `urls[]`, `mentions[]`, etc. —
+	// in the same tick the REST call resolves. Mirrors the Minimongo replication
+	// that the DDP `sendMessage` method used to trigger.
 	Messages.state.update(
-		(record) => record._id === message._id && record.temp === true,
-		({ temp: _, ...record }) => record,
+		(record) => record._id === message._id,
+		() => mapMessageFromApi(saved),
 	);
 };
 

apps/meteor/client/views/room/modals/ReadReceiptsModal/ReadReceiptsModal.tsx

@@ -1,29 +1,44 @@
-import type { IMessage } from '@rocket.chat/core-typings';
+import type { IMessage, IRoom } from '@rocket.chat/core-typings';
 import { GenericModal, GenericModalSkeleton } from '@rocket.chat/ui-client';
-import { useMethod, useToastMessageDispatch } from '@rocket.chat/ui-contexts';
-import { useQuery } from '@tanstack/react-query';
+import { useEndpoint, useStream, useToastMessageDispatch } from '@rocket.chat/ui-contexts';
+import { useQuery, useQueryClient } from '@tanstack/react-query';
 import type { ReactElement } from 'react';
 import { useEffect } from 'react';
 import { useTranslation } from 'react-i18next';
 
 import ReadReceiptRow from './ReadReceiptRow';
+import { mapReadReceiptFromApi } from '../../../../lib/utils/mapReadReceiptFromApi';
 
 type ReadReceiptsModalProps = {
 	messageId: IMessage['_id'];
+	rid?: IRoom['_id'];
 	onClose: () => void;
 };
 
-const ReadReceiptsModal = ({ messageId, onClose }: ReadReceiptsModalProps): ReactElement => {
+const ReadReceiptsModal = ({ messageId, rid, onClose }: ReadReceiptsModalProps): ReactElement => {
 	const { t } = useTranslation();
 	const dispatchToastMessage = useToastMessageDispatch();
+	const queryClient = useQueryClient();
+	const subscribeToNotifyRoom = useStream('notify-room');
 
-	const getReadReceipts = useMethod('getReadReceipts');
+	const getReadReceipts = useEndpoint('GET', '/v1/chat.getMessageReadReceipts');
+
+	const queryKey = ['read-receipts', messageId];
 
 	const readReceiptsResult = useQuery({
-		queryKey: ['read-receipts', messageId],
-		queryFn: () => getReadReceipts({ messageId }),
+		queryKey,
+		queryFn: async () => (await getReadReceipts({ messageId })).receipts.map(mapReadReceiptFromApi),
 	});
 
+	useEffect(() => {
+		if (!rid) {
+			return;
+		}
+		return subscribeToNotifyRoom(`${rid}/messagesRead`, () => {
+			queryClient.invalidateQueries({ queryKey });
+		});
+	}, [rid, queryClient, queryKey, subscribeToNotifyRoom]);
+
 	useEffect(() => {
 		if (readReceiptsResult.isError) {
 			dispatchToastMessage({ type: 'error', message: readReceiptsResult.error });