fix: enable TEST_MODE_API for UI tests too

UI tests also exercise deprecated DDP methods indirectly through the
client (CachedStore template-literal calls, useMethod calls in code
that hasn't migrated to useEndpoint yet). The deprecation throw
suppression has to cover them too, not just api/api-livechat runs.

Author: ggazzo

.github/workflows/ci-test-e2e.yml

@@ -176,12 +176,13 @@ jobs:
       - name: Start containers for CE
         if: inputs.release == 'ce'
         env:
-          # API tests intentionally invoke deprecated DDP methods through
-          # /v1/method.call/:method. The deprecation logger throws under
-          # TEST_MODE, so for api/api-livechat runs we set TEST_MODE_API
-          # to suppress the throw (it still logs). Forwarded via
-          # docker-compose-ci.yml -> rocketchat container env.
-          TEST_MODE_API: ${{ (inputs.type == 'api' || inputs.type == 'api-livechat') && 'true' || '' }}
+          # End-to-end tests (api, api-livechat, ui) intentionally exercise
+          # deprecated DDP methods — directly through /v1/method.call/:method
+          # in API tests, indirectly via the client UI in UI tests. The
+          # deprecation logger throws under TEST_MODE, so for any e2e run we
+          # set TEST_MODE_API to suppress the throw (it still logs).
+          # Forwarded via docker-compose-ci.yml -> rocketchat container env.
+          TEST_MODE_API: 'true'
         run: |
           # when we are testing CE, we only need to start the rocketchat container
           DEBUG_LOG_LEVEL=${DEBUG_LOG_LEVEL:-0} docker compose -f docker-compose-ci.yml up -d rocketchat --wait
@@ -192,7 +193,7 @@ jobs:
           ENTERPRISE_LICENSE: ${{ inputs.enterprise-license }}
           TRANSPORTER: ${{ inputs.transporter }}
           COMPOSE_PROFILES: ${{ inputs.type == 'api' && 'api' || '' }}
-          TEST_MODE_API: ${{ (inputs.type == 'api' || inputs.type == 'api-livechat') && 'true' || '' }}
+          TEST_MODE_API: 'true'
         run: |
           DEBUG_LOG_LEVEL=${DEBUG_LOG_LEVEL:-0} docker compose -f docker-compose-ci.yml up -d --wait