Skip to content

Commit 6178156

Browse files
authored
regression: apps semver validation broke with pre-release identifier (#40643)
1 parent f3c2b83 commit 6178156

2 files changed

Lines changed: 6 additions & 18 deletions

File tree

packages/apps-engine/src/definition/version.ts

Lines changed: 0 additions & 16 deletions
This file was deleted.

packages/apps/src/server/compiler/AppPackageParser.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { randomUUID } from 'node:crypto';
22
import * as path from 'node:path';
33

44
import type { IAppInfo } from '@rocket.chat/apps-engine/definition/metadata/IAppInfo';
5-
import { ENGINE_VERSION } from '@rocket.chat/apps-engine/definition/version';
5+
import { version } from '@rocket.chat/apps-engine/package.json';
66
import AdmZip from 'adm-zip';
77
import * as semver from 'semver';
88

@@ -15,7 +15,11 @@ export class AppPackageParser {
1515

1616
private allowedIconExts: Array<string> = ['.png', '.jpg', '.jpeg', '.gif'];
1717

18-
private appsEngineVersion: string = ENGINE_VERSION;
18+
private readonly appsEngineVersion: string;
19+
20+
constructor() {
21+
[this.appsEngineVersion] = version.split('-'); // In case there is a suffix like -dev, -rc.0, etc. We just want the version number for semver comparison
22+
}
1923

2024
public async unpackageApp(appPackage: Buffer): Promise<IParseAppPackageResult> {
2125
const zip = new AdmZip(appPackage);

0 commit comments

Comments
 (0)