Skip to content

Commit 75519d9

Browse files
committed
fix: remove false-positive deprecation calls in search methods
The audit script picked up 'settings' and 'context' as method names from inside an object-literal return value and a JSDoc `@param` block. Those two methodDeprecationLogger calls were injected into the bodies of rocketchatSearch.getProvider and rocketchatSearch.search by mistake. Neither method is a deprecation target.
1 parent 017a166 commit 75519d9

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

apps/meteor/app/search/server/methods.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ Meteor.methods<ServerMethods>({
2525
* Get the current provider with key, description, resultTemplate, suggestionItemTemplate and settings (as Map)
2626
*/
2727
'rocketchatSearch.getProvider'() {
28-
methodDeprecationLogger.method('settings', '9.0.0', '/v1/settings');
2928
const provider = searchProviderService.activeProvider;
3029
if (!provider) {
3130
return undefined;
@@ -49,7 +48,6 @@ Meteor.methods<ServerMethods>({
4948
* @param payload custom payload (e.g. for paging)
5049
*/
5150
async 'rocketchatSearch.search'(text, context, payload) {
52-
methodDeprecationLogger.method('context', '9.0.0', []);
5351
payload = payload !== null ? payload : undefined; // TODO is this cleanup necessary?
5452

5553
if (!searchProviderService.activeProvider) {

0 commit comments

Comments
 (0)