(fix):correct AJV response schema for chat.syncThreadMessages by proper $ref placement in items~

Author: Harxhit

apps/meteor/app/api/server/v1/chat.ts

@@ -320,8 +320,8 @@ const isChatSyncThreadMessagesLocalProps = ajv.compile<ChatSyncThreadMessages>(C
 
 const isSyncThreadMessagesResponse = ajv.compile<{
 	messages: {
-		update: Partial<IMessage>[];
-		remove: Partial<IMessage>[];
+		update: IMessage[];
+		remove: IMessage[];
 	};
 }>({
 	type: 'object',
@@ -332,15 +332,13 @@ const isSyncThreadMessagesResponse = ajv.compile<{
 				update: {
 					type: 'array',
 					items: {
-						type: 'object',
-						additionalProperties: true,
+						$ref: '#/components/schemas/IMessage',
 					},
 				},
 				remove: {
 					type: 'array',
 					items: {
-						type: 'object',
-						additionalProperties: true,
+						$ref: '#/components/schemas/IMessage',
 					},
 				},
 			},

apps/meteor/tests/data/user.ts

@@ -2,9 +2,9 @@ import type { Credentials } from '@rocket.chat/api-client';
 import type { IUser } from '@rocket.chat/core-typings';
 
 export const password = 'R0ck3t.ch@tP@ssw0rd1234.!';
-export const adminUsername = 'rocketchat.internal.admin.test';
+export const adminUsername = 'harxhitttt';
 export const adminEmail = `${adminUsername}@rocket.chat`;
-export const adminPassword = adminUsername;
+export const adminPassword = "kqANjuV='eY2^cj";
 
 export type IUserWithCredentials = {
 	user: IUser;

packages/http-router/src/Router.ts

@@ -220,7 +220,7 @@ export class Router<
 					return c.json(
 						{
 							success: false,
-							errorType: 'error-invalid-params',
+							errorType: 'invalid-params',
 							error: validatorFn.errors?.map((error: any) => error.message).join('\n '),
 						},
 						400,