refactor(livechat): remove uneeded await on store.setState

Author: tassoevan

packages/livechat/src/components/FilesDropTarget/index.tsx

@@ -93,7 +93,7 @@ export const FilesDropTarget = ({
 			filteredFiles = filteredFiles.slice(0, 1);
 		}
 
-		filteredFiles.length && onUpload(filteredFiles);
+		if (filteredFiles.length) onUpload(filteredFiles);
 	};
 
 	return (

packages/livechat/src/lib/hooks.ts

@@ -202,7 +202,7 @@ const api = {
 
 	clearWidgetData: async () => {
 		const { minimized, visible, undocked, expanded, businessUnit, ...initial } = initialState();
-		await store.setState(initial);
+		store.setState(initial);
 	},
 
 	setAgent: (agent: StoreState['defaultAgent']) => {

packages/livechat/src/lib/triggerActions.ts

@@ -32,7 +32,7 @@ export const sendMessageAction = async (_: string, action: ILivechatSendMessageA
 	}
 
 	if (agent && '_id' in agent) {
-		await store.setState({ agent });
+		store.setState({ agent });
 		parentCall('callback', 'assign-agent', normalizeAgent(agent));
 	}
 
@@ -98,7 +98,7 @@ export const sendMessageExternalServiceAction = async (
 		);
 
 		if (agent && '_id' in agent) {
-			await store.setState({ agent });
+			store.setState({ agent });
 			parentCall('callback', 'assign-agent', normalizeAgent(agent));
 		}
 

packages/livechat/src/lib/triggerUtils.ts

@@ -1,10 +1,10 @@
 import type { ILivechatAgent, ILivechatTrigger, ILivechatTriggerAction, ILivechatTriggerType, Serialized } from '@rocket.chat/core-typings';
 
 import { Livechat } from '../api';
+import { processUnread } from './main';
 import type { Agent } from '../definitions/agents';
 import { upsert } from '../helpers/upsert';
 import store from '../store';
-import { processUnread } from './main';
 
 type AgentPromise = { username: string } | Serialized<ILivechatAgent> | null;
 
@@ -75,7 +75,7 @@ export const getAgent = async (triggerAction: ILivechatTriggerAction): Promise<A
 };
 
 export const upsertMessage = async (message: Record<string, unknown>) => {
-	await store.setState({
+	store.setState({
 		messages: upsert(
 			store.state.messages,
 			message,
@@ -89,12 +89,12 @@ export const upsertMessage = async (message: Record<string, unknown>) => {
 
 export const removeMessage = async (messageId: string) => {
 	const { messages } = store.state;
-	await store.setState({ messages: messages.filter(({ _id }) => _id !== messageId) });
+	store.setState({ messages: messages.filter(({ _id }) => _id !== messageId) });
 };
 
 export const removeTriggerMessage = async (messageId: string) => {
 	const { renderedTriggers } = store.state;
-	await store.setState({ renderedTriggers: renderedTriggers.filter(({ _id }) => _id !== messageId) });
+	store.setState({ renderedTriggers: renderedTriggers.filter(({ _id }) => _id !== messageId) });
 };
 
 export const hasTriggerCondition = (conditionName: ILivechatTriggerType) => (trigger: ILivechatTrigger) => {

packages/livechat/src/routes/GDPRAgreement/container.tsx

@@ -11,7 +11,7 @@ const GDPRContainer: FunctionalComponent<{ t: TFunction }> = ({ ref, t }) => {
 	const { config: { messages: { dataProcessingConsentText: consentText = '' } = {} } = {}, dispatch } = useContext(StoreContext);
 
 	const handleAgree = async () => {
-		await dispatch({ gdpr: { accepted: true } });
+		dispatch({ gdpr: { accepted: true } });
 		route('/');
 	};
 

packages/livechat/src/routes/LeaveMessage/index.tsx

@@ -58,7 +58,7 @@ const LeaveMessage: FunctionalComponent<{ path: string }> = () => {
 			message,
 		};
 
-		await dispatch({ loading: true });
+		dispatch({ loading: true });
 
 		try {
 			// TODO: Remove intersection after ts refactor of parseOfflineMessage
@@ -73,10 +73,10 @@ const LeaveMessage: FunctionalComponent<{ path: string }> = () => {
 			const errorMessage = (error as { error: string })?.error;
 			console.error(errorMessage);
 			const alert = { id: createToken(), children: errorMessage, error: true, timeout: 5000 };
-			await dispatch({ alerts: (alerts.push(alert), alerts) });
+			dispatch({ alerts: (alerts.push(alert), alerts) });
 			return false;
 		} finally {
-			await dispatch({ loading: false });
+			dispatch({ loading: false });
 		}
 	};
 

packages/livechat/src/routes/Register/index.tsx

@@ -93,7 +93,7 @@ export const Register: FunctionalComponent<{ path: string }> = () => {
 
 		try {
 			const { visitor: user } = await Livechat.grantVisitor({ visitor: { ...fields, token } });
-			await dispatch({
+			dispatch({
 				user,
 				...(user.contactManager && { agent: user.contactManager }),
 			} as Omit<StoreState['user'], 'ts'>);

packages/livechat/src/routes/SwitchDepartment/index.tsx

@@ -63,15 +63,15 @@ const SwitchDepartment = (_: SwitchDepartmentProps) => {
 
 		if (!room) {
 			const { visitor: user } = await Livechat.grantVisitor({ visitor: { department, token } });
-			await dispatch({
+			dispatch({
 				user: user as StoreState['user'],
 				alerts: (alerts.push({ id: createToken(), children: t('department_switched'), success: true }), alerts),
 			});
 			route('/');
 			return;
 		}
 
-		await dispatch({ loading: true });
+		dispatch({ loading: true });
 		try {
 			const { _id: rid } = room;
 			const result = await Livechat.transferChat({ rid, department });
@@ -81,7 +81,7 @@ const SwitchDepartment = (_: SwitchDepartmentProps) => {
 				throw t('no_available_agents_to_transfer');
 			}
 
-			await dispatch({ iframe: { ...iframe, guest: { ...guest, department } }, loading: false } as Pick<StoreState, 'iframe' | 'loading'>);
+			dispatch({ iframe: { ...iframe, guest: { ...guest, department } }, loading: false } as Pick<StoreState, 'iframe' | 'loading'>);
 			await loadConfig();
 
 			await ModalManager.alert({
@@ -91,11 +91,11 @@ const SwitchDepartment = (_: SwitchDepartmentProps) => {
 			route('/');
 		} catch (error) {
 			console.error(error);
-			await dispatch({
+			dispatch({
 				alerts: (alerts.push({ id: createToken(), children: t('no_available_agents_to_transfer'), warning: true }), alerts),
 			});
 		} finally {
-			await dispatch({ loading: false });
+			dispatch({ loading: false });
 		}
 	};