refactor(settings): remove setBulk method and update initialization logic

- Removed the setBulk method from CachedSettings to streamline the settings loading process.
- Updated the initializeSettings function to set records individually instead of using bulk loading, enhancing clarity and maintainability.

Author: ggazzo

apps/meteor/app/settings/server/CachedSettings.ts

@@ -56,12 +56,6 @@ export interface ICachedSettings {
 
 	set(record: ISetting): void;
 
-	/**
-	 * Bulk load records into the store without emitting or registering ready listeners.
-	 * Use during initial load; call initialized() after.
-	 */
-	setBulk(records: ISetting[]): void;
-
 	getConfig(config?: OverCustomSettingsConfig): SettingsConfig;
 
 	watchByRegex(regex: RegExp, cb: (...args: [string, SettingValue]) => void, config?: OverCustomSettingsConfig): () => void;
@@ -344,16 +338,6 @@ export class CachedSettings
 		this.emit('*', [record._id, this.store.get(record._id)?.value]);
 	}
 
-	/**
-	 * Bulk load records into the store without emitting or registering ready listeners.
-	 * Use during initial load only; call initialized() after.
-	 */
-	public setBulk(records: ISetting[]): void {
-		for (const record of records) {
-			this.store.set(record._id, record);
-		}
-	}
-
 	public getConfig = (config?: OverCustomSettingsConfig): SettingsConfig => ({
 		debounce: process.env.TEST_MODE ? 0 : 500,
 		...config,

apps/meteor/app/settings/server/startup.ts

@@ -1,11 +1,11 @@
-import type { ISetting } from '@rocket.chat/core-typings';
 import type { Settings } from '@rocket.chat/models';
 
 import type { ICachedSettings } from './CachedSettings';
 
-// eslint-disable-next-line @typescript-eslint/naming-convention
 export async function initializeSettings({ model, settings }: { model: typeof Settings; settings: ICachedSettings }): Promise<void> {
 	const records = await model.find().toArray();
-	settings.setBulk(records as ISetting[]);
+	for (const record of records) {
+		settings.set(record);
+	}
 	settings.initialized();
 }