refactor(apps): converge deno-runtime toward node-runtime

Reduce the platform-specific surface in deno-runtime by aligning six
drifted files with their canonical node-runtime implementations, ahead
of extracting a shared base runtime:

- messenger/main: use node:events EventEmitter for the RPC response
  observer instead of EventTarget + Custom/ErrorEvent
- parseArgs: use node:util instead of @std/cli (drop dead @std/cli dep)
- BlockBuilder: extend apps-engine BlockBuilder instead of duplicating it
  (enabled by sloppy-imports)
- handleUploadEvents: read uploads via node:fs/promises readFile + Buffer
- logger: implement ILogger with the full accessor surface
- accessors/mod: extract named WithProxy<T> consts

No behavior change intended. deno task test stays green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: d-gubert

packages/apps/deno-runtime/deno.jsonc

@@ -4,7 +4,6 @@
 		"@rocket.chat/ui-kit": "npm:@rocket.chat/ui-kit@^0.31.22",
 		"@rocket.chat/apps-engine/": "../../../packages/apps-engine/",
 		"@rocket.chat/apps/": "../",
-		"@std/cli": "jsr:@std/cli@^1.0.9",
 		"@std/io": "jsr:@std/io@^0.225.3",
 		"acorn": "npm:acorn@8.10.0",
 		"acorn-walk": "npm:acorn-walk@8.2.0",

packages/apps/deno-runtime/deno.lock

@@ -1,16 +1,18 @@
-import { open } from 'node:fs/promises';
+import { Buffer } from 'node:buffer';
+import { readFile } from 'node:fs/promises';
 
 import type { App } from '@rocket.chat/apps-engine/definition/App';
 import { AppsEngineException } from '@rocket.chat/apps-engine/definition/exceptions/AppsEngineException';
-import type { IFileUploadContext } from '@rocket.chat/apps-engine/definition/uploads/IFileUploadContext'
-import type { IUploadDetails } from '@rocket.chat/apps-engine/definition/uploads/IUploadDetails'
-import { Defined, JsonRpcError } from 'jsonrpc-lite';
+import type { IFileUploadContext } from '@rocket.chat/apps-engine/definition/uploads/IFileUploadContext';
+import type { IUploadDetails } from '@rocket.chat/apps-engine/definition/uploads/IUploadDetails';
+import type { Defined } from 'jsonrpc-lite';
+import { JsonRpcError } from 'jsonrpc-lite';
 
 import { AppObjectRegistry } from '../../AppObjectRegistry';
-import { assertAppAvailable, assertHandlerFunction, isPlainObject } from '../lib/assertions';
 import { AppAccessorsInstance } from '../../lib/accessors/mod';
 import { RequestContext } from '../../lib/requestContext';
 import { wrapAppForRequest } from '../../lib/wrapAppForRequest';
+import { assertAppAvailable, assertHandlerFunction, isPlainObject } from '../lib/assertions';
 
 export const uploadEvents = ['executePreFileUpload'] as const;
 
@@ -27,8 +29,11 @@ function assertString(v: unknown): asserts v is string {
 }
 
 export default async function handleUploadEvents(request: RequestContext): Promise<Defined | JsonRpcError> {
-	const { method: rawMethod, params } = request as { method: `app:${typeof uploadEvents[number]}`; params: [{ file?: IUploadDetails, path?: string }]};
-	const [, method] = rawMethod.split(':') as ['app', typeof uploadEvents[number]];
+	const { method: rawMethod, params } = request as {
+		method: `app:${(typeof uploadEvents)[number]}`;
+		params: [{ file?: IUploadDetails; path?: string }];
+	};
+	const [, method] = rawMethod.split(':') as ['app', (typeof uploadEvents)[number]];
 
 	try {
 		const [{ file, path }] = params;
@@ -41,30 +46,25 @@ export default async function handleUploadEvents(request: RequestContext): Promi
 		assertIsUpload(file);
 		assertString(path);
 
-		const tempFile = await open(path, 'r');
-
-		try {
-			let context: IFileUploadContext;
+		let context: IFileUploadContext;
 
-			switch (method) {
-				case 'executePreFileUpload': {
-					context = { file, content: await tempFile.readFile() };
-					break;
-				}
+		switch (method) {
+			case 'executePreFileUpload': {
+				const fileContents = await readFile(path);
+				context = { file, content: Buffer.from(fileContents) };
+				break;
 			}
-
-			return await handlerFunction.call(
-				wrapAppForRequest(app, request),
-				context,
-				AppAccessorsInstance.getReader(),
-				AppAccessorsInstance.getHttp(),
-				AppAccessorsInstance.getPersistence(),
-				AppAccessorsInstance.getModifier(),
-			);
-		} finally {
-			await tempFile.close();
 		}
-	} catch(e) {
+
+		return await handlerFunction.call(
+			wrapAppForRequest(app, request),
+			context,
+			AppAccessorsInstance.getReader(),
+			AppAccessorsInstance.getHttp(),
+			AppAccessorsInstance.getPersistence(),
+			AppAccessorsInstance.getModifier(),
+		);
+	} catch (e) {
 		if (e?.name === AppsEngineException.name) {
 			return new JsonRpcError(e.message, AppsEngineException.JSONRPC_ERROR_CODE, { name: e.name });
 		}

packages/apps/deno-runtime/handlers/app/handleUploadEvents.ts

@@ -1,210 +1,16 @@
-import { v1 as uuid } from 'uuid';
-
-import type {
-	IActionsBlock,
-	IBlock,
-	IConditionalBlock,
-	IConditionalBlockFilters,
-	IContextBlock,
-	IImageBlock,
-	IInputBlock,
-	ISectionBlock,
-} from '@rocket.chat/apps-engine/definition/uikit/blocks/Blocks';
-import { BlockType } from '@rocket.chat/apps-engine/definition/uikit/blocks/Blocks';
-import type {
-	IBlockElement,
-	IButtonElement,
-	IImageElement,
-	IInputElement,
-	IInteractiveElement,
-	IMultiStaticSelectElement,
-	IOverflowMenuElement,
-	IPlainTextInputElement,
-	ISelectElement,
-	IStaticSelectElement,
-} from '@rocket.chat/apps-engine/definition/uikit/blocks/Elements';
-import { BlockElementType } from '@rocket.chat/apps-engine/definition/uikit/blocks/Elements';
-import { TextObjectType, type ITextObject } from '@rocket.chat/apps-engine/definition/uikit/blocks/Objects';
+import { BlockBuilder as AppsEngineBlockBuilder } from '@rocket.chat/apps-engine/definition/uikit/blocks/BlockBuilder';
 
 import { AppObjectRegistry } from '../../../AppObjectRegistry';
 
-type BlockFunctionParameter<T extends IBlock> = Omit<T, 'type'>;
-type ElementFunctionParameter<T extends IBlockElement> = T extends IInteractiveElement ? Omit<T, 'type' | 'actionId'> | Partial<Pick<T, 'actionId'>>
-	: Omit<T, 'type'>;
-
-type SectionBlockParam = BlockFunctionParameter<ISectionBlock>;
-type ImageBlockParam = BlockFunctionParameter<IImageBlock>;
-type ActionsBlockParam = BlockFunctionParameter<IActionsBlock>;
-type ContextBlockParam = BlockFunctionParameter<IContextBlock>;
-type InputBlockParam = BlockFunctionParameter<IInputBlock>;
-
-type ButtonElementParam = ElementFunctionParameter<IButtonElement>;
-type ImageElementParam = ElementFunctionParameter<IImageElement>;
-type OverflowMenuElementParam = ElementFunctionParameter<IOverflowMenuElement>;
-type PlainTextInputElementParam = ElementFunctionParameter<IPlainTextInputElement>;
-type StaticSelectElementParam = ElementFunctionParameter<IStaticSelectElement>;
-type MultiStaticSelectElementParam = ElementFunctionParameter<IMultiStaticSelectElement>;
-
 /**
+ * Local BlockBuilder that extends the apps-engine BlockBuilder.
+ * It overrides the constructor to source the appId from the registry
+ * instead of requiring it as a constructor argument.
+ *
  * @deprecated please prefer the rocket.chat/ui-kit components
  */
-export class BlockBuilder {
-	private readonly blocks: Array<IBlock>;
-	private readonly appId: string;
-
+export class BlockBuilder extends AppsEngineBlockBuilder {
 	constructor() {
-		this.blocks = [];
-		this.appId = String(AppObjectRegistry.get('id'));
-	}
-
-	public addSectionBlock(block: SectionBlockParam): BlockBuilder {
-		this.addBlock({ type: BlockType.SECTION, ...block } as ISectionBlock);
-
-		return this;
-	}
-
-	public addImageBlock(block: ImageBlockParam): BlockBuilder {
-		this.addBlock({ type: BlockType.IMAGE, ...block } as IImageBlock);
-
-		return this;
-	}
-
-	public addDividerBlock(): BlockBuilder {
-		this.addBlock({ type: BlockType.DIVIDER });
-
-		return this;
-	}
-
-	public addActionsBlock(block: ActionsBlockParam): BlockBuilder {
-		this.addBlock({ type: BlockType.ACTIONS, ...block } as IActionsBlock);
-
-		return this;
-	}
-
-	public addContextBlock(block: ContextBlockParam): BlockBuilder {
-		this.addBlock({ type: BlockType.CONTEXT, ...block } as IContextBlock);
-
-		return this;
-	}
-
-	public addInputBlock(block: InputBlockParam): BlockBuilder {
-		this.addBlock({ type: BlockType.INPUT, ...block } as IInputBlock);
-
-		return this;
-	}
-
-	public addConditionalBlock(innerBlocks: BlockBuilder | Array<IBlock>, condition?: IConditionalBlockFilters): BlockBuilder {
-		const render = innerBlocks instanceof BlockBuilder ? innerBlocks.getBlocks() : innerBlocks;
-
-		this.addBlock({
-			type: BlockType.CONDITIONAL,
-			render,
-			when: condition,
-		} as IConditionalBlock);
-
-		return this;
-	}
-
-	public getBlocks() {
-		return this.blocks;
-	}
-
-	public newPlainTextObject(text: string, emoji = false): ITextObject {
-		return {
-			type: TextObjectType.PLAINTEXT,
-			text,
-			emoji,
-		};
-	}
-
-	public newMarkdownTextObject(text: string): ITextObject {
-		return {
-			type: TextObjectType.MARKDOWN,
-			text,
-		};
-	}
-
-	public newButtonElement(info: ButtonElementParam): IButtonElement {
-		return this.newInteractiveElement({
-			type: BlockElementType.BUTTON,
-			...info,
-		} as IButtonElement);
-	}
-
-	public newImageElement(info: ImageElementParam): IImageElement {
-		return {
-			type: BlockElementType.IMAGE,
-			...info,
-		};
-	}
-
-	public newOverflowMenuElement(info: OverflowMenuElementParam): IOverflowMenuElement {
-		return this.newInteractiveElement({
-			type: BlockElementType.OVERFLOW_MENU,
-			...info,
-		} as IOverflowMenuElement);
-	}
-
-	public newPlainTextInputElement(info: PlainTextInputElementParam): IPlainTextInputElement {
-		return this.newInputElement({
-			type: BlockElementType.PLAIN_TEXT_INPUT,
-			...info,
-		} as IPlainTextInputElement);
-	}
-
-	public newStaticSelectElement(info: StaticSelectElementParam): IStaticSelectElement {
-		return this.newSelectElement({
-			type: BlockElementType.STATIC_SELECT,
-			...info,
-		} as IStaticSelectElement);
-	}
-
-	public newMultiStaticElement(info: MultiStaticSelectElementParam): IMultiStaticSelectElement {
-		return this.newSelectElement({
-			type: BlockElementType.MULTI_STATIC_SELECT,
-			...info,
-		} as IMultiStaticSelectElement);
-	}
-
-	private newInteractiveElement<T extends IInteractiveElement>(element: T): T {
-		if (!element.actionId) {
-			element.actionId = this.generateActionId();
-		}
-
-		return element;
-	}
-
-	private newInputElement<T extends IInputElement>(element: T): T {
-		if (!element.actionId) {
-			element.actionId = this.generateActionId();
-		}
-
-		return element;
-	}
-
-	private newSelectElement<T extends ISelectElement>(element: T): T {
-		if (!element.actionId) {
-			element.actionId = this.generateActionId();
-		}
-
-		return element;
-	}
-
-	private addBlock(block: IBlock): void {
-		if (!block.blockId) {
-			block.blockId = this.generateBlockId();
-		}
-
-		block.appId = this.appId;
-
-		this.blocks.push(block);
-	}
-
-	private generateBlockId(): string {
-		return uuid();
-	}
-
-	private generateActionId(): string {
-		return uuid();
+		super(String(AppObjectRegistry.get('id') ?? ''));
 	}
 }