feat(apps): adapt apps package to accept node-runtime

refactor(apps): make NodeSubprocessController use the BaseSubprocessController

Author: d-gubert

packages/apps/src/server/managers/AppRuntimeManager.ts

@@ -2,6 +2,7 @@ import type { AppManager } from '../AppManager';
 import type { IParseAppPackageResult } from '../compiler';
 import type { IRuntimeController } from '../runtime/IRuntimeController';
 import { DenoRuntimeSubprocessController } from '../runtime/deno/AppsEngineDenoRuntime';
+import { NodeRuntimeSubprocessController } from '../runtime/node/AppsEngineNodeRuntime';
 import type { IAppStorageItem } from '../storage';
 
 export type AppRuntimeParams = {
@@ -18,9 +19,16 @@ export type ExecRequestOptions = {
 	timeout?: number;
 };
 
-const defaultRuntimeFactory = (manager: AppManager, appPackage: IParseAppPackageResult, storageItem: IAppStorageItem) =>
+const { APPS_ENGINE_RUNTIME_BACKEND = 'deno' } = process.env;
+
+export const nodeRuntimeFactory = (manager: AppManager, appPackage: IParseAppPackageResult, storageItem: IAppStorageItem) =>
+	new NodeRuntimeSubprocessController(manager, appPackage, storageItem);
+
+export const denoRuntimeFactory = (manager: AppManager, appPackage: IParseAppPackageResult, storageItem: IAppStorageItem) =>
 	new DenoRuntimeSubprocessController(manager, appPackage, storageItem);
 
+const defaultRuntimeFactory = APPS_ENGINE_RUNTIME_BACKEND === 'node' ? nodeRuntimeFactory : denoRuntimeFactory;
+
 export class AppRuntimeManager {
 	private readonly subprocesses: Record<string, IRuntimeController> = {};
 

packages/apps/src/server/runtime/AppsEngineNodeRuntime.ts

@@ -0,0 +1,43 @@
+import * as path from 'node:path';
+
+import type { AppManager } from '../../AppManager';
+import type { IParseAppPackageResult } from '../../compiler';
+import type { IAppStorageItem } from '../../storage';
+import { BaseRuntimeSubprocessController, type ProcessConfiguration } from '../base/BaseRuntimeSubprocessController';
+
+export class NodeRuntimeSubprocessController extends BaseRuntimeSubprocessController {
+	private readonly nodeBin = 'node';
+
+	private readonly scriptRuntimePath: string;
+
+	constructor(manager: AppManager, appPackage: IParseAppPackageResult, storageItem: IAppStorageItem) {
+		super('node', manager, appPackage, storageItem);
+
+		this.scriptRuntimePath = require.resolve('../../../../node-runtime/dist/main.js');
+	}
+
+	protected buildProcessConfiguration(): ProcessConfiguration {
+		const allowedDirs = [this.tempFilePath, path.resolve(path.dirname(this.scriptRuntimePath), '..', '..'), this.appsEnginePath];
+
+		const args = [
+			'--permission',
+			...allowedDirs.map((dir) => `--allow-fs-read=${dir}`),
+			this.scriptRuntimePath,
+			'--subprocess',
+			this.appPackage.info.id,
+			'--spawnId',
+			String(this.spawnId++),
+		];
+
+		// SECURITY: We control the command, the arguments and the script that will be executed.
+		return {
+			command: this.nodeBin,
+			args,
+			options: {
+				env: {
+					PATH: process.env.PATH,
+				},
+			},
+		};
+	}
+}