refactor(models): remove unnecessary JSDoc comment

Author: tassoevan

apps/meteor/app/api/server/v1/roles.ts

@@ -38,10 +38,24 @@ const rolesRoutes = API.v1
 		{
 			authRequired: true,
 			response: {
-				200: ajv.compile<{ roles: IRole[] }>({
+				200: ajv.compile<{ roles: Omit<IRole, '_updatedAt'>[] }>({
 					type: 'object',
 					properties: {
-						roles: { type: 'array', items: { $ref: '#/components/schemas/IRole' } },
+						roles: {
+							type: 'array',
+							items: {
+								type: 'object',
+								properties: {
+									_id: { type: 'string' },
+									description: { type: 'string' },
+									mandatory2fa: { type: 'boolean' },
+									name: { type: 'string' },
+									protected: { type: 'boolean' },
+									scope: { type: 'string', enum: ['Users', 'Subscriptions'] },
+								},
+								required: ['_id', 'description', 'name', 'protected', 'scope'],
+							},
+						},
 						success: { type: 'boolean', enum: [true] },
 					},
 					required: ['roles', 'success'],
@@ -187,9 +201,9 @@ const rolesRoutes = API.v1
 			}
 
 			const { cursor, totalCount } = await getUsersInRolePaginated(roleData._id, roomId, {
-				limit: count as number,
+				limit: count,
 				sort: { username: 1 },
-				skip: offset as number,
+				skip: offset,
 				projection,
 			});
 

apps/meteor/app/custom-sounds/server/lib/insertOrUpdateSound.ts

@@ -51,13 +51,10 @@ export const insertOrUpdateSound = async (soundData: ICustomSoundData): Promise<
 
 	if (soundData.name !== soundData.previousName || soundData.extension !== soundData.previousExtension) {
 		await CustomSounds.updateById(soundData._id, { name: soundData.name, extension: soundData.extension });
-		void api.broadcast('notify.updateCustomSound', {
-			soundData: {
-				_id: soundData._id,
-				name: soundData.name,
-				extension: soundData.extension,
-			},
-		});
+		const updatedSound = await CustomSounds.findOneById(soundData._id);
+		if (updatedSound) {
+			void api.broadcast('notify.updateCustomSound', { soundData: updatedSound });
+		}
 	}
 
 	return soundData._id;

apps/meteor/app/custom-sounds/server/lib/uploadCustomSound.ts

@@ -1,5 +1,6 @@
 import { api } from '@rocket.chat/core-services';
 import type { RequiredField } from '@rocket.chat/core-typings';
+import { CustomSounds } from '@rocket.chat/models';
 
 import { RocketChatFile } from '../../../file/server';
 import type { ICustomSoundData } from '../methods/insertOrUpdateSound';
@@ -29,7 +30,12 @@ export const uploadCustomSound = async (
 		});
 
 		ws.on('end', () => {
-			setTimeout(() => api.broadcast('notify.updateCustomSound', { soundData }), 500);
+			setTimeout(async () => {
+				const sound = await CustomSounds.findOneById(soundData._id);
+				if (sound) {
+					void api.broadcast('notify.updateCustomSound', { soundData: sound });
+				}
+			}, 500);
 			resolve();
 		});
 

packages/models/src/models/LivechatRooms.ts

@@ -34,9 +34,6 @@ import type { Updater } from '../updater';
 import { BaseRaw } from './BaseRaw';
 import { readSecondaryPreferred } from '../readSecondaryPreferred';
 
-/**
- * @extends BaseRaw<ILivechatRoom>
- */
 export class LivechatRoomsRaw extends BaseRaw<IOmnichannelRoom> implements ILivechatRoomsModel {
 	constructor(db: Db, trash?: Collection<RocketChatRecordDeleted<IOmnichannelRoom>>) {
 		super(db, 'room', trash);