chore(ci): add dedicated CI step for node-runtime tests

Author: d-gubert

.github/workflows/ci-test-e2e.yml

@@ -167,7 +167,7 @@ jobs:
         run: echo "DEBUG_LOG_LEVEL=2" >> "$GITHUB_ENV"
 
       - name: Start httpbin container and wait for it to be ready
-        if: inputs.type == 'api' || inputs.type == 'api-livechat'
+        if: startsWith(inputs.type, 'api')
         run: |
           docker compose -f docker-compose-ci.yml up -d httpbin
 
@@ -186,7 +186,7 @@ jobs:
           # behavior on (rate-limiter bypass, short cache TTLs) while letting
           # the deprecation logger log without throwing. Other suites use the
           # docker-compose default of TEST_MODE='true'.
-          TEST_MODE: ${{ (inputs.type == 'api' || inputs.type == 'api-livechat') && 'api' || 'true' }}
+          TEST_MODE: ${{ startsWith(inputs.type, 'api') && 'api' || 'true' }}
         run: |
           # when we are testing CE, we only need to start the rocketchat container
           DEBUG_LOG_LEVEL=${DEBUG_LOG_LEVEL:-0} docker compose -f docker-compose-ci.yml up -d rocketchat --wait
@@ -197,7 +197,8 @@ jobs:
           ENTERPRISE_LICENSE: ${{ inputs.enterprise-license }}
           TRANSPORTER: ${{ inputs.transporter }}
           COMPOSE_PROFILES: ${{ inputs.type == 'api' && 'api' || '' }}
-          TEST_MODE: ${{ (inputs.type == 'api' || inputs.type == 'api-livechat') && 'api' || 'true' }}
+          TEST_MODE: ${{ startsWith(inputs.type, 'api') && 'api' || 'true' }}
+          APPS_ENGINE_RUNTIME_BACKEND: ${{ inputs.type == 'api-apps-node' && 'node' || '' }}
         run: |
           DEBUG_LOG_LEVEL=${DEBUG_LOG_LEVEL:-0} docker compose -f docker-compose-ci.yml up -d --wait
 
@@ -234,6 +235,23 @@ jobs:
           ls -la "$COVERAGE_DIR"
           exit "${s:-0}"
 
+      # This step should be temporary, only here until we remove the deno-runtime
+      - name: E2E Test API (apps + node-runtime)
+        if: (inputs.type == 'api-apps-node' && inputs.release == 'ee')
+        working-directory: ./apps/meteor
+        env:
+          WEBHOOK_TEST_URL: 'http://httpbin'
+          IS_EE: 'true'
+        run: |
+          set -o xtrace
+
+          npm run testapi:apps || s=$?
+
+          docker compose -f ../../docker-compose-ci.yml stop
+
+          ls -la "$COVERAGE_DIR"
+          exit "${s:-0}"
+
       - name: E2E Test API (Livechat)
         if: inputs.type == 'api-livechat'
         working-directory: ./apps/meteor

.github/workflows/ci.yml

@@ -657,6 +657,27 @@ jobs:
       CR_PAT: ${{ secrets.CR_PAT }}
       NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
 
+  test-api-apps-node-ee:
+    name: 🔨 Test API Apps (node-runtime - EE)
+    needs: [checks, build-gh-docker-publish, release-versions]
+
+    uses: ./.github/workflows/ci-test-e2e.yml
+    with:
+      type: api-apps-node
+      release: ee
+      transporter: 'nats://nats:4222'
+      enterprise-license: ${{ needs.release-versions.outputs.enterprise-license }}
+      mongodb-version: "['8.0']"
+      coverage: '8.0'
+      node-version: ${{ needs.release-versions.outputs.node-version }}
+      deno-version: ${{ needs.release-versions.outputs.deno-version }}
+      lowercase-repo: ${{ needs.release-versions.outputs.lowercase-repo }}
+      gh-docker-tag: ${{ needs.release-versions.outputs.gh-docker-tag }}
+    secrets:
+      CR_USER: ${{ secrets.CR_USER }}
+      CR_PAT: ${{ secrets.CR_PAT }}
+      NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+
   test-ui-ee:
     name: 🔨 Test UI (EE)
     needs: [checks, build-gh-docker-publish, release-versions]

apps/meteor/.mocharc.api.apps.js

@@ -0,0 +1,15 @@
+'use strict';
+
+/*
+ * Mocha configuration for REST API integration tests.
+ */
+
+module.exports = /** @satisfies {import('mocha').MochaOptions} */ ({
+	...require('./.mocharc.base.json'), // see https://github.com/mochajs/mocha/issues/3916
+	timeout: 10000,
+	bail: false,
+	retries: 0,
+	file: 'tests/end-to-end/teardown.ts',
+	reporter: 'tests/end-to-end/reporter.ts',
+	spec: ['tests/end-to-end/apps/*'],
+});

apps/meteor/package.json

@@ -56,6 +56,7 @@
 		"test:e2e:nyc": "nyc report --reporter=lcovonly",
 		"testapi": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\"}' mocha --config ./.mocharc.api.js",
 		"testapi:livechat": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\"}' mocha --config ./.mocharc.api.livechat.js",
+		"testapi:apps": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\"}' mocha --config ./.mocharc.api.apps.js",
 		"testunit": "yarn .testunit:definition && yarn .testunit:jest && yarn .testunit:server:cov",
 		"testunit-watch": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\"}' mocha --watch --config ./.mocharc.js",
 		"typecheck": "meteor lint && cross-env NODE_OPTIONS=\"--max-old-space-size=8192\" tsc --noEmit --skipLibCheck",

docker-compose-ci.yml

@@ -14,6 +14,7 @@ services:
     image: ghcr.io/${LOWERCASE_REPOSITORY}/rocket.chat:${DOCKER_TAG}${DOCKER_TAG_SUFFIX_ROCKETCHAT:-}
     environment:
       - 'TEST_MODE=${TEST_MODE:-true}'
+      - APPS_ENGINE_RUNTIME_BACKEND=${APPS_ENGINE_RUNTIME_BACKEND:-}
       - DEBUG=${DEBUG:-}
       - EXIT_UNHANDLEDPROMISEREJECTION=true
       - MONGO_URL=mongodb://mongo:27017/rocketchat?replicaSet=rs0