Skip to content

Commit dbcab50

Browse files
committed
apply apps-engine lint rules to apps
1 parent 76e691f commit dbcab50

3 files changed

Lines changed: 13 additions & 6 deletions

File tree

eslint.config.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ export default [
289289
},
290290
},
291291
{
292-
files: ['packages/apps-engine/**/*'],
292+
files: ['packages/apps-engine/**/*', 'packages/apps/**/*'],
293293
rules: {
294294
'@typescript-eslint/no-empty-object-type': 'off',
295295
'@typescript-eslint/no-unnecessary-type-assertion': 'off', // this rule does not deal well with assertions that remove `undefined` from the type
@@ -345,7 +345,7 @@ export default [
345345
},
346346
},
347347
{
348-
ignores: ['packages/apps-engine/@(client|definition|docs|server|lib|deno-runtime|.deno|.deno-cache)'],
348+
ignores: ['packages/@(apps|apps-engine)/@(client|definition|docs|server|lib|deno-runtime|.deno|.deno-cache)'],
349349
},
350350
{
351351
files: ['packages/core-typings/**/*'],

packages/apps/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
"test:node": "NODE_ENV=test node --require ts-node/register/transpile-only --test-reporter spec --test \"tests/**/*.test.ts\""
2222
},
2323
"dependencies": {
24+
"@msgpack/msgpack": "3.0.0-beta2",
2425
"@rocket.chat/apps-engine": "workspace:^",
2526
"@rocket.chat/core-typings": "workspace:^",
2627
"@rocket.chat/model-typings": "workspace:^",
27-
"@msgpack/msgpack": "3.0.0-beta2",
2828
"adm-zip": "^0.5.16",
2929
"debug": "^4.3.7",
3030
"esbuild": "~0.27.3",

yarn.lock

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5307,6 +5307,13 @@ __metadata:
53075307
languageName: node
53085308
linkType: hard
53095309

5310+
"@msgpack/msgpack@npm:3.0.0-beta2":
5311+
version: 3.0.0-beta2
5312+
resolution: "@msgpack/msgpack@npm:3.0.0-beta2"
5313+
checksum: 10/d02f9221aa152cbd2977d1f56dc591baa2a37420a694cbc7e54ff0724f56ac0523e94de010e56bb845d67a1f2226c1761064b5777e63e9fc26884f4144d391a7
5314+
languageName: node
5315+
linkType: hard
5316+
53105317
"@msgpack/msgpack@npm:3.0.1":
53115318
version: 3.0.1
53125319
resolution: "@msgpack/msgpack@npm:3.0.1"
@@ -13670,7 +13677,7 @@ __metadata:
1367013677
languageName: node
1367113678
linkType: hard
1367213679

13673-
"@types/adm-zip@npm:^0.5.8":
13680+
"@types/adm-zip@npm:^0.5.7, @types/adm-zip@npm:^0.5.8":
1367413681
version: 0.5.8
1367513682
resolution: "@types/adm-zip@npm:0.5.8"
1367613683
dependencies:
@@ -14229,7 +14236,7 @@ __metadata:
1422914236
languageName: node
1423014237
linkType: hard
1423114238

14232-
"@types/debug@npm:^4.1.13":
14239+
"@types/debug@npm:^4.1.12, @types/debug@npm:^4.1.13":
1423314240
version: 4.1.13
1423414241
resolution: "@types/debug@npm:4.1.13"
1423514242
dependencies:
@@ -21522,7 +21529,7 @@ __metadata:
2152221529
languageName: node
2152321530
linkType: hard
2152421531

21525-
"esbuild@npm:~0.27.0, esbuild@npm:~0.27.7":
21532+
"esbuild@npm:~0.27.0, esbuild@npm:~0.27.3, esbuild@npm:~0.27.7":
2152621533
version: 0.27.7
2152721534
resolution: "esbuild@npm:0.27.7"
2152821535
dependencies:

0 commit comments

Comments
 (0)