Skip to content

fix: remove corrupted and duplicate entries in emailDomainDefaultBlackList#40019

Open
manasvi30 wants to merge 3 commits intoRocketChat:developfrom
manasvi30:fix/email-blocklist-corrupted-entries
Open

fix: remove corrupted and duplicate entries in emailDomainDefaultBlackList#40019
manasvi30 wants to merge 3 commits intoRocketChat:developfrom
manasvi30:fix/email-blocklist-corrupted-entries

Conversation

@manasvi30
Copy link
Copy Markdown

@manasvi30 manasvi30 commented Apr 1, 2026

Fixes corrupted entries in emailDomainDefaultBlackList.

Closes #40018

Changes made

  • Removed 3 fused entries where two domain names were merged into one string
  • Fixed truncated entry viewcastmediaeviewcastmedia.eu
  • Removed 2 duplicate entries
  • Added unit tests to prevent regression

Before fix:

Screenshot 2026-04-01 at 15 55 03

###After fix:
image

Type of change

  • Bug fix

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the default email domain blocklist by removing malformed and duplicate entries and fixing corrupted domain names.
    • Replaced problematic entries with corrected domains (example.com, dupmyspace.com, viewcastmedia.eu) to improve blocklist accuracy and spam filtering reliability.
    • Published as a patch release entry.

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 1, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 1, 2026

🦋 Changeset detected

Latest commit: 3c52461

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/abac Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/server-fetch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e39cc55d-5c14-4050-aef7-16e8cd8bf444

📥 Commits

Reviewing files that changed from the base of the PR and between 17c46ed and 1945abb.

📒 Files selected for processing (1)
  • .changeset/clean-terms-sit.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/clean-terms-sit.md
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: cubic · AI code reviewer

Walkthrough

Cleaned corrupted, duplicate, and malformed entries in the email domain blacklist and added a changeset to publish a patch for the package.

Changes

Cohort / File(s) Summary
Email Domain Blacklist Cleanup
apps/meteor/app/lib/server/lib/defaultBlockedDomainsList.ts
Removed fused/invalid entries, removed duplicates, corrected truncated/malformed domains, and added corrected domains (example.com, dupmyspace.com, viewcastmedia.eu).
Release Changeset
.changeset/clean-terms-sit.md
Added a changeset entry to publish a patch documenting the blacklist cleanup.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

type: bug

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title directly and accurately describes the main change: removing corrupted and duplicate entries from the emailDomainDefaultBlackList.
Linked Issues check ✅ Passed The PR successfully addresses all key objectives: removed 3 fused entries, fixed the truncated entry (viewcastmediae → viewcastmedia.eu), and removed 2 duplicates.
Out of Scope Changes check ✅ Passed All changes are within scope: the PR modifies only the blacklist array and adds a changelog entry, both directly related to issue #40018.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@manasvi30 manasvi30 changed the title correct fused, truncated and duplicate entries in emailDomainDefaultB… fix: remove corrupted and duplicate entries in emailDomainDefaultBlackList Apr 1, 2026
@coderabbitai coderabbitai bot removed the type: bug label Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

corrupted entries in emailDomainDefaultBlackList (fused, truncated, duplicates)

1 participant