fix: use i18n key for RoleForm description hint text #40177
fix: use i18n key for RoleForm description hint text #40177dionisio-bot[bot] merged 4 commits intoRocketChat:developfrom
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
WalkthroughUpdated a field hint in the Role Form to use a localization function instead of hardcoded English text. This change applies translation support to the Description field's hint message. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/jira COMM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #40177 +/- ##
===========================================
- Coverage 70.13% 70.04% -0.09%
===========================================
Files 3284 3284
Lines 117428 117428
Branches 20757 20784 +27
===========================================
- Hits 82361 82258 -103
- Misses 31781 31861 +80
- Partials 3286 3309 +23
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@Naetiksoni08 stop merging it mate, let the merge queue handle it! |
d9f4c86
Proposed changes (including videos or screenshots)
The hint text below the Description field in the Role form (
Admin > Permissions > New Role) was hardcoded as a plainEnglish string instead of using the i18n translation system.
Problems:
their selected language
dontinstead ofdon'tBefore:
After:
The translation key Leave_the_description_field_blank_if_you_dont_want_to_show_the_role already exists in the i18n package for all supported languages including pt-BR, de, es, ko, zh, ja and more — it was just never being used.
Before Fix: (I changed the language to portuguese to Confirm the bug)
The line "Leave the description field blank if you dont want to show the role" was Hardcoded and had a typo.
After Fix:
Steps to test or reproduce
show the role"
Further comments
The translation key was already present and fully translated across all supported languages in the i18n package. This was a
one-line fix to wire it up correctly in the component.
Summary by CodeRabbit
Task: COMM-149