feat(apps): apps-engine split, remove old files#40343
feat(apps): apps-engine split, remove old files#40343d-gubert wants to merge 13 commits intofeat/apps-engine-split--pr2c-flip-the-switchfrom
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Strip @rocket.chat/apps-engine down to the definition layer only. All runtime code (AppManager, bridges, compiler, deno-runtime, etc.) has already been moved to @rocket.chat/apps in previous commits. Updates package.json, tsconfig.json, and turbo.json to reflect the narrower scope (definition/** and lib/** outputs only). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
These files were already moved to @rocket.chat/apps/src/client but were not deleted from apps-engine in the previous cleanup commit. They caused TypeScript build errors because their dependencies (constants, utils, definition sub-files) had been removed. Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com>
These files were already moved to @rocket.chat/apps/src/server but were not deleted from apps-engine in the previous cleanup commit. They caused TypeScript build errors because many of their dependencies (bridges, managers, errors, storage types, etc.) had been removed from apps-engine. Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com>
a81d286 to
a908c44
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/apps-engine-split--pr2c-flip-the-switch #40343 +/- ##
================================================================================
- Coverage 69.83% 69.82% -0.02%
================================================================================
Files 3297 3297
Lines 119268 119268
Branches 21513 21492 -21
================================================================================
- Hits 83292 83275 -17
- Misses 32673 32686 +13
- Partials 3303 3307 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments