Skip to content

feat(apps): apps-engine split, remove old files#40343

Draft
d-gubert wants to merge 13 commits intofeat/apps-engine-split--pr2c-flip-the-switchfrom
feat/apps-engine-split--pr2d-remove-apps-engine-files
Draft

feat(apps): apps-engine split, remove old files#40343
d-gubert wants to merge 13 commits intofeat/apps-engine-split--pr2c-flip-the-switchfrom
feat/apps-engine-split--pr2d-remove-apps-engine-files

Conversation

@d-gubert
Copy link
Copy Markdown
Member

  • refactor(apps-engine): remove server, client, deno-runtime and scripts
  • refactor(apps-engine): remove stale src/client files
  • refactor(apps-engine): remove stale src/server files
  • remove apps-engine exports from package.json
  • update yarn.lock
  • refactor: re add uuid as a dependency of apps-engine
  • refactor(apps-engine): package json
  • fix: ci failing when trying to delete previous apps-engine files
  • remove apps-engine tests
  • fix: remove apps-engine copying from Dockerfiles
  • refactor: remove remaining apps-engine deno-runtime files
  • fix(apps-engine): prevent manual version bump

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Apr 30, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 30, 2026

⚠️ No Changeset found

Latest commit: aff63fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e292c1e0-217d-4c99-b32f-c9b81b1f3d57

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

d-gubert and others added 11 commits April 30, 2026 13:16
Strip @rocket.chat/apps-engine down to the definition layer only.
All runtime code (AppManager, bridges, compiler, deno-runtime, etc.)
has already been moved to @rocket.chat/apps in previous commits.

Updates package.json, tsconfig.json, and turbo.json to reflect the
narrower scope (definition/**  and lib/** outputs only).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
These files were already moved to @rocket.chat/apps/src/client but were
not deleted from apps-engine in the previous cleanup commit. They caused
TypeScript build errors because their dependencies (constants, utils,
definition sub-files) had been removed.

Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com>
These files were already moved to @rocket.chat/apps/src/server but were
not deleted from apps-engine in the previous cleanup commit. They caused
TypeScript build errors because many of their dependencies (bridges,
managers, errors, storage types, etc.) had been removed from apps-engine.

Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com>
@d-gubert d-gubert force-pushed the feat/apps-engine-split--pr2d-remove-apps-engine-files branch from a81d286 to a908c44 Compare April 30, 2026 16:16
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.82%. Comparing base (6bc4e83) to head (aff63fd).

Additional details and impacted files

Impacted file tree graph

@@                               Coverage Diff                                @@
##           feat/apps-engine-split--pr2c-flip-the-switch   #40343      +/-   ##
================================================================================
- Coverage                                         69.83%   69.82%   -0.02%     
================================================================================
  Files                                              3297     3297              
  Lines                                            119268   119268              
  Branches                                          21513    21492      -21     
================================================================================
- Hits                                              83292    83275      -17     
- Misses                                            32673    32686      +13     
- Partials                                           3303     3307       +4     
Flag Coverage Δ
e2e 59.71% <ø> (+<0.01%) ⬆️
e2e-api 46.21% <ø> (-0.03%) ⬇️
unit 70.58% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants