Skip to content

test: align system-messages MultiSelect with new fuselage a11y #40357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 1 commit into from
May 1, 2026
+7 −1
Merged

test: align system-messages MultiSelect with new fuselage a11y #40357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/edit-room-info-multiselect-aria-label.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Adds an accessible label to the system-messages multi-select in the channel edit panel so screen readers announce its purpose.
2 changes: 1 addition & 1 deletion apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const removeSystemMessageChip = async (translationKey: string) => {
};

const selectSystemMessageOption = async (translationKey: string) => {
const trigger = screen.getByRole('button', { name: /Select messages to hide/i });
const trigger = screen.getByRole('combobox', { name: /Select messages to hide/i });
await userEvent.click(trigger);

const listboxes = await screen.findAllByRole('listbox', { hidden: true });
Expand Down
1 change: 1 addition & 0 deletions apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,7 @@ const EditRoomInfo = ({ room, onClickClose, onClickBack }: EditRoomInfoProps) =>
options={sysMesOptions}
disabled={!hideSysMes || isFederated}
placeholder={t('Select_messages_to_hide')}
aria-label={t('Select_messages_to_hide')}
/>
)}
/>
Expand Down
Loading