Skip to content

regression: apps semver validation broke with pre-release identifier #40643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 2 commits into from
May 21, 2026
Merged

regression: apps semver validation broke with pre-release identifier #40643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
824532c
fix: get the apps-engine version directly from the package.json file
d-gubert May 21, 2026
9793e92
chore: remove unused file
d-gubert May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions packages/apps-engine/src/definition/version.ts
View file
Open in desktop

This file was deleted.

8 changes: 6 additions & 2 deletions packages/apps/src/server/compiler/AppPackageParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { randomUUID } from 'node:crypto';
import * as path from 'node:path';

import type { IAppInfo } from '@rocket.chat/apps-engine/definition/metadata/IAppInfo';
import { ENGINE_VERSION } from '@rocket.chat/apps-engine/definition/version';
import { version } from '@rocket.chat/apps-engine/package.json';
import AdmZip from 'adm-zip';
import * as semver from 'semver';

Expand All @@ -15,7 +15,11 @@ export class AppPackageParser {

private allowedIconExts: Array<string> = ['.png', '.jpg', '.jpeg', '.gif'];

private appsEngineVersion: string = ENGINE_VERSION;
private readonly appsEngineVersion: string;

constructor() {
[this.appsEngineVersion] = version.split('-'); // In case there is a suffix like -dev, -rc.0, etc. We just want the version number for semver comparison
}
Comment thread
d-gubert marked this conversation as resolved.

public async unpackageApp(appPackage: Buffer): Promise<IParseAppPackageResult> {
const zip = new AdmZip(appPackage);
Expand Down
Loading