chore: Delegate user sync to PDP#40836
Merged
dionisio-bot[bot] merged 15 commits intoJun 9, 2026
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds AbacService.reevaluateUsers, PDP bulk reevaluation (Local and Virtru), LDAPEEService bridging, updates POST /abac/users/sync to call Abac.reevaluateUsers, and extends unit and E2E tests for reevaluation outcomes and room membership removals. ChangesABAC User Reevaluation Flow
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #40836 +/- ##
===========================================
+ Coverage 70.09% 70.15% +0.06%
===========================================
Files 3337 3342 +5
Lines 123509 123765 +256
Branches 22057 22120 +63
===========================================
+ Hits 86574 86830 +256
+ Misses 33594 33583 -11
- Partials 3341 3352 +11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
KevLehman
force-pushed
the
feat/abac-users-sync-strategy-agnostic
branch
from
31ddb84 to
8bba69c
Compare
coderabbitai
Bot
added
type: feature
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/packages/abac/src/index.ts`:
- Around line 979-981: The catch block that currently logs errors with
logger.error({ msg: 'Failed to reevaluate users', err }) swallows failures from
the reevaluation/removal flow so API-triggered sync can wrongly report success;
update the catch in ee/packages/abac/src/index.ts (the block that logs 'Failed
to reevaluate users') to re-throw the caught error after logging (or remove the
try/catch entirely) so the exception bubbles to callers and the API can surface
a failure.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a5df85b7-b809-40f1-8c80-bb6b76f8f8d0
📒 Files selected for processing (12)
apps/meteor/ee/server/api/abac/index.tsapps/meteor/ee/server/local-services/ldap/service.tsapps/meteor/tests/end-to-end/api/abac.tsee/packages/abac/src/index.tsee/packages/abac/src/pdp/LocalPDP.tsee/packages/abac/src/pdp/VirtruPDP.spec.tsee/packages/abac/src/pdp/VirtruPDP.tsee/packages/abac/src/pdp/types.tsee/packages/abac/src/service.spec.tspackages/core-services/src/types/IAbacService.tspackages/core-services/src/types/ILDAPEEService.tspackages/core-typings/src/Abac.ts
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: Hacktron Security Check
- GitHub Check: 🔨 Test UI (EE) / MongoDB 8.0 coverage (1/5)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
packages/core-typings/src/Abac.tspackages/core-services/src/types/IAbacService.tspackages/core-services/src/types/ILDAPEEService.tsee/packages/abac/src/pdp/types.tsapps/meteor/ee/server/local-services/ldap/service.tsapps/meteor/ee/server/api/abac/index.tsee/packages/abac/src/service.spec.tsee/packages/abac/src/index.tsee/packages/abac/src/pdp/LocalPDP.tsee/packages/abac/src/pdp/VirtruPDP.tsee/packages/abac/src/pdp/VirtruPDP.spec.tsapps/meteor/tests/end-to-end/api/abac.ts
**/*.spec.ts
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.spec.ts: Use descriptive test names that clearly communicate expected behavior in Playwright tests
Use.spec.tsextension for test files (e.g.,login.spec.ts)
Files:
ee/packages/abac/src/service.spec.tsee/packages/abac/src/pdp/VirtruPDP.spec.ts
🧠 Learnings (6)
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
packages/core-typings/src/Abac.tspackages/core-services/src/types/IAbacService.tspackages/core-services/src/types/ILDAPEEService.tsee/packages/abac/src/pdp/types.tsapps/meteor/ee/server/local-services/ldap/service.tsapps/meteor/ee/server/api/abac/index.tsee/packages/abac/src/service.spec.tsee/packages/abac/src/index.tsee/packages/abac/src/pdp/LocalPDP.tsee/packages/abac/src/pdp/VirtruPDP.tsee/packages/abac/src/pdp/VirtruPDP.spec.tsapps/meteor/tests/end-to-end/api/abac.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
packages/core-typings/src/Abac.tspackages/core-services/src/types/IAbacService.tspackages/core-services/src/types/ILDAPEEService.tsee/packages/abac/src/pdp/types.tsapps/meteor/ee/server/local-services/ldap/service.tsapps/meteor/ee/server/api/abac/index.tsee/packages/abac/src/service.spec.tsee/packages/abac/src/index.tsee/packages/abac/src/pdp/LocalPDP.tsee/packages/abac/src/pdp/VirtruPDP.tsee/packages/abac/src/pdp/VirtruPDP.spec.tsapps/meteor/tests/end-to-end/api/abac.ts
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
packages/core-typings/src/Abac.tspackages/core-services/src/types/IAbacService.tspackages/core-services/src/types/ILDAPEEService.tsee/packages/abac/src/pdp/types.tsapps/meteor/ee/server/local-services/ldap/service.tsapps/meteor/ee/server/api/abac/index.tsee/packages/abac/src/service.spec.tsee/packages/abac/src/index.tsee/packages/abac/src/pdp/LocalPDP.tsee/packages/abac/src/pdp/VirtruPDP.tsee/packages/abac/src/pdp/VirtruPDP.spec.tsapps/meteor/tests/end-to-end/api/abac.ts
📚 Learning: 2025-12-10T21:00:43.645Z
Learnt from: KevLehman
Repo: RocketChat/Rocket.Chat PR: 37091
File: ee/packages/abac/jest.config.ts:4-7
Timestamp: 2025-12-10T21:00:43.645Z
Learning: Adopt the monorepo-wide Jest testMatch pattern: <rootDir>/src/**/*.spec.{ts,js,mjs} (represented here as '**/src/**/*.spec.{ts,js,mjs}') to ensure spec files under any package's src directory are picked up consistently across all packages in the Rocket.Chat monorepo. Apply this pattern in jest.config.ts for all relevant packages to maintain uniform test discovery.
Applied to files:
ee/packages/abac/src/service.spec.tsee/packages/abac/src/pdp/VirtruPDP.spec.ts
📚 Learning: 2026-02-24T19:22:48.358Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/omnichannel/omnichannel-send-pdf-transcript.spec.ts:66-67
Timestamp: 2026-02-24T19:22:48.358Z
Learning: In Playwright end-to-end tests (e.g., under apps/meteor/tests/e2e/...), prefer locating elements by translated text (getByText) and ARIA roles (getByRole) over data-qa attributes. If translation values change, update the corresponding test locators accordingly. Never use data-qa locators. This guideline applies to all Playwright e2e test specs in the repository and helps keep tests robust to UI text changes and accessible semantics.
Applied to files:
ee/packages/abac/src/service.spec.tsee/packages/abac/src/pdp/VirtruPDP.spec.ts
📚 Learning: 2026-03-06T18:10:15.268Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 39397
File: packages/gazzodown/src/code/CodeBlock.spec.tsx:47-68
Timestamp: 2026-03-06T18:10:15.268Z
Learning: In tests (especially those using testing-library/dom/jsdom) for Rocket.Chat components, the HTML <code> element has an implicit ARIA role of 'code'. Therefore, screen.getByRole('code') or screen.findByRole('code') will locate <code> elements even without a role attribute. Do not flag findByRole('code') as invalid in reviews; prefer using the implicit role instead of adding role="code" unless necessary for accessibility.
Applied to files:
ee/packages/abac/src/service.spec.tsee/packages/abac/src/pdp/VirtruPDP.spec.ts
🔇 Additional comments (12)
packages/core-typings/src/Abac.ts (1)
17-22: LGTM!packages/core-services/src/types/ILDAPEEService.ts (1)
11-11: LGTM!ee/packages/abac/src/pdp/VirtruPDP.ts (1)
4-4: LGTM!Also applies to: 9-9, 354-378
ee/packages/abac/src/pdp/VirtruPDP.spec.ts (1)
473-503: LGTM!apps/meteor/ee/server/api/abac/index.ts (1)
2-2: LGTM!Also applies to: 5-5, 212-212, 228-228
apps/meteor/tests/end-to-end/api/abac.ts (1)
7-7: LGTM!Also applies to: 193-193, 1454-1463, 1846-1865, 2538-2538, 2568-2568, 2582-2582, 2596-2596, 2610-2610, 2624-2624, 2702-2702, 3459-3569, 4092-4092
ee/packages/abac/src/pdp/types.ts (1)
31-32: LGTM!Also applies to: 59-59
packages/core-services/src/types/IAbacService.ts (1)
10-10: LGTM!Also applies to: 53-53
ee/packages/abac/src/pdp/LocalPDP.ts (1)
1-1: LGTM!Also applies to: 7-7, 85-87
ee/packages/abac/src/index.ts (1)
15-15: LGTM!apps/meteor/ee/server/local-services/ldap/service.ts (1)
3-3: LGTM!Also applies to: 35-37
ee/packages/abac/src/service.spec.ts (1)
62-63: LGTM!Also applies to: 95-95, 122-124, 1993-2033
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 12 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
coderabbitai
Bot
added
type: chore
and removed
type: feature
![hacktron-app[bot]](https://avatars.githubusercontent.com/in/1250513?s=60&v=4){kind=small}
KevLehman
added
the
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
ricardogarim
reviewed
Jun 9, 2026
ricardogarim
previously approved these changes
Jun 9, 2026
ricardogarim
approved these changes
Jun 9, 2026
tassoevan
approved these changes
Jun 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/ABAC3-23
Steps to test or reproduce
Further comments
Summary by CodeRabbit
New Features
Tests