chore(apps): swap default runtime backend from deno to node by d-gubert · Pull Request #41474 · RocketChat/Rocket.Chat

d-gubert · 2026-07-20T11:03:15Z

feat(apps-engine): default runtime backend to node
ci: repurpose dedicated apps runtime job to test deno instead of node

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

New Features
- The default Apps runtime backend is now Node.js.
- Deno is still supported by setting APPS_ENGINE_RUNTIME_BACKEND='deno'.
Bug Fixes
- Updated runtime selection so the configured backend is consistently honored.
Tests
- CI and E2E coverage was updated to run the Apps-based API tests against the Deno runtime when applicable.

dionisio-bot · 2026-07-20T11:03:19Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2026-07-20T11:03:21Z

🦋 Changeset detected

Latest commit: f29822f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@rocket.chat/apps	Minor
@rocket.chat/meteor	Minor
@rocket.chat/core-typings	Minor
@rocket.chat/rest-typings	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-07-20T11:03:38Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 58778d9e-949d-4403-ba25-6afc9d9e48a3

📥 Commits

Reviewing files that changed from the base of the PR and between d5b628f and f29822f.

📒 Files selected for processing (1)

.github/workflows/ci.yml

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/ci.yml

📜 Recent review details

⏰ Context from checks skipped due to timeout. (4)

GitHub Check: cubic · AI code reviewer
GitHub Check: 📦 Build Packages
GitHub Check: CodeQL-Build
GitHub Check: CodeQL-Build

Walkthrough

The apps-engine runtime default changes from Deno to Node, with Deno remaining configurable through APPS_ENGINE_RUNTIME_BACKEND. Enterprise CI workflow jobs are updated to explicitly test the Deno runtime, and a changeset records the package updates.

Changes

Apps runtime selection

Layer / File(s)	Summary
Runtime default selection `packages/apps/src/server/managers/AppRuntimeManager.ts`, `.changeset/apps-engine-runtime-default-node.md`	The default backend and factory selection now use Node, while the changeset documents the Deno override and minor package releases.
Deno CI coverage `.github/workflows/ci.yml`, `.github/workflows/ci-test-e2e.yml`	Enterprise API Apps jobs, container environment setup, dependency aggregation, and conditional E2E steps now target `api-apps-deno`.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

RocketChat/Rocket.Chat#41019: Both changes modify apps-runtime backend selection logic and related Node/Deno CI wiring.

Suggested labels: type: feature

Suggested reviewers: ggazzo

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: switching the default Apps Engine runtime backend from Deno to Node.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-07-20T11:13:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.68%. Comparing base (5ba7bd5) to head (f29822f).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #41474      +/-   ##
===========================================
- Coverage    68.69%   68.68%   -0.01%     
===========================================
  Files         4139     4139              
  Lines       159268   159268              
  Branches     27964    27940      -24     
===========================================
- Hits        109403   109395       -8     
+ Misses       44705    44704       -1     
- Partials      5160     5169       +9

Flag	Coverage Δ
e2e	`58.82% <ø> (-0.02%)`	⬇️
e2e-api	`45.60% <ø> (-0.02%)`	⬇️
unit	`70.66% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Swap the default apps-engine runtime backend from deno to node so the node runtime is exercised by the standard API test suite. The deno runtime can still be selected via APPS_ENGINE_RUNTIME_BACKEND='deno'. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QzzSPVtd9ZcpaezJQtw6mm

Now that node is the default apps-engine runtime backend (covered by the standard API test suite), the dedicated job explicitly exercises the non-default deno runtime. NOTE: this commit only touches .github/workflows/ and cannot be pushed by this session (the GitHub OAuth App lacks the 'workflow' scope). It is kept locally so it can be pushed once workflow scope is granted. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QzzSPVtd9ZcpaezJQtw6mm

d-gubert · 2026-07-27T15:58:39Z

@coderabbitai review

coderabbitai · 2026-07-27T15:58:45Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cubic-dev-ai

All reported issues were addressed across 4 files

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

The tests-done aggregation job still referenced the old test-api-apps-node-ee job in its needs array and result check, which no longer exists after the rename to test-api-apps-deno-ee. Point both at the new job id so the workflow resolves. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QzzSPVtd9ZcpaezJQtw6mm

ggazzo added this to the 8.8.0 milestone Jul 20, 2026

claude added 2 commits July 27, 2026 12:55

d-gubert force-pushed the claude/apps-engine-runtime-swap-a1h7jc branch from f9dd6cb to d5b628f Compare July 27, 2026 15:56

coderabbitai Bot added the type: feature Pull requests that introduces new feature label Jul 27, 2026

d-gubert marked this pull request as ready for review July 27, 2026 17:00

d-gubert requested review from a team as code owners July 27, 2026 17:00

cubic-dev-ai Bot reviewed Jul 27, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml

ggazzo approved these changes Jul 27, 2026

View reviewed changes

ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 27, 2026

dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 27, 2026

dionisio-bot Bot added this pull request to the merge queue Jul 27, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 27, 2026

ggazzo merged commit b27e38c into develop Jul 27, 2026
56 checks passed

ggazzo deleted the claude/apps-engine-runtime-swap-a1h7jc branch July 27, 2026 19:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(apps): swap default runtime backend from deno to node - #41474

chore(apps): swap default runtime backend from deno to node#41474
ggazzo merged 3 commits into
developfrom
claude/apps-engine-runtime-swap-a1h7jc

d-gubert commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

dionisio-bot Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

d-gubert commented Jul 27, 2026

Uh oh!

coderabbitai Bot commented Jul 27, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

d-gubert commented Jul 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

codecov Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

d-gubert commented Jul 27, 2026

Uh oh!

coderabbitai Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

d-gubert commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

dionisio-bot Bot commented Jul 20, 2026 •

edited

Loading

changeset-bot Bot commented Jul 20, 2026 •

edited

Loading

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading

codecov Bot commented Jul 20, 2026 •

edited

Loading

coderabbitai Bot commented Jul 27, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading