Skip to content

test: add missing type attribute and behavior tests for Button component #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Peersheik wants to merge 2 commits into from
+18 −0
Closed

test: add missing type attribute and behavior tests for Button component #1875

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25a4706
test: add missing type attribute tests for Button component
Peersheik Feb 28, 2026
943eec3
Merge pull request #1 from Peersheik/feat/button-default-type
Peersheik Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/fuselage/src/components/Button/Button.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,22 @@ describe('[IconButton Component]', () => {
const results = await axe(container);
expect(results).toHaveNoViolations();
});

it('should default to type="button" to prevent accidental form submissions', () => {
const { getByRole } = render(<Default />);
const button = getByRole('button');
expect(button).toHaveAttribute('type', 'button');
});

it('should allow overriding type attribute when explicitly passed', () => {
const { getByRole } = render(<Default type='submit' />);
const button = getByRole('button');
expect(button).toHaveAttribute('type', 'submit');
});

it('should render as anchor tag when is="a" prop is passed', () => {
const { getByRole } = render(<Default is='a' href='#' />);
const link = getByRole('link');
expect(link.tagName).toBe('A');
});
});