Skip to content

fix(fuselage): autocomplete overlay on MultiSelectFiltered component#1982

Open
nazabucciarelli wants to merge 3 commits into
mainfrom
fix/browser-multiselect-autocomplete
Open

fix(fuselage): autocomplete overlay on MultiSelectFiltered component#1982
nazabucciarelli wants to merge 3 commits into
mainfrom
fix/browser-multiselect-autocomplete

Conversation

@nazabucciarelli
Copy link
Copy Markdown
Collaborator

Proposed changes (including videos or screenshots)

This PR fixes a UI bug where Chrome's native autocomplete/history dropdown overlaps and obscures the custom options list in the MultiSelectFiltered component (specifically observed when searching for users to create a Direct Message in Rocket.Chat).

Root Cause Analysis & Investigation

After deep-diving into the component's history and the recent refactoring, I discovered why this bug suddenly appeared:

The "Before" state (Why Chrome ignored it previously): In older versions of MultiSelect.tsx, attributes like name and id were being spread onto the parent wrapper (). The actual rendered by the anchor was left "anonymous" (without a name attribute). Because it lacked a recognizable name, Chrome's aggressive heuristic engine ignored it and did not attempt to autofill it.

The "After" state (Why the bug appeared): During a recent refactoring to improve accessibility and HTML standards, the id and name attributes were explicitly extracted and correctly passed down to the actual element inside renderAnchor. The PR in which this was done is #1940

The small fix

I added autoComplete="off" directly to the element inside MultiSelectFilteredAnchor.tsx because an input used strictly as an internal search/filter for a combobox dropdown should never trigger browser autofill. Hardcoding this protection at the base level ensures the component is inherently safe, rather than relying on the parent to remember to pass the prop.

Issue(s)

CORE-2205 [Regression] Persistent history bar remains visible in user search

Further comments

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 22, 2026

🦋 Changeset detected

Latest commit: 493b2bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/fuselage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 22, 2026

CLA assistant check
All committers have signed the CLA.

@nazabucciarelli nazabucciarelli changed the title regression: autocomplete overlay on MultiSelectFiltered component fix: autocomplete overlay on MultiSelectFiltered component May 22, 2026
@nazabucciarelli nazabucciarelli changed the title fix: autocomplete overlay on MultiSelectFiltered component fix(fuselage): autocomplete overlay on MultiSelectFiltered component May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants