Skip to content

feat(fuselage): Introduce submenu to Menu component#2038

Open
dougfabris wants to merge 6 commits into
mainfrom
feat/sub-menu
Open

feat(fuselage): Introduce submenu to Menu component#2038
dougfabris wants to merge 6 commits into
mainfrom
feat/sub-menu

Conversation

@dougfabris

@dougfabris dougfabris commented Jun 26, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

CORE-2347

@changeset-bot

changeset-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 56eca00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/fuselage Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliajforesti juliajforesti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an unexpected behavior: I can only close the menu once the submenus are closed - if it's opened, clicking outside, pressing esc or clicking the menu trigger doesn't close them.

@dougfabris dougfabris requested a review from juliajforesti June 29, 2026 16:31
@dougfabris dougfabris marked this pull request as ready for review June 29, 2026 20:06
@mergify

mergify Bot commented Jun 30, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@mergify

mergify Bot commented Jun 30, 2026

Copy link
Copy Markdown

queue

⚠️ Configuration not compatible with a branch protection setting

Details

The branch protection setting Require branches to be up to date before merging is not compatible with draft PR checks. To keep this branch protection enabled, update your Mergify configuration to enable in-place checks: set merge_queue.max_parallel_checks: 1, set every queue rule batch_size: 1, and avoid two-step CI (make merge_conditions identical to queue_conditions). Otherwise, disable this branch protection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants