fix(fuselage): prevent MultiSelect dropdown from reopening on toggle …#2046
Open
SheinRG wants to merge 1 commit into
Open
fix(fuselage): prevent MultiSelect dropdown from reopening on toggle …#2046SheinRG wants to merge 1 commit into
SheinRG wants to merge 1 commit into
Conversation
…click Clicking the toggle of an open MultiSelect blurred the anchor first, firing the debounced `hide()`, which flushed before the trailing `click`. The click handler then read the already-HIDDEN `visible` state and re-opened the dropdown. Toggle now keys off the self-managed `focus-visible` class instead, matching SelectLegacy. Closes RocketChat#1869 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: e25505e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking the toggle of an open MultiSelect blurred the anchor first, firing the debounced
hide(), which flushed before the trailingclick. The click handler then read the already-HIDDENvisiblestate and re-opened the dropdown. Toggle now keys off the self-managedfocus-visibleclass instead, matching SelectLegacy.Closes #1869
This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text.
Proposed changes (including videos or screenshots)
Issue(s)
Further comments