Skip to content

refactor: Get rid of forwardRef#2049

Merged
tassoevan merged 17 commits into
mainfrom
refactor/forward-ref
Jul 2, 2026
Merged

refactor: Get rid of forwardRef#2049
tassoevan merged 17 commits into
mainfrom
refactor/forward-ref

Conversation

@tassoevan

@tassoevan tassoevan commented Jun 30, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

It removes redundant usage of forwardRef.

Issue(s)

Further comments

It's not expected compile-time changes with this changes. Most of the impact might be perceived as a minimal runtime perfomance improvement.

@changeset-bot

changeset-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6d237fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan marked this pull request as ready for review July 1, 2026 02:06
@tassoevan tassoevan requested a review from a team July 1, 2026 02:06
@tassoevan tassoevan force-pushed the refactor/forward-ref branch 2 times, most recently from 413e05b to f790337 Compare July 1, 2026 16:42

@dougfabris dougfabris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found some things:

  • yarn install revert some changes you did to ...api.md
  • we still need the isForwardRefType helper?
  • since you replaced all addon in favor of endAddon can we drop the deprecated prop in this pull request?

Comment thread packages/layout/layout.api.md
@tassoevan tassoevan force-pushed the refactor/forward-ref branch from f790337 to 3b35114 Compare July 1, 2026 22:17
@tassoevan

tassoevan commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

since you replaced all addon in favor of endAddon can we drop the deprecated prop in this pull request?

coming in a following PR

@mergify

mergify Bot commented Jul 2, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@tassoevan tassoevan merged commit 9e13385 into main Jul 2, 2026
7 checks passed
@tassoevan tassoevan deleted the refactor/forward-ref branch July 2, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants