Skip to content

Commit a519952

Browse files
fix(ci): drop unused mock_controller_instance arg from tank-validation tests
pylint W0613 (unused-argument) on 5 schema-validation tests failed the build step (pylint exit 4), blocking this PR and the stacked KML PR #73. These tests only assert a 422 from schema validation, so they never touch the controller; and mock_controller_instance is @pytest.fixture(autouse=True), so it still runs for every test regardless — the parameter was vestigial. No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 2971aa0 commit a519952

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

tests/unit/test_routes/test_motors_route.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ def test_create_liquid_motor_sampled_density(
249249

250250

251251
def test_create_motor_invalid_geometry_kind(
252-
stub_motor_dump, stub_tank_dump, mock_controller_instance
252+
stub_motor_dump, stub_tank_dump
253253
):
254254
stub_tank_dump['geometry'] = {
255255
'geometry_kind': 'pyramid',
@@ -263,7 +263,7 @@ def test_create_motor_invalid_geometry_kind(
263263

264264

265265
def test_create_motor_mass_kind_missing_fields(
266-
stub_motor_dump, stub_tank_dump, mock_controller_instance
266+
stub_motor_dump, stub_tank_dump
267267
):
268268
# stub_tank_dump defaults to MASS_FLOW with all required fields
269269
# populated; switching to MASS without adding liquid_mass/gas_mass
@@ -280,7 +280,7 @@ def test_create_motor_mass_kind_missing_fields(
280280

281281

282282
def test_create_motor_level_kind_missing_liquid_height(
283-
stub_motor_dump, stub_tank_dump, mock_controller_instance
283+
stub_motor_dump, stub_tank_dump
284284
):
285285
stub_tank_dump['tank_kind'] = 'LEVEL'
286286
stub_motor_dump.update(
@@ -292,7 +292,7 @@ def test_create_motor_level_kind_missing_liquid_height(
292292

293293

294294
def test_create_motor_ullage_kind_missing_ullage(
295-
stub_motor_dump, stub_tank_dump, mock_controller_instance
295+
stub_motor_dump, stub_tank_dump
296296
):
297297
stub_tank_dump['tank_kind'] = 'ULLAGE'
298298
stub_motor_dump.update(
@@ -304,7 +304,7 @@ def test_create_motor_ullage_kind_missing_ullage(
304304

305305

306306
def test_create_motor_mass_flow_kind_missing_flow_rates(
307-
stub_motor_dump, mock_controller_instance
307+
stub_motor_dump
308308
):
309309
# Build a tank payload with MASS_FLOW kind but no flow-rate fields
310310
# so the guard rejects it.

0 commit comments

Comments
 (0)