Commit 00e4952
BUG: call evaluate_rotation_matrix in EllipticalFin/FreeFormFin __init__
EllipticalFin.__init__ and FreeFormFin.__init__ never called
self.evaluate_rotation_matrix(), unlike TrapezoidalFin. As a result the
_rotation_body_to_fin / _rotation_fin_to_body_uncanted matrices were never
created, so adding either fin to a Rocket crashed:
Rocket.__add_single_surface -> Fin._compute_leading_edge_position
-> AttributeError: 'EllipticalFin' object has no attribute
'_rotation_fin_to_body_uncanted'
Both are new public classes in v1.13.0 and were fully unusable on the normal
add-to-rocket / simulate path. Existing tests only exercised the trapezoidal
singular fin, so this went uncaught.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent bee0e16 commit 00e4952
2 files changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
| 163 | + | |
163 | 164 | | |
164 | 165 | | |
165 | 166 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| 151 | + | |
151 | 152 | | |
152 | 153 | | |
153 | 154 | | |
| |||
0 commit comments