Skip to content

Commit 31d5311

Browse files
committed
MNT: improve name of run_geometry_update_chain
1 parent 6bf61db commit 31d5311

7 files changed

Lines changed: 19 additions & 19 deletions

File tree

rocketpy/rocket/aero_surface/fins/_base_fin.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ def _update_reference_quantities(self):
5555
self.reference_area = np.pi * self._rocket_radius**2
5656
self.reference_length = self.rocket_diameter
5757

58-
def _run_geometry_update_chain(self):
59-
"""Recompute all dependent aerodynamic properties after a geometry change."""
58+
def _update_geometry_chain(self):
59+
"""Update geometry-dependent quantities in dependency order."""
6060
self.evaluate_geometrical_parameters()
6161
self.evaluate_center_of_pressure()
6262
self.evaluate_lift_coefficient()
@@ -84,7 +84,7 @@ def rocket_radius(self, value):
8484
"""
8585
self._rocket_radius = value
8686
self._update_reference_quantities()
87-
self._run_geometry_update_chain()
87+
self._update_geometry_chain()
8888

8989
@property
9090
def rocket_diameter(self):
@@ -147,7 +147,7 @@ def root_chord(self, value):
147147
Root chord length in meters.
148148
"""
149149
self._root_chord = value
150-
self._run_geometry_update_chain()
150+
self._update_geometry_chain()
151151

152152
@property
153153
def span(self):
@@ -170,7 +170,7 @@ def span(self, value):
170170
Fin span in meters.
171171
"""
172172
self._span = value
173-
self._run_geometry_update_chain()
173+
self._update_geometry_chain()
174174

175175
@property
176176
def cant_angle(self):
@@ -216,7 +216,7 @@ def cant_angle_rad(self, value):
216216
Cant angle in radians.
217217
"""
218218
self._cant_angle_rad = value
219-
self._run_geometry_update_chain()
219+
self._update_geometry_chain()
220220

221221
@property
222222
def airfoil(self):
@@ -241,7 +241,7 @@ def airfoil(self, value):
241241
or None for planar fin.
242242
"""
243243
self._airfoil = value
244-
self._run_geometry_update_chain()
244+
self._update_geometry_chain()
245245

246246
def info(self):
247247
"""Print fin geometry and lift information."""

rocketpy/rocket/aero_surface/fins/elliptical_fin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ def __init__(
158158
)
159159

160160
self.geometry = _EllipticalGeometry(self)
161-
self._run_geometry_update_chain()
161+
self._update_geometry_chain()
162162

163163
self.prints = _EllipticalFinPrints(self)
164164
self.plots = _EllipticalFinPlots(self)

rocketpy/rocket/aero_surface/fins/elliptical_fins.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ def __init__(
159159
)
160160

161161
self.geometry = _EllipticalGeometry(self)
162-
self._run_geometry_update_chain()
162+
self._update_geometry_chain()
163163

164164
self.prints = _EllipticalFinsPrints(self)
165165
self.plots = _EllipticalFinsPlots(self)

rocketpy/rocket/aero_surface/fins/free_form_fin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def __init__(
146146
)
147147

148148
self.geometry = _FreeFormGeometry(self, shape_points)
149-
self._run_geometry_update_chain()
149+
self._update_geometry_chain()
150150

151151
self.prints = _FreeFormFinPrints(self)
152152
self.plots = _FreeFormFinPlots(self)

rocketpy/rocket/aero_surface/fins/free_form_fins.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def __init__(
145145
)
146146

147147
self.geometry = _FreeFormGeometry(self, shape_points)
148-
self._run_geometry_update_chain()
148+
self._update_geometry_chain()
149149

150150
self.prints = _FreeFormFinsPrints(self)
151151
self.plots = _FreeFormFinsPlots(self)

rocketpy/rocket/aero_surface/fins/trapezoidal_fin.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def __init__(
161161
sweep_length=sweep_length,
162162
sweep_angle=sweep_angle,
163163
)
164-
self._run_geometry_update_chain()
164+
self._update_geometry_chain()
165165
self.evaluate_rotation_matrix()
166166

167167
self.prints = _TrapezoidalFinPrints(self)
@@ -174,7 +174,7 @@ def tip_chord(self):
174174
@tip_chord.setter
175175
def tip_chord(self, value):
176176
self.geometry.tip_chord = value
177-
self._run_geometry_update_chain()
177+
self._update_geometry_chain()
178178

179179
@property
180180
def sweep_angle(self):
@@ -183,7 +183,7 @@ def sweep_angle(self):
183183
@sweep_angle.setter
184184
def sweep_angle(self, value):
185185
self.geometry.sweep_angle = value
186-
self._run_geometry_update_chain()
186+
self._update_geometry_chain()
187187

188188
@property
189189
def sweep_length(self):
@@ -192,7 +192,7 @@ def sweep_length(self):
192192
@sweep_length.setter
193193
def sweep_length(self, value):
194194
self.geometry.sweep_length = value
195-
self._run_geometry_update_chain()
195+
self._update_geometry_chain()
196196

197197
def evaluate_center_of_pressure(self):
198198
"""Calculates and returns the center of pressure of the fin in local

rocketpy/rocket/aero_surface/fins/trapezoidal_fins.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def __init__(
171171
sweep_length=sweep_length,
172172
sweep_angle=sweep_angle,
173173
)
174-
self._run_geometry_update_chain()
174+
self._update_geometry_chain()
175175

176176
self.prints = _TrapezoidalFinsPrints(self)
177177
self.plots = _TrapezoidalFinsPlots(self)
@@ -183,7 +183,7 @@ def tip_chord(self):
183183
@tip_chord.setter
184184
def tip_chord(self, value):
185185
self.geometry.tip_chord = value
186-
self._run_geometry_update_chain()
186+
self._update_geometry_chain()
187187

188188
@property
189189
def sweep_angle(self):
@@ -192,7 +192,7 @@ def sweep_angle(self):
192192
@sweep_angle.setter
193193
def sweep_angle(self, value):
194194
self.geometry.sweep_angle = value
195-
self._run_geometry_update_chain()
195+
self._update_geometry_chain()
196196

197197
@property
198198
def sweep_length(self):
@@ -201,7 +201,7 @@ def sweep_length(self):
201201
@sweep_length.setter
202202
def sweep_length(self, value):
203203
self.geometry.sweep_length = value
204-
self._run_geometry_update_chain()
204+
self._update_geometry_chain()
205205

206206
def evaluate_center_of_pressure(self):
207207
"""Calculates and returns the center of pressure of the fin set in local

0 commit comments

Comments
 (0)