MNT: lint

Author: MateusStano

.pylintrc

@@ -229,6 +229,11 @@ good-names=FlightPhases,
            center_of_mass_without_motor_to_CDM,
            motor_center_of_dry_mass_to_CDM,
            generic_motor_cesaroni_M1520,
+           R_phi,
+           R_delta, 
+           R_pi,
+           R_uncanted,
+           R_body_to_fin, 
 
 # Good variable names regexes, separated by a comma. If names match any regex,
 # they will always be accepted

rocketpy/plots/aero_surface_plots.py

@@ -1,3 +1,5 @@
+# pylint: disable=too-many-statements
+
 from abc import ABC, abstractmethod
 
 import matplotlib.pyplot as plt
@@ -139,10 +141,6 @@ class _FinsPlots(_AeroSurfacePlots):
     """Abstract class that contains all fin plots. This class inherits from the
     _AeroSurfacePlots class."""
 
-    @abstractmethod
-    def draw(self, *, filename=None):
-        pass
-
     def airfoil(self):
         """Plots the airfoil information when the fin has an airfoil shape. If
         the fin does not have an airfoil shape, this method does nothing.
@@ -200,10 +198,6 @@ class _FinPlots(_AeroSurfacePlots):
     """Abstract class that contains all fin plots. This class inherits from the
     _AeroSurfacePlots class."""
 
-    @abstractmethod
-    def draw(self):
-        pass
-
     def airfoil(self):
         """Plots the airfoil information when the fin has an airfoil shape. If
         the fin does not have an airfoil shape, this method does nothing.
@@ -259,7 +253,6 @@ def all(self):
 class _TrapezoidalFinsPlots(_FinsPlots):
     """Class that contains all trapezoidal fin plots."""
 
-    # pylint: disable=too-many-statements
     def draw(self, *, filename=None):
         """Draw the fin shape along with some important information, including
         the center line, the quarter line and the center of pressure position.
@@ -388,8 +381,7 @@ def draw(self, *, filename=None):
 class _TrapezoidalFinPlots(_FinPlots):
     """Class that contains all trapezoidal fin plots."""
 
-    # pylint: disable=too-many-statements
-    def draw(self):
+    def draw(self, *, filename=None):
         """Draw the fin shape along with some important information, including
         the center line, the quarter line and the center of pressure position.
 
@@ -509,7 +501,6 @@ def draw(self):
 class _EllipticalFinsPlots(_FinsPlots):
     """Class that contains all elliptical fin plots."""
 
-    # pylint: disable=too-many-statements
     def draw(self, *, filename=None):
         """Draw the fin shape along with some important information.
         These being: the center line and the center of pressure position.
@@ -588,8 +579,7 @@ def draw(self, *, filename=None):
 class _EllipticalFinPlots(_FinPlots):
     """Class that contains all elliptical fin plots."""
 
-    # pylint: disable=too-many-statements
-    def draw(self):
+    def draw(self, *, filename=None):
         """Draw the fin shape along with some important information.
         These being: the center line and the center of pressure position.
 
@@ -659,7 +649,6 @@ def draw(self):
 class _FreeFormFinsPlots(_FinsPlots):
     """Class that contains all free form fin plots."""
 
-    # pylint: disable=too-many-statements
     def draw(self, *, filename=None):
         """Draw the fin shape along with some important information.
         These being: the center line and the center of pressure position.
@@ -734,7 +723,6 @@ def draw(self, *, filename=None):
 class _FreeFormFinPlots(_FinPlots):
     """Class that contains all free form fin plots."""
 
-    # pylint: disable=too-many-statements
     def draw(self, *, filename=None):
         """Draw the fin shape along with some important information.
         These being: the center line and the center of pressure position.

rocketpy/plots/rocket_plots.py

@@ -221,7 +221,7 @@ def __validate_aerodynamic_surfaces(self, plane):
             raise ValueError(
                 "The rocket must have at least one aerodynamic surface to be drawn."
             )
-        if plane != "xz" and plane != "yz":
+        if plane not in ("xz", "yz"):
             raise ValueError("The plane must be 'xz' or 'yz'. The default is 'xz'.")
 
     def _draw_aerodynamic_surfaces(self, ax, vis_args, plane, surfaces):
@@ -410,6 +410,8 @@ def _draw_generic_surface(
             x_pos = position[2]
             # y position of the surface is the y position in the plot
             y_pos = position[1]
+        else:
+            raise ValueError("Plane must be 'xz' or 'yz'.")
 
         ax.scatter(
             x_pos,

rocketpy/rocket/aero_surface/fins/_base_fin.py

@@ -1,5 +1,5 @@
 import math
-from abc import ABC, abstractmethod
+from abc import abstractmethod
 
 import numpy as np
 

rocketpy/rocket/aero_surface/fins/elliptical_fins.py

@@ -1,5 +1,3 @@
-import numpy as np
-
 from rocketpy.plots.aero_surface_plots import _EllipticalFinsPlots
 from rocketpy.prints.aero_surface_prints import _EllipticalFinsPrints
 from rocketpy.rocket.aero_surface.fins._elliptical_mixin import _EllipticalMixin

rocketpy/rocket/aero_surface/fins/fin.py

@@ -381,7 +381,7 @@ def compute_forces_and_moments(
         M3 += M3_damping
         return R1, R2, R3, M1, M2, M3
 
-    def __compute_leading_edge_position(self, position, _csys):
+    def _compute_leading_edge_position(self, position, _csys):
         """Computes the position of the fin leading edge in a rocket's user,
         given its position in a rocket."""
         # Point from deflection from cant angle in the plane perpendicular to

rocketpy/rocket/aero_surface/fins/fins.py

@@ -3,8 +3,6 @@
 from rocketpy.mathutils.function import Function
 from rocketpy.rocket.aero_surface.fins._base_fin import _BaseFin
 
-from ..aero_surface import AeroSurface
-
 
 class Fins(_BaseFin):
     """Abstract class that holds common methods for the fin classes.

rocketpy/rocket/aero_surface/fins/trapezoidal_fins.py

@@ -1,5 +1,3 @@
-import numpy as np
-
 from rocketpy.plots.aero_surface_plots import _TrapezoidalFinsPlots
 from rocketpy.prints.aero_surface_prints import _TrapezoidalFinsPrints
 from rocketpy.rocket.aero_surface.fins._trapezoidal_mixin import _TrapezoidalMixin

rocketpy/rocket/rocket.py

@@ -1008,7 +1008,7 @@ def __add_single_surface(self, surface, position):
         if isinstance(surface, (TrapezoidalFin, EllipticalFin, FreeFormFin)):
             # TODO: this depends on cant angle, so it should somehow be
             # recalculated whenever the cant angle of the fin changes
-            position = surface._Fin__compute_leading_edge_position(position, self._csys)
+            position = surface._compute_leading_edge_position(position, self._csys)
         else:
             position = (
                 Vector([0, 0, position])