Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: Gui-FernandesBR

rocketpy/mathutils/function.py

@@ -679,7 +679,6 @@ def __determine_2d_domain_bounds(self, lower, upper, samples):
                     if self.__cropped_domain__[i][1] < domain[i][1]:
                         domain[i][1] = self.__cropped_domain__[i][1]
 
-        lower = lower if lower is not None else [domain[0][0], domain[1][0]]
         lower = [domain[0][0], domain[1][0]] if lower is None else lower
         lower = 2 * [lower] if isinstance(lower, NUMERICAL_TYPES) else lower
         upper = [domain[0][1], domain[1][1]] if upper is None else upper
@@ -1020,7 +1019,7 @@ def __set_cropped_domain_2d(self, cropped_func, x_lim):
             Range of values with lower and upper limits.
         """
         if len(x_lim) < 2:
-            raise IndexError("x_lim must be of index 2 for 2-D function")
+            raise IndexError("x_lim must have a length of 2 for 2-D function")
 
         if x_lim[0] is not None and x_lim[0][0] < x_lim[0][1]:
             cropped_func.__cropped_domain__ = [x_lim[0]]
@@ -1183,9 +1182,9 @@ def clipped_function(*args):
         except ValueError as e:
             raise ValueError(
                 "Cannot clip function as function reduces to "
-                f"{len(clipped_func.source)} points (too few data points to define"
-                " a domain). Number of rows must be equal to number of "
-                "columns after applying clipping function."
+                f"{len(clipped_func.source) if isinstance(clipped_func.source, (list, np.ndarray)) else 'unknown'} points (too few data points to define"
+                " a domain). Ensure that the source is array-like and has "
+                "sufficient data points after applying the clipping function."
             ) from e
 
         return clipped_func
@@ -1821,7 +1820,7 @@ def plot_1d(  # pylint: disable=too-many-statements
             if self.__cropped_domain__ is not None:
                 if self.__cropped_domain__[0] > domain[0]:
                     domain[0] = self.__cropped_domain__[0]
-                if self.__cropped_domain__[1] > domain[1]:
+                if self.__cropped_domain__[1] < domain[1]:
                     domain[1] = self.__cropped_domain__[1]
             lower = domain[0] if lower is None else lower
             upper = domain[1] if upper is None else upper

tests/unit/test_function.py

@@ -276,7 +276,7 @@ def test_crop_ndarray(array3dsource, array3dcropped):  # pylint: disable=unused-
     The source is initialized as a ndarray before cropping.
     """
     func = Function(array3dsource, inputs=["x1", "x2"], outputs="y")
-    cropped_func = func.crop([(-1, 1), (-2, 2)])  # pylint: disable=unused-argument
+    cropped_func = func.crop([(-1, 1), (-2, 2)])
 
     assert isinstance(func, Function)
     assert isinstance(cropped_func, Function)