Skip to content

Commit 6f248ba

Browse files
DOC: add TODO to migrate raw raises to custom RocketPy exceptions
Addresses the review note in exceptions.py: reminds contributors to progressively adopt the custom RocketPyError subclasses across the codebase (and add new exception types here) instead of raising bare ValueError/TypeError. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 9d4e01e commit 6f248ba

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

rocketpy/exceptions.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
"""Custom exceptions and warnings for RocketPy."""
22

3+
# TODO: progressively adopt these custom exceptions across the codebase.
4+
# Many modules still ``raise ValueError``/``TypeError`` directly; migrate those
5+
# to the appropriate ``RocketPyError`` subclass (adding new exception types here
6+
# as needed) so users can reliably catch ``RocketPyError`` and its subclasses.
7+
38

49
class RocketPyError(Exception):
510
"""Base class for all RocketPy exceptions."""

0 commit comments

Comments
 (0)