Skip to content

Commit 7f11a31

Browse files
MNT: make logging-test fixture autouse to satisfy pylint
The reset_rocketpy_logger fixture was passed as an explicit test argument, which pylint (W0613, unused-argument) flags. Restore the autouse pattern the tests originally used in test_utils.py so the fixture runs without being a parameter. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent ded9c9a commit 7f11a31

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

tests/unit/test_utilities.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ def test_load_from_rpy(mock_show): # pylint: disable=unused-argument
351351
# --- Logging (rocketpy.utilities.enable_logging) ------------------------------
352352

353353

354-
@pytest.fixture
354+
@pytest.fixture(autouse=True)
355355
def reset_rocketpy_logger():
356356
"""Reset the rocketpy logger to its original state after each test."""
357357
logger = logging.getLogger("rocketpy")
@@ -362,7 +362,7 @@ def reset_rocketpy_logger():
362362
logger.setLevel(original_level)
363363

364364

365-
def test_enable_logging_adds_stream_handler(reset_rocketpy_logger):
365+
def test_enable_logging_adds_stream_handler():
366366
"""enable_logging() must attach a StreamHandler to the rocketpy logger."""
367367
utilities.enable_logging(level="INFO")
368368

@@ -373,7 +373,7 @@ def test_enable_logging_adds_stream_handler(reset_rocketpy_logger):
373373
assert len(stream_handlers) >= 1
374374

375375

376-
def test_enable_logging_sets_correct_level(reset_rocketpy_logger):
376+
def test_enable_logging_sets_correct_level():
377377
"""enable_logging() must set the requested level on the rocketpy logger."""
378378
utilities.enable_logging(level="DEBUG")
379379
assert logging.getLogger("rocketpy").level == logging.DEBUG
@@ -382,7 +382,7 @@ def test_enable_logging_sets_correct_level(reset_rocketpy_logger):
382382
assert logging.getLogger("rocketpy").level == logging.WARNING
383383

384384

385-
def test_enable_logging_no_duplicate_handlers(reset_rocketpy_logger):
385+
def test_enable_logging_no_duplicate_handlers():
386386
"""Calling enable_logging() twice must not duplicate StreamHandlers."""
387387
utilities.enable_logging(level="INFO")
388388
utilities.enable_logging(level="INFO")
@@ -394,7 +394,7 @@ def test_enable_logging_no_duplicate_handlers(reset_rocketpy_logger):
394394
assert len(stream_handlers) == 1
395395

396396

397-
def test_enable_logging_replaces_handler_on_level_change(reset_rocketpy_logger):
397+
def test_enable_logging_replaces_handler_on_level_change():
398398
"""Calling enable_logging() with a new level must replace the old handler."""
399399
utilities.enable_logging(level="WARNING")
400400
utilities.enable_logging(level="DEBUG")
@@ -407,13 +407,13 @@ def test_enable_logging_replaces_handler_on_level_change(reset_rocketpy_logger):
407407
assert logger.level == logging.DEBUG
408408

409409

410-
def test_enable_logging_invalid_level_raises(reset_rocketpy_logger):
410+
def test_enable_logging_invalid_level_raises():
411411
"""enable_logging() must raise ValueError for an unrecognised level string."""
412412
with pytest.raises(ValueError, match="Invalid logging level"):
413413
utilities.enable_logging(level="INVALID")
414414

415415

416-
def test_enable_logging_messages_are_captured(reset_rocketpy_logger, caplog):
416+
def test_enable_logging_messages_are_captured(caplog):
417417
"""After enable_logging(), internal rocketpy log messages must be visible."""
418418
utilities.enable_logging(level="DEBUG")
419419

0 commit comments

Comments
 (0)