STY: Fix pylint for parachute triggers

Author: ViniciusCMB

rocketpy/rocket/parachute.py

@@ -8,7 +8,7 @@
 from ..prints.parachute_prints import _ParachutePrints
 
 
-def detect_motor_burnout(pressure, height, state_vector, u_dot):
+def detect_motor_burnout(_pressure, height, state_vector, u_dot):
     """Detect motor burnout by sudden drop in acceleration.
 
     Returns True when vertical acceleration becomes significantly negative
@@ -48,7 +48,7 @@ def detect_motor_burnout(pressure, height, state_vector, u_dot):
         return False
 
 
-def detect_apogee_acceleration(pressure, height, state_vector, u_dot):
+def detect_apogee_acceleration(_pressure, _height, state_vector, u_dot):
     """Detect apogee using near-zero vertical velocity and negative vertical accel.
 
     Apogee occurs when the rocket reaches its highest point, characterized by
@@ -71,7 +71,7 @@ def detect_apogee_acceleration(pressure, height, state_vector, u_dot):
         return False
 
 
-def detect_freefall(pressure, height, state_vector, u_dot):
+def detect_freefall(_pressure, height, state_vector, u_dot):
     """Detect free-fall when total acceleration magnitude is low.
 
     Free-fall is characterized by acceleration magnitude close to gravitational
@@ -107,7 +107,7 @@ def detect_freefall(pressure, height, state_vector, u_dot):
         return False
 
 
-def detect_liftoff(pressure, height, state_vector, u_dot):
+def detect_liftoff(_pressure, _height, _state_vector, u_dot):
     """Detect liftoff by high total acceleration.
 
     Liftoff is characterized by a sudden increase in acceleration as the motor
@@ -139,7 +139,7 @@ def altitude_trigger_factory(target_altitude, require_descent=True):
     (descending) to avoid firing during ascent.
     """
 
-    def trigger(pressure, height, state_vector, u_dot=None):
+    def trigger(_pressure, height, state_vector, _u_dot=None):
         vz = float(state_vector[5])
         if require_descent:
             return (height <= target_altitude) and (vz < 0)
@@ -359,7 +359,7 @@ def __init__(
 
         self.__evaluate_trigger_function(trigger)
 
-    def __evaluate_trigger_function(self, trigger):
+    def __evaluate_trigger_function(self, trigger):  # pylint: disable=too-many-statements
         """This is used to set the triggerfunc attribute that will be used to
         interact with the Flight class.
 

rocketpy/simulation/flight.py

@@ -1,11 +1,11 @@
 # pylint: disable=too-many-lines
+import inspect
 import math
 import warnings
 from copy import deepcopy
 from functools import cached_property
 
 import numpy as np
-import inspect
 from scipy.integrate import BDF, DOP853, LSODA, RK23, RK45, OdeSolver, Radau
 
 from rocketpy.simulation.flight_data_exporter import FlightDataExporter
@@ -1236,10 +1236,10 @@ def _evaluate_parachute_trigger(
                         if noise.size == 3:
                             # u_dot layout: [vx, vy, vz, ax, ay, az, ...]
                             u_dot[3:6] = u_dot[3:6] + noise
-                    except Exception:
+                    except (ValueError, TypeError):
                         # ignore noise errors and continue
                         pass
-            except Exception:
+            except (ValueError, TypeError, RuntimeError):
                 # If u_dot computation fails, leave as None
                 u_dot = None
 

tests/unit/test_parachute_trigger_acceleration.py

@@ -1,19 +1,18 @@
 import numpy as np
-import pytest
 
 from rocketpy.simulation.flight import Flight
 from rocketpy.rocket.parachute import Parachute
 
 
 def test_trigger_receives_u_dot_and_noise():
     # Prepare derivative function that returns known u_dot
-    def derivative_func(t, y):
+    def derivative_func(_t, _y):
         return np.array([0, 0, 0, 1.0, 2.0, 3.0, 0, 0, 0, 0, 0, 0, 0])
 
     recorded = {}
 
     # User trigger expecting u_dot named exactly 'u_dot'
-    def user_trigger(p, h, y, u_dot):
+    def user_trigger(_p, _h, _y, u_dot):
         recorded["u_dot"] = np.array(u_dot)
         return True
 
@@ -48,12 +47,12 @@ def user_trigger(p, h, y, u_dot):
 
 
 def test_trigger_with_sensors_and_u_dot():
-    def derivative_func(t, y):
+    def derivative_func(_t, _y):
         return np.array([0, 0, 0, -1.0, -2.0, -3.0, 0, 0, 0, 0, 0, 0, 0])
 
     recorded = {}
 
-    def user_trigger(p, h, y, sensors, u_dot):
+    def user_trigger(_p, _h, _y, sensors, u_dot):
         recorded["sensors"] = sensors
         recorded["u_dot"] = np.array(u_dot)
         return False
@@ -86,12 +85,12 @@ def user_trigger(p, h, y, sensors, u_dot):
 
 def test_legacy_trigger_does_not_compute_u_dot():
     # derivative function that raises if called
-    def derivative_func(t, y):
+    def derivative_func(_t, _y):
         raise RuntimeError("derivative should not be called for legacy triggers")
 
     called = {}
 
-    def legacy_trigger(p, h, y):
+    def legacy_trigger(_p, _h, _y):
         called["ok"] = True
         return True